My script failed and can't fix it ?


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting My script failed and can't fix it ?
# 1  
Old 04-19-2013
My script failed and can't fix it ?

Hi ,
I'd like to give you a little bit idea about my script which is used to get any generated file from remote server using ftp session then organized those file into directories based on their date ( at the end I supposed to have 1 months directories 20130401 20130402 ....20130430 ,
unfortunately my script which contains " two different block" went wrong whenever run it, please note that I run each block individually and success , could someone pass through every line & tell my what mistaken I did , thanks lot :-


Code:
#!/bin/sh
ddir=/dest     
sdir=/src/user/     
[ -d $sdir ] || mkdir -p  $sdir
echo  "$0 started: $(date)"
ftp -in x,x,x,x  << ENDFTP
user username password
cd $ddir
lcd $sdir
bin
prompt
mget *.text
bye
ENDFTP
echo  "$0 finished: $(date)"
cd $sdir
for dir in $( ls -1  | cut -c1-8 | sort -u ) ; do
    [ -d $dir ] || mkdir  -p $dir      
    for file in $( find $dir  -type f ) ; do
          echo "Move $file  to  $dir"
          mv  $file  $dir          
    done
done

Smilie

Last edited by arm; 04-19-2013 at 08:08 PM..
# 2  
Old 04-19-2013
Change "find dir" to "find $dir".
# 3  
Old 04-19-2013
Please use code tags as required by forum rules!

The only obvious mistake I can find at first glance is
Code:
for file in $( find  dir  -type f ) ;

will not start the search in the respective directory; use find $dir instead.
# 4  
Old 04-19-2013
no dears I already did that in my rel system , this mistake happened while copy paste , please find another clue ..Smilie
# 5  
Old 04-19-2013
Please use code tags as required by forum rules!

And: post an execution log of your script running (= set the -x option)
This User Gave Thanks to RudiC For This Post:
# 6  
Old 04-19-2013
done

thanks for reminding me about the code tag , the change has been done ..

Quote:
Originally Posted by RudiC
Please use code tags as required by forum rules!

And: post an execution log of your script running (= set the -x option)
# 7  
Old 04-19-2013
What's the error message? What's the specific problem? And please send an example of the directory structure. Then the dears can help you. Smilie
This User Gave Thanks to hanson44 For This Post:
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Fix script to get missing information

Gents, Can you please help me to fix the following script in order to get complete data as desired. I am missing some data in output. the complete input file is attached. The script I am using is awk '{\ status=substr($0,91,2)\ ind=substr($0,26,1);\ ... (10 Replies)
Discussion started by: jiam912
10 Replies

2. UNIX for Dummies Questions & Answers

How to fix Python path for some script/app?

Hello, i have: # python -V Python 2.7.6 But original for my CentOS is 2.3 or 2.4 my python folder: /root/python2.7.6 (inside are folders like lib, include, bin, share) I launched app iotop: # iotop -od 6 Traceback (most recent call last): File "/usr/bin/iotop", line 16, in... (3 Replies)
Discussion started by: postcd
3 Replies

3. Shell Programming and Scripting

How to fix my IMDB Script

Hello, I am using IMDB bot file for my movie site.. But I get this message like this---Parse error: syntax error, unexpected end of file, expecting variable (T_VARIABLE) or ${ (T_DOLLAR_OPEN_CURLY_BRACES) or {$ (T_CURLY_OPEN) in... (2 Replies)
Discussion started by: lg2013
2 Replies

4. UNIX for Dummies Questions & Answers

Please help to fix awk script

Good morning, fellows. I would need to ask for your help in editing my awk script. Here is the original version: BEGIN { printf ("CRYST1 200.000 200.000 200.000 90.00 90.00 90.00 P 1 1\n") maxatoms=1000 natom=0 found_struct = 0 found_bond = 0 } { if( NF == 5 ) { foundff=0 natom++... (9 Replies)
Discussion started by: snysmumrik
9 Replies

5. Windows & DOS: Issues & Discussions

Fix script error (%%n)

Hi, I'm currently tinkering with a script that uses the for command to process all *.gif files in the current folder. I marked the spot where it exits out with an error by adding a "pause" The error message given is: convert.exe: unable to open image `%x': No such file or directory @... (2 Replies)
Discussion started by: pasc
2 Replies

6. Shell Programming and Scripting

ksh script failed while using -x

Hi, I have a Kshell script that is failed if i am using the -x option. $ cat ListOfFiles.lst \+DATA_DM01/pudwh/datafile/dw_billing_tts_1 \+DATA_DM01/pudwh/datafile/dw_billing_tts_2 ... (2 Replies)
Discussion started by: yoavbe
2 Replies

7. Shell Programming and Scripting

AWK script getting failed

Hi All, Below is my code , In the code below the "If" condition is getting failed. I dont know what is getting wrong here , may be i can not use may logical operator at once or something else OR brackets under If condition are to be organised . Please help!! if ($11 == "0" &&... (1 Reply)
Discussion started by: unknown123
1 Replies

8. Shell Programming and Scripting

script for failed processes

I want to write a script that log all the failed processes and start the same process. For that I have already write a script that gives all the PID #!/bin/ksh pid= `ps -ef |grep "ov" |grep -v "grep"| awk '{print $2}'` echo $pid if ; then echo "process is running" else echo... (4 Replies)
Discussion started by: kumarabhi84
4 Replies

9. Shell Programming and Scripting

how to fix this awk script?

i have a log file while looks like this ++ user_a blabla blabla nas_b blabla user_d this is a user_a junk line another junk line user_c nas_m blabla ++ basically most of the lines contain a "user" keywords, and the rest of the lines do not have "user" at all. So I have the... (17 Replies)
Discussion started by: fedora
17 Replies

10. Shell Programming and Scripting

fix a problem in this script

z=9 i=0 h=02 min=55 while do cat /home/barmecha/test | grep $h:$min >> /home/barmecha/file1 min=`expr $min + 1` if ; then h=`expr $h + 1` fi i=`expr $i + 1` done i have a log file with time wise log in it, this script help me to pull out logs of the give time interval...but the... (8 Replies)
Discussion started by: abhishek27
8 Replies
Login or Register to Ask a Question

Featured Tech Videos