Dealing with white spaces in bash scripts


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Dealing with white spaces in bash scripts
# 1  
Old 03-16-2013
Dealing with white spaces in bash scripts

I'm trying to search for all files in directory with particular GID then change the GID to match the UID of each file:

Code:
#!/bin/sh

for i in $(find /dump -gid 200 | sed 's/\ /\\\ /g' | sed 's/\&/\\\&/g'); do
  chgrp $(ls -ln ${i} | awk '{print $3}') ${i}
done

I'm using sed to deal with spaces and special characters.

I get a clean output from the find command when run on its own; I also get the desired result when I run chgrp and substitute a line from output of find into each instance of variable ${i}.

But when I run the script, I get many errors and not all the files/directories have been chgrp as desired.

Here's an excerpt of the errors I'm seeing:

Code:
chgrp: missing operand after `/dump/aaa36/.evolution/memos/config'
Try `chgrp --help' for more information.
chgrp: missing operand after `/dump/aaa36/.evolution/calendar/config'
Try `chgrp --help' for more information.
chgrp: missing operand after `/dump/aaa36/.evolution/tasks/config'
Try `chgrp --help' for more information.
chgrp: missing operand after `/dump/aaa36/.evolution/cache'
Try `chgrp --help' for more information.
ls: cannot access /dump/aaa36/untitled\: No such file or directory
chgrp: missing operand after `/dump/aaa36/untitled\\'
Try `chgrp --help' for more information.
ls: cannot access folder: No such file or directory
chgrp: missing operand after `folder'
Try `chgrp --help' for more information.
ls: cannot access /dump/aaa36/untitled\: No such file or directory
chgrp: missing operand after `/dump/aaa36/untitled\\'
Try `chgrp --help' for more information.
ls: cannot access folder/neutron_EDM.pdf: No such file or directory
chgrp: missing operand after `folder/neutron_EDM.pdf'
Try `chgrp --help' for more information.

Please tell me what I'm doing wrong?! Thanks :-)

---------- Post updated at 08:26 PM ---------- Previous update was at 07:56 PM ----------

OK, solved my own problem...

It's because for loops process space as field separators. I found a neat way to get around this:

Code:
#!/bin/sh

SAVEIFS=$IFS
IFS=$(echo -en "\n\b")

for i in $(find /dump -gid 200 | sed 's/\s\+/\\ /g' | sed 's/\&\+/\\\&/g'); do
  chgrp $(ls -ln ${i} | awk '{print $3}') ${i}

done

IFS=$SAVEIFS

Thanks to: nixCraft (BASH Shell: For Loop File Names With Spaces)
# 2  
Old 03-16-2013
Another way:
Code:
find /dump -gid 200 |
while read i; do
  echo Do something with "$i"
done

Additional note: it is advisable to put double quotes around variable references.
# 3  
Old 03-16-2013
Wow nice, thanks Scrutinizer...

Your solution certainly does away with having to fix white spaces, which is neater.

In fact my previous solution failed because when I tried to list directories the output was "total 0" and you cannot chgrp that!

And due to the nature of the find command, I had to expand it into 3 parts. And it's probably not sensible to mess about with sed as this wouldn't account for all special characters:
Code:
#!/bin/sh

SAVEIFS=$IFS
IFS=$(echo -en "\n\b")

for i in $(find /dump -type f -gid 200); do
  chgrp `ls -ln "${i}" | awk '{print $3}'` "${i}"
done

for i in $(find /dump -type d -gid 200); do
  chgrp `ls -lnd "${i}" | awk '{print $3}'` "${i}"
done

for i in $(find /dump -type l -gid 200); do
  chgrp -h `ls -lnd "${i}" | awk '{print $3}'` "${i}"
done

IFS=$SAVEIFS

Yours looks like:
Code:
#!/bin/sh

find /dump -type f -gid 200 |
while read i; do
  chgrp `ls -ln "${i}" | awk '{print $3}'` "${i}"
done

find /dump -type d -gid 200 |
while read i; do
  chgrp `ls -lnd "${i}" | awk '{print $3}'` "${i}"
done

find /dump -type l -gid 200 |
while read i; do
  chgrp -h `ls -lnd "${i}" | awk '{print $3}'` "${i}"
done

# 4  
Old 03-16-2013
Quote:
Originally Posted by venmx
And due to the nature of the find command, I had to expand it into 3 parts ... <snip> ...
Code:
#!/bin/sh

find /dump -type f -gid 200 |
while read i; do
  chgrp `ls -ln "${i}" | awk '{print $3}'` "${i}"
done

find /dump -type d -gid 200 |
while read i; do
  chgrp `ls -lnd "${i}" | awk '{print $3}'` "${i}"
done

find /dump -type l -gid 200 |
while read i; do
  chgrp -h `ls -lnd "${i}" | awk '{print $3}'` "${i}"
done

There's no reason to resort to three different traversals of /dump. Regular files, directories, and softlinks can be visited and modified simultaneously:
Code:
find /dump -gid 200 \( -type f -o -type d -o -type l \) |
while read i; do
  chgrp -h `ls -lnd "${i}" | awk '{print $3}'` "${i}"
done

If you only need to support GNU tools (I'm making the assumption that you're using GNU find), a simpler, more efficient solution presents itself:
Code:
find /dump -gid 200 \( -type f -o -type d -o -type l \) -printf '%U:%p\n' |
while IFS=: read -r uid fname; do
  chgrp -h "$uid" "$i"
done

Regards,
Alister
# 5  
Old 03-17-2013
Quote:
If you only need to support GNU tools (I'm making the assumption that you're using GNU find), a simpler, more efficient solution presents itself:
Thanks alister! I'm learning something every day Smilie

So, your doing away with awk by using -printf option to format the output of find, then using read to set the variables that can be used by chgrp. Very nice.

But can you believe people actually have file/directory names of Windows paths?! And URL's and even ones with line breaks built-in! Special characters and spaces galore... amazing!

In the end, I had to set/reset the IFS variable and multiple sed substitution to bring most of them in line. But not all! I'm bored of it now, so I'll send the few offending names to their respective users to fix themselves.

Code:
#!/bin/sh

SAVEIFS=$IFS
IFS=$(echo -en "\n\b")

find /home -gid 200 \( -type f -o -type d -o -type l \) | sed -e 's/\\/\\\\/g;s/:/\\:/g;s/ /\\ /g;s/\n//g' |
while read i; do
  chgrp -vh `ls -lnd "${i}" | awk '{print $3}'` "${i}"
#  ls -lnd "${i}"
done

IFS=$SAVEIFS

Messy Smilie
# 6  
Old 03-17-2013
Quote:
Originally Posted by venmx
But can you believe people actually have file/directory names of Windows paths?! And URL's and even ones with line breaks built-in! Special characters and spaces galore... amazing!

In the end, I had to set/reset the IFS variable and multiple sed substitution to bring most of them in line. But not all! I'm bored of it now, so I'll send the few offending names to their respective users to fix themselves.

Code:
#!/bin/sh

SAVEIFS=$IFS
IFS=$(echo -en "\n\b")

find /home -gid 200 \( -type f -o -type d -o -type l \) | sed -e 's/\\/\\\\/g;s/:/\\:/g;s/ /\\ /g;s/\n//g' |
while IFS= read -r i; do
  chgrp -vh `ls -lnd "${i}" | awk '{print $3}'` "${i}"
#  ls -lnd "${i}"
done

IFS=$SAVEIFS

Messy Smilie
Everything that you're doing with sed is utterly pointless and the IFS gymnastics only effect is to preserve leading and trailing spaces and tabs in filenames. If you remove everything that I've highlighted in bolded red and add what I've bolded in blue, the result is identical.

IFS does not affect data flowing through a pipe, so it will not have any effect on what's sent between find and sed. It can affect the result of the read command, but only when there are multiple variables being read to or when there is leading or trailing IFS whitespace. In this case, you are not using multiple variables and there is no leading IFS whitespace because \b is not whitespace and \n cannot possibly be seen during read's field splitting step because it's used as the delimiter. Since "${i}", is quoted, the resulting filename will not undergo field splitting, so, again, the value of IFS is irrelevant. Finally, the command substition (ls | awk) which is unquoted does undergo field splitting, but since the result of that pipeline is always a series of digits, the value of IFS (\b\n) will not alter the result.

With regard to sed, every single backslash inserted by sed will be immediately removed by read. With -r, you can instruct read to not treat backslashes specially.

sed's s/\n//g will never, ever match. sed strips the newline as part of reading the line (replacing it upon output). The only way that there will ever be a newline in the text that sed's working with is if you insert it or use one of the sed commands which append (neither of which occurs here).

The code I suggested in my previous post can handle any filename so long as it does not contain a newline. Spaces? No problem. Tabs? No problem. backlashes? No problem. Colons? No problem. But newlines, nope. Why not? Because find | read is consuming newlines as delimiters.

Should you need to also handle newlines in filenames, with GNU tools, the following uses the null byte as delimiter (which is an illegal character in both UNIX and Windows pathnames), so it can handle anything:
Code:
find /dump -gid 200 \( -type f -o -type d -o -type l \) -printf '%U\0%p\0' | xargs -0n2 chgrp -vh


Last edited by alister; 03-17-2013 at 12:51 PM..
This User Gave Thanks to alister For This Post:
# 7  
Old 03-17-2013
Very profound, thanks for detailed explanation. I'll need to digest this with frantic Googling for further reading; think I need more rigorous understanding of what I'm doing!
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Dealing with filename spaces in Perl

The following command to replace text in place in multiple files in a directory is tripping up on filename spaces (Windows environment). I really don't know Perl. find '\\server\directory' | xargs perl -pi -e 's/textA/textB/g'Mike (2 Replies)
Discussion started by: Michael Stora
2 Replies

2. Shell Programming and Scripting

Bash - read white spaces

Hello! I have one problem with my bash script - I would like to be able to read white space characters from stdin (for example single " ") - can I acomplish that somehow? I need to read only one character at the time, so I use read -s -n 1 var but it doesn't work for whitespaces apparently. ... (3 Replies)
Discussion started by: xqwzts
3 Replies

3. Shell Programming and Scripting

Leading white spaces

Hi, I am having problem in deleting the leading spaces:- cat x.csv baseball,NULL,8798765,Most played baseball,NULL,8928192,Most played baseball,NULL,5678945,Most played cricket,NOTNULL,125782,Usually played cricket,NOTNULL,678921,Usually played $ nawk 'BEGIN{FS=","}!a... (2 Replies)
Discussion started by: scripter12
2 Replies

4. Shell Programming and Scripting

Dealing with files with spaces in the name

Hello, I'm a computer science major and I'm having problems dealing with file names with spaces in them. Particularly I'm saving a file name in a variable and then using the variable in a compare function i.e. a='te xt.txt' b='file2.txt' cmp $a $b If anyone could help me with this particular... (10 Replies)
Discussion started by: jakethegreycat
10 Replies

5. Shell Programming and Scripting

white spaces in bash autocompletion

Hello dear community! I've recently written a BASH function for auto completion of options. It works like following: if a user types a command and then an argument to this command which starts with "^-" and then presses TAB, then 'user_command --help (or -h)' is invoked and possible options are... (0 Replies)
Discussion started by: sidorenko
0 Replies

6. Shell Programming and Scripting

Dealing with spaces in file names in a shell script

Hi, What's the best way to find all files under a directory - including ones with space - in order to apply a command to each of them. For instance I want get a list of files under a directory and generate a checksum for each file. Here's the csh script: #!/bin/csh set files = `find $1... (5 Replies)
Discussion started by: same1290
5 Replies

7. Shell Programming and Scripting

Two or more white spaces in string

Hi, Can anybody suggest me how to combine two strings with two or more white spaces and assign it to a variable? E.g. first=HAI second=HELLO third="$first $second" # appending strings with more than one white spaces echo $third this would print HAI HELLO Output appears... (2 Replies)
Discussion started by: harish_oty
2 Replies

8. Shell Programming and Scripting

trimming white spaces

I have a variable that calls in a string from txt file. Problem is the string comes with an abundance of white spaces trailing it. Is there any easy way to trim the tailing white spaces off at the end? Thanks in advance. (9 Replies)
Discussion started by: briskbaby
9 Replies

9. Shell Programming and Scripting

delete white spaces

hi all... i have the next question: i have a flat file with a lot of records (lines). Each record has 10 fields, which are separated by pipe (|). My problem is what sometimes, in the first record, there are white spaces (no values, nothing) in the beginning of the record, like this: ws ws... (2 Replies)
Discussion started by: DebianJ
2 Replies

10. UNIX for Dummies Questions & Answers

deleting white spaces

How would I delete white spaces in a specified file? Also, I'd like to know what command I would use to take something off a regular expression, and put it onto another. ie. . . . expression1 <take_off> . . . expression2 (put here) . . . Any help would be great, thanks! (10 Replies)
Discussion started by: cary530
10 Replies
Login or Register to Ask a Question