Efficient rewrite of code?

Login or Register to Ask a Question and Join Our Community

Efficient rewrite of code?

Tags

Login to Discuss or Reply to this Discussion in Our Community

Top Forums Shell Programming and Scripting Efficient rewrite of code?

12-30-2012

Registered User

919, 3

Join Date: Dec 2006

Last Activity: 5 March 2020, 5:37 PM EST

Posts: 919

Thanks Given: 757

Thanked 3 Times in 3 Posts

Efficient rewrite of code?

Code:

egrep -v "#" ${SERVERS} | while read shosts
                        do
                                grep -Pi "[a-z]|[A-Z]" ${LOGFILE} | egrep "${snhosts}" | egrep "NOTIFICATION:" | awk -F";" '{print $3}' | sort -n | uniq | while read CEXIST
                                do
                                        if [ "$CEXIST" = "$rcheckname" ] ; then
                                                echo "$CEXIST"
                                        fi
                                done
                        done

is there a better way to rewrite the above code? im guessing there's some awk magic out there that could work here?

SkySmart

View Public Profile for SkySmart

Find all posts by SkySmart

12-30-2012

Registered User

2,759, 420

Join Date: Jun 2006

Last Activity: 13 September 2015, 8:58 PM EDT

Posts: 2,759

Thanks Given: 44

Thanked 420 Times in 408 Posts

You need show us some samples on log file:

Code:

LOGFILE

rdcwayx

View Public Profile for rdcwayx

Find all posts by rdcwayx

12-31-2012

Registered User

919, 3

Join Date: Dec 2006

Last Activity: 5 March 2020, 5:37 PM EST

Posts: 919

Thanks Given: 757

Thanked 3 Times in 3 Posts

LOGFILE is just a file with a list of hostnames, such as

Code:

skysmart-01.net
skysmart-02.net
#skysmart-03.net
skysmart-04.net
skysmart-05.net
skysmart-06.net

SkySmart

View Public Profile for SkySmart

Find all posts by SkySmart

12-31-2012

Moderator

12,296, 3,792

Join Date: Nov 2008

Last Activity: 1 January 2021, 1:47 AM EST

Location: Amsterdam

Posts: 12,296

Thanks Given: 679

Thanked 3,792 Times in 3,282 Posts

Presumably you mean that is content of the $SERVERS file? What is in the log files and what is in variable $rcheckname?

Scrutinizer

View Public Profile for Scrutinizer

Find all posts by Scrutinizer

12-31-2012

Registered User

919, 3

Join Date: Dec 2006

Last Activity: 5 March 2020, 5:37 PM EST

Posts: 919

Thanks Given: 757

Thanked 3 Times in 3 Posts

Quote:

Originally Posted by Scrutinizer

Presumably you mean that is content of the $SERVERS file? What is in the log files and what is in variable $rcheckname?

correct. my fault.

the log file contains hundreds of lines similar to:

Code:

[1356910980] SERVICE NOTIFICATION: AppEngAlerts;skysmart-01.net;PORT_5000_CHECK;CRITICAL;notify-by-email;CRITICAL

rcheckname is the name of a check. in this case, it would be PORT_5000_CHECK.

so, the if statement verifies the checkname found matches the one on record.

Last edited by Scrutinizer; 01-01-2013 at 02:54 AM.. Reason: removed code tags

SkySmart

View Public Profile for SkySmart

Find all posts by SkySmart

01-01-2013

Registered User

15,129, 5,008

Join Date: Jul 2012

Last Activity: 4 May 2020, 4:31 PM EDT

Location: Aachen, Germany

Posts: 15,129

Thanks Given: 735

Thanked 5,008 Times in 4,483 Posts

Not sure what you want to achieve. Inferring from pieces of info spread over the posts here and there, you want to check a log file against a list of servers to see if a certain check has been performed, and then output the check's name? You can do that like this:

Code:

$ grep -f servers $LOGFILE| grep "NOTIFICATION:.*$rcheckname" > /dev/null && echo $rcheckname 
PORT_5000_CHECK

Depending on the grep version the commented out server line might not be ignored in the search. What be the contents of ${snhosts}?

Last edited by RudiC; 01-01-2013 at 12:31 PM.. Reason: made a sentence more clear (tried to...)

RudiC

View Public Profile for RudiC

Find all posts by RudiC

01-01-2013

Moderator

12,296, 3,792

Join Date: Nov 2008

Last Activity: 1 January 2021, 1:47 AM EST

Location: Amsterdam

Posts: 12,296

Thanks Given: 679

Thanked 3,792 Times in 3,282 Posts

Or in bash or ksh93:

Code:

grep -f <(sed "/#/d; s/.*/NOTIFICATION.*;&;$rcheckname/" "$SERVERS") "$LOGFILE" |
cut -d\; -f2,3 | sort -u | cut -d\; -f2

awk:

Code:

awk '
NR==FNR && !/#/{
  S[$1]
  next
} 
$2 in S && $0~pat && !O[$2]++{
  print $3
}
' pat="NOTIFICATION.*$rcheckname" "$SERVERS" FS=\; "$LOGFILE"

Last edited by Scrutinizer; 01-01-2013 at 10:41 AM..

This User Gave Thanks to Scrutinizer For This Post:

Scrutinizer

View Public Profile for Scrutinizer

Find all posts by Scrutinizer

Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Linux

Rewrite proxypass

Hi, I have a Apache 2.0 web server. When a users comes in to sitea.com a check is applied if the path ends with *t*, the user hits a rewrite rule that adds an environment variable called x is hit with a proxypass. This has worked successfully in the past, but recently I added another rewrite...

2. Shell Programming and Scripting

Efficient shell script code

Hi all, I am working on an extremely large collection of text data (about 2 million XML files) in a directory. I have changed the extension from .xml to .dat. Right now I am using this code to remove the XML tags, but the code is way too slow. It seems that it is taking fore-ever: #ls -1 *.dat...

3. UNIX for Advanced & Expert Users

Sendmail Rewrite Ruleset

Hi all, I like to write a rule which do the following: INPUT ADDRESS REWRITTEN TO ----------------------------- ----------------------------- foo.bar@sub.domain.com bar@domain.com foo@othersub.domain.com ...

4. Programming

Help with make this Fortran code more efficient (in HPC manner)

Hi there, I had run into some fortran code to modify. Obviously, it was written without thinking of high performance computing and not parallelized... Now I would like to make the code "on track" and parallel. After a whole afternoon thinking, I still cannot find where to start. Can any one...

5. Web Development

Need help with rewrite rule

Hi, I hosted my site on Apache web server. I wanted to redirect all the users request to a HTML page(maintenance page). I used the below rewrite rule to do ths same. RewriteEngine on RewriteRule .* /maintenance.html The maintenance.html page contains an image. When ever I try to...

6. Programming

Making FORTRAN code more efficient

Hi, I have a very large, very old FORTRAN code that I work with. The code is quite messy and I was wondering if I can speed up execution time by finding subroutines that code execution spends the most time in. Is there any kind of software I can use to see where the code spends most of the...

7. UNIX for Dummies Questions & Answers

rewrite date

I'm looking to have function that takes the present month and rewrites it into this form: _06_ (june), _09_ (september), and so on.. I would like this to be a my $this_month=code that rewrites date function because I would like to be a able to call it multiple times in the script by writing...

8. Shell Programming and Scripting

grep help, how do i rewrite this

Thanks , franklin you method worked, i knew i had to use a while loop and getline in there just didnt know the proper order :) Hi everyone, im trying to make the following command line shorter by introducing a script that join up all the grep commands ./new1a < numbers.txt | grep -i -v '^a '...

9. Shell Programming and Scripting

How do I rewrite to use a while instead of find?

for FILE in `find /home/Upload/*` Need to use a while instead to prevent errors when the file is emptied

10. UNIX for Advanced & Expert Users

Apache Rewrite help!

I am trying to write RewriteRule on Apache_1.3.26 to get users web page from another server. for example if users tries to get web page on www.somedomain.com/~usersname it will get the web page from www.testdomain.com/~username without redirect and users will not be aware of any redirect...

Login or Register to Ask a Question