For Loop in shellscript - Printing Output for every iteration


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting For Loop in shellscript - Printing Output for every iteration
# 1  
Old 12-07-2012
For Loop in shellscript - Printing Output for every iteration

Code:
for VGLIST in `lsvg -o`
do 
CLOSED_OUT=`echo $VGLIST | lsvg -l $VGLIST | awk '{print $6 "  " $7}' | grep closed`
if [[ $? = 0 ]]; then
    echo "Filesystems $CLOSED_OUT in VG that are in Closed status"
else
    echo "\n Some message"
fi

Above Code is working fine, but
Code:
echo "Filesystems $CLOSED_OUT in VG that are in Closed status"

is being printed for every iteration. I just want to print one line output for each filesystem that is closed in a particular volume group.
# 2  
Old 12-07-2012
I never used $? to test a grep in a `subshell`. Does it return the grep $? in both ksh and bash? I would test 'if [ "$CLOSED_OUT" != "" ]' and put $VGLIST in the message. VGLIST seems a strange name for a list item.
This User Gave Thanks to DGPickett For This Post:
# 3  
Old 12-07-2012
does lsvg actually read from stdin? This code looks needlessly convoluted...
This User Gave Thanks to Corona688 For This Post:
# 4  
Old 12-07-2012
When I tested command line , $? returned 1 for the grep output while finding the closed file systems.
My requirement for this script is to find closed/syncd filesystems as non root user in all the volume groups OS being AIX 6.1. Please share your ideas so that I can follow along. Thank you.
# 5  
Old 12-07-2012
Well, $? has a short shelf life, as everything under the sun sets it, so what works on a command line does not work on slightly more complex command line. It is commonly used something like:
Code:
some_command with_args_and_redirect
ret=$?
if [ $ret = 0 ]
then
 some action
fi

I like the pipes and all shell:
Code:
lsvg -o | while read VG
do
 lsvg -l $VG | while read x1 x2 x3 x4 x5 x6 x7 x8
 do
  case "$x7" in
  (closed)
     echo $VG $x6 Closed
    ;;
  (*)
     echo $VG $x6 OK
    ;;
  esac
 done
done

This User Gave Thanks to DGPickett For This Post:
# 6  
Old 12-07-2012
Thank you DGPickett. This post is really helpful. I will have my code embedded to the example. This thread can now be closed.
# 7  
Old 12-08-2012
Quote:
Originally Posted by DGPickett
Well, $? has a short shelf life, as everything under the sun sets it, so what works on a command line does not work on slightly more complex command line. It is commonly used something like:
Code:
some_command with_args_and_redirect
[...]
[snip]

Only because I can't sleep...


Code:
lsvg -o | while read VG
do
 lsvg -l $VG | while read -a x  
 do
  case "${x[6]}" in
  (closed)
     echo $VG ${x[5]} Closed
    ;;
  (*)
     echo $VG ${x[5]} OK
    ;;
  esac
 done
done

This User Gave Thanks to DeCoTwc For This Post:
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Printing the output of sed using a loop

So I am writing a bash script that will search a file line by line for unix timestamps, store all of the timestamps into an array, then check how many of those timestamps were created within the last hour, and finally increment a counter every time it finds a timestamp created within the last hour.... (6 Replies)
Discussion started by: jsikarin
6 Replies

2. Shell Programming and Scripting

While loop is running only for the first iteration

Hello, I've written a script to automate encoding of all the MP4 files in a directory (incl. subdirectories). But unfortunately it's running for the first MP4 file only. My machine details: root@Ubuntu16:~# uname -a Linux Ubuntu16 4.10.0-28-generic #32~16.04.2-Ubuntu SMP Thu Jul 20 10:19:48... (2 Replies)
Discussion started by: prvnrk
2 Replies

3. Shell Programming and Scripting

Loop iteration with two variables

Hello, I have been stuck on this for some time and invested many hours trying to find a solution. I am trying to either loop through two variables or or two arrays and not sure how to do it. I am limited to ksh only, and don't have the ability to do a foreach, or for i AND for j etc...I... (19 Replies)
Discussion started by: Decoy Octopus88
19 Replies

4. Shell Programming and Scripting

While loop is causing ssh command to exit from script after first iteration.

I am trying to check multiple server's "uptime" in a loop over "ssh". When I execute multiple ssh commands with hard coded servernames script is executing fine. But when I pass server names using while loop, script is exiting after checking first server's status, why? # serverList... (8 Replies)
Discussion started by: kchinnam
8 Replies

5. Shell Programming and Scripting

Getting the iteration count in WHILE LOOP

bash in RHEL 6.4 I have a requirement in which I want to get the iteration count from a WHILE LOOP. The below mentioned simple script test.sh works fine. In the below script, the WHILE loop will iterate every 5 seconds infinitely until it greps the string BASKETBALL from /tmp/somestring.txt... (6 Replies)
Discussion started by: John K
6 Replies

6. Shell Programming and Scripting

Do something only that last iteration of loop

I have a script with logic like: my_function() { if mkdir $1 mkdir mydir_${2} else do something else fi } read in list of items while read list do my_function $list `date` done so basically it will make a directory for every name in the list and create a directory with the... (6 Replies)
Discussion started by: glev2005
6 Replies

7. Shell Programming and Scripting

for loop iteration and shell programming startup

question :how can i iterate to next item in for loop with the loop e.g for i in `cat abc.txt` do echo $i // this will display first line i=$i+1; // this doesnt work for me. echo $i; //this will display secound line done question: is my approach to manipulate text good? I have... (3 Replies)
Discussion started by: kashif_islam
3 Replies

8. Shell Programming and Scripting

howto stop loop iteration

I wonder how to stop further loop iterations when conditions gets false e.g. This file.txt contains the following structure : 1 2 3 4 5 6 7 8 9 10 How to stop iteration when if statement gets false ? for n in `cat file.txt` do if (( n<=5 )) (1 Reply)
Discussion started by: presul
1 Replies

9. Shell Programming and Scripting

Pick up the return code for every iteration and display the result only once in loop.

Hi All, I amlearning UNIX scripting. I have a small query. I would be thankful if any one helps me out. I have a below piece of code which delets the files. If file dosent have the permissions to delete a particular file I have used 2>>operator to track the error code. But my objective is... (1 Reply)
Discussion started by: manas6
1 Replies

10. Shell Programming and Scripting

New iteration of for-loop without incrementing?

Another question, is it possible to, in a for-loop incrementing until it reaches a certain number, to have it loop again without incrementing? Just have it drop what it is doing when it reaches this command and start again at the same number it was at? I know I could make a while loop and just... (0 Replies)
Discussion started by: jeriryan87
0 Replies
Login or Register to Ask a Question