Passing parameters to bash script function (or subroutine)


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Passing parameters to bash script function (or subroutine)
# 1  
Old 02-18-2012
Passing parameters to bash script function (or subroutine)

I've found a few posts regarding passing parameters to a function or subroutine, but for some reason when I try to run a command based on part with these parameters it's not working. If I have the function echo the parameters they show correctly so I believe they are being passed right but the command fails when it runs.

Code:
#!/bin/bash

function waitforvmtools {
# this line works
  /usr/bin/vmware-cmd -H lab-esxi1 -U root -P 'pass!word' '[NFS2] lab-vcenter/lab-vcenter.vmx' gettoolslastactive
# this line should be the same but does not work
  /usr/bin/vmware-cmd -H $1 -U root -P 'pass!word' $2 gettoolslastactive
# but this shows the proper parameters being passed
echo /usr/bin/vmware-cmd -H $1 -U root -P 'pass!word' $2 gettoolslastactive

# this is what I'm ultimately trying to do with it
#  toolstate=`/usr/bin/vmware-cmd -H $1 -U root -P 'pass!word' $2 gettoolslastactive`
#  until [  "$toolstate" = "gettoolslastactive() = 1" ]; do
#    sleep 5
#    toolstate=`/usr/bin/vmware-cmd -H $1 -U root -P 'pass!word' $2 gettoolslastactive`
#    echo $toolstate
#  done
}

waitforvmtools lab-esxi1 "'[NFS2] lab-vcenter/lab-vcenter.vmx'"

Thanks for any suggestions!

h
# 2  
Old 02-18-2012
Try quoting your variables:

Code:
/usr/bin/vmware-cmd -H "$1" -U root -P 'pass!word' "$2" gettoolslastactive

And on your call, I think you can drop the single quotes:
Code:
waitforvmtools lab-esxi1 "[NFS2] lab-vcenter/lab-vcenter.vmx"

If that doesn't work, try putting a set -x before the call to see exactly what/how the command is being expanded.
This User Gave Thanks to agama For This Post:
# 3  
Old 02-18-2012
Thank you agama, it was both that needed to be done. I wrapped the variables in quotes (it was really only the $2 that needed to be wrapped) and take the single quotes off the call.

I appreciate your help on this!

Thanks again!

h

Final code:
Code:
#!/bin/bash

function waitforvmtools {
  toolstate=`/usr/bin/vmware-cmd -H $1 -U root -P 'pass!word' "$2" gettoolslastactive`
  until [  "$toolstate" = "gettoolslastactive() = 1" ]; do
    sleep 5
    toolstate=`/usr/bin/vmware-cmd -H $1 -U root -P 'pass!word' "$2" gettoolslastactive`
  done
}

waitforvmtools lab-esxi1 "[NFS2] lab-vcenter/lab-vcenter.vmx"


Last edited by withanh; 02-18-2012 at 07:06 PM.. Reason: added final script version
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Passing command line parameters into script

Not a good post. (1 Reply)
Discussion started by: bash_in_my_head
1 Replies

2. Shell Programming and Scripting

Why double quotation marks doesn't work in ksh function parameters passing?

I'm working on AIX 6, ksh shell. The parameters are some strings quotated by double quotation marks which from a file. They are quotated because there may be spaces in them. Example: "015607" "10" " " "A"I want to pass these parameters to a shell function by writing the following command: ... (4 Replies)
Discussion started by: Shimmey
4 Replies

3. Shell Programming and Scripting

passing parameters to the script

how can i make a script to run only when parameters are given, if parameters are not given it should through an error , saying "please enter a parameter" for ex: i want a find command to run only when the parameters are given (4 Replies)
Discussion started by: knip
4 Replies

4. Shell Programming and Scripting

Passing the parameters using a function

Hi All, I am new to shell scripting required some help in passing the parameter value to the shell script. I am writing a shell script, in the script I have created two functions as below. first function get_trend_ids () { Here I am connecting to the database and getting all the... (3 Replies)
Discussion started by: shruthidwh
3 Replies

5. Shell Programming and Scripting

bash script function parameters

I have a question about bash script. Can I create a function there that accept parameters like functions in program language? (2 Replies)
Discussion started by: programAngel
2 Replies

6. Shell Programming and Scripting

[bash] passing array to function

Hi, I'm trying to write a function that reassigns an array to another local array but the method used in reassigning the array reformats the contents of the array which is what I am trying to prevent. The method used to load a file into an array works as expected and the entire array is... (4 Replies)
Discussion started by: ASGR
4 Replies

7. Shell Programming and Scripting

[BASH - KSH] Passing array to a function

Passing a array to a function, a basic feature in modern language, seems to be only possible in KSH. Not in BASH. Depite all my efforts I couldn't come to a solution. See the following examples: It works perfectly in KSH: #!/usr/bin/ksh function print_array { # assign array by indirect... (3 Replies)
Discussion started by: ripat
3 Replies

8. Shell Programming and Scripting

Random parameters passing in FTP script

Hi I have a question. In the FTP script if we are passing all the required value like Hostname, username, password, Action(put or get), Filename, & mode(ascii or binary) through parameters then we have to pass these in the exact orders in which they are taken like if we defined Username=$2... (2 Replies)
Discussion started by: sourabhshakya
2 Replies

9. Shell Programming and Scripting

passing parameters from a shell script to sqlplus

Hi , I want to pass parameters from a shell script to a sql script and use the parameter in the sql query ..and then I want to spool a particular select query on to my unix box... for 4 different locations by writing only one sql script Right now no file is generated on the unix box...it is a... (2 Replies)
Discussion started by: phani
2 Replies

10. UNIX for Dummies Questions & Answers

Passing parameters in script

I have 2 scripts: script1 and script2 Script1 passes 4 parameters to script2 as follows #script1 code ... ... script2 $var1 $var2 $var3 $var4 Script2 uses the export command to know to expect these values #script2 export $1 $2 $3 $4 code ... ... The problem that I am having is... (1 Reply)
Discussion started by: eliguy
1 Replies
Login or Register to Ask a Question