Multiple while statements?


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Multiple while statements?
# 1  
Old 11-23-2011
Question Multiple while statements?

I'm working on a script for class as a final project. We have to ask for values (city, state, zip) five times, but the state can only be MI, IN, IL, or OH. I'm trying to do this with a while loop inside of a while loop, but I have no idea how to do it properly.

Here's what I have so far:

Code:
COUNT=0
while [ "$COUNT" -lt "5" ]; do
  clear
  echo "Enter City: "; read CITY
  echo "Enter State: "; read STATE
        while [[ "$STATE" != "MI" && "$STATE" != "IN" && "$STATE" != "IL" && "$STATE" != "OH" ]]; do
          echo "Sorry, that's not an accepted state."; read STATE
        done
  echo "Enter Zip: "; read ZIP
COUNT="$COUNT"+1
done
sleep 5

I have a feeling I'm way off... and I have no idea how to fix it.

Help is appreciated!

Last edited by nickzourdos; 11-23-2011 at 11:36 PM..
# 2  
Old 11-24-2011
Actually, you are pretty close. Inside the while that validates the state, just prompt for the state again.
# 3  
Old 11-24-2011
Fixed it!

My syntax for the while loop that checked STATE was bad. In bash, you have to use -a instead of &&:

Code:
while [ "$STATE" != "MI" -a "$STATE" != "OH" -a "$STATE" != "IL" -a "$STATE" != "IN" ];do
   echo "Sorry, that's not an accepted state."
   echo "Enter State: "; read STATE
done

And for some reason, my bash won't recognize the let command... so I have to use expr instead for a counter:

Code:
COUNT=0
while [ "$COUNT" -le "5" ]; do
  echo "Count is less than 5."
  COUNT=`expr $COUNT + 1`
done

The wonders of a good night's sleep.....

Last edited by nickzourdos; 11-24-2011 at 02:03 PM..
# 4  
Old 11-24-2011
Quote:
Originally Posted by nickzourdos
My syntax for the while loop that checked STATE was bad. In bash, you have to use -a instead of &&:

Actually, using && within double square brackets is correct. The single open square bracket (actually the test command) does not support double ampers and as you have noticed it does need -a. This is a test command syntax requirement, not bash; most people don't realise that the [ is a command and not a shell built-in.


Using test (or [) is less efficient than using the shell (bash or Kshell) built-in [[. There are times where using test makes sense, but for most scripts I believe that the built-in is best.



I just had a look at your original script and didn't notice that you were issuing the read before your echo "try again." Other than that, it works for me.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Using multiple 'for' statements

Hello, I am new to scripting and I am trying to write a simple script that creates users and adds their passwords from two files; one a user list file and another a password list file. For example, I have two files already. $ cat file1 andy stephane aby paul $ cat file2 123 234... (4 Replies)
Discussion started by: FemoTheDon
4 Replies

2. UNIX for Dummies Questions & Answers

Multiple if statements

exmaple: file1 and file2 has 1 bit if then exit else send out email fi if then exit else send out email fi it exits the 1st if. did not continue with my 2nd if. thanks in advanced. Please use CODE tags are suggested on every page when you post an item in... (7 Replies)
Discussion started by: lawsongeek
7 Replies

3. Shell Programming and Scripting

Multiple If statements in bash problem

Hi everyone, May you help me with the correct syntax of the follow bash statements please X=10 if ]; then echo "The value is between 1 and 5" for ((i=1;i<=${X})); do echo $i done else if ]; then echo "The value is between 6 and 10" for ((i=1;i<=${X})); do ... (5 Replies)
Discussion started by: Ophiuchus
5 Replies

4. Shell Programming and Scripting

Multiple if Statements

Hi All, I need to check for 3 conditions and if all the 3 are not satified need to say that services are not running.... is the below code correct. #********** Check to see if Service 1 is still running************** if then echo "$datetimestamp: Service1 is not running" >>... (4 Replies)
Discussion started by: ch33ry
4 Replies

5. Shell Programming and Scripting

multiple echo statements in if condition

Hi , I have a peculiar problem. i have an if block like this if ; then echo " todays date is " ${date} >> log_file echo " file count is " $ count >> log_file mv filename1 filename 2 else echo "no files available ">> log_file fi the echo statement "no files available " is not... (2 Replies)
Discussion started by: wizardofoz
2 Replies

6. Shell Programming and Scripting

execute multiple statements in if-else

how can we execute multiple statements in else condition i have if then statement else statements fi in else condition i have multiple statements but it executing only one statement is there any way to execute multiple statements (4 Replies)
Discussion started by: nani1984
4 Replies

7. Shell Programming and Scripting

Running multiple if statements

Hi, Hav automated a process, and it is working fine. for first process alone status = ` ps -ef |grep a ` if then echo " Success" > temp/logfile else echo " Failure" > temp/logfile fi Now I hav to write script to automated some 2 process and then send mail using cron.. ... (5 Replies)
Discussion started by: NehaKrish
5 Replies

8. Shell Programming and Scripting

How do I execute multiple statements within If then else

Please help me. I have been doing this for several hours. Here is the code if then echo a b c d >> file.txt echo 1111 >> file.txt fi The reason I want the two echo is because I want these statements printed on multiple lines. I keep getting error . First it tells me... (2 Replies)
Discussion started by: asemota
2 Replies

9. Shell Programming and Scripting

multiple 'if' statements out of array

I want to do multiple comparisons on a series of numbers from an array: I send the numbers in file1 through want to print out some info from file2 based on some conditions. The syntax just isn't correct??? awk ' NR==FNR{ a=$0 next ... (2 Replies)
Discussion started by: dcfargo
2 Replies

10. Shell Programming and Scripting

multiple conditions in if statements

Hi all, I'm confused about the proper syntax for multi-conditional if then statements. I'm trying to set limitations on info input on the command line.. i.e. if ] ;then $x=$vr1 else print "You have entered an invalid option." Can someone please clue me in on what is wrong with my syntax;... (3 Replies)
Discussion started by: tim mauger
3 Replies
Login or Register to Ask a Question

Featured Tech Videos