Shell script [Generalizing]


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Shell script [Generalizing]
# 1  
Old 08-30-2011
Shell script [Generalizing]

Code:
#!/bin/bash
if grep "$1" "$3" > /dev/null; then
mv $3 $3.bak
sed "s/$1/$2/g" $3.bak > $3
fi

Hello there, I am trying to edit this code so that it will produce a shell script called "subst" that will apply a substitution to any number of files given on the command line.
Code:
For example, putting in 
~/text/subst happy cow myFile1.txt myFile2.txt myFile3.txt

would substitute in all three files.

When I try to execute it says,

Code:
Checking subst...
/home/jzhang/UnixCourse/scriptAsst/subst is not executable.

Seeing this, I figured well, I do chmod +x subst, but that didn't work either because the file doesn't exist yet...not sure what to do now.

Last edited by pludi; 08-30-2011 at 07:00 PM..
# 2  
Old 08-30-2011
Quote:
Originally Posted by jzhang172
Hello there, I am trying to edit this code so that it will produce a shell script called "subst" that will apply a substitution to any number of files given on the command line.
That seems rather the long way around. Why not just write a script that does that in the first place?

Think I remember giving you an example for one, too.

[edit] yes, I did.
Code:
if [ "$#" -lt 3 ]
then
        echo "usage:  a b file1 file2 ..."
        exit
fi

A="$1"
shift
B="$1"
shift
while [ "$#" -gt 0 ]
do
        echo "substitute $A for $B in $1"
        shift
done

You complained you didn't know how to do a while loop yet, but it's easier than building rube-goldbergian script-generator generator.

How a while loop works is simple:
Code:
while [ condition ]
do
        something
done

where [ condition ] is a statement exactly like you'd cram in an if. As soon as the statement becomes false, it stops repeating the code between do and done. My condition, [ "$#" -gt 0 ] , is true whenever there's one or more arguments left (a number that decreases by one every time you shift).

How shift works is also simple. Say you have $1=string, $2=replacement, $3=file1, $4=file2. After a shift, you have $1=replacement, $2=file1, $3=file2. So I just save string and replacement for later, get rid of the original $1 and $2, then loop through all the remaining filenames...

Last edited by Corona688; 08-30-2011 at 07:20 PM..
# 3  
Old 08-30-2011
Quote:
Originally Posted by jzhang172
Code:
#!/bin/bash
if grep "$1" "$3" > /dev/null; then
mv $3 $3.bak
sed "s/$1/$2/g" $3.bak > $3
fi

can be done using :
Code:
#!/bin/bash
array=( "${@}" )
if [ ${#array} -lt 3 ];then
        echo "Usage:  $0 a b file1 file2 ..."
else
        for (( i=1 ; ++i<${#array}; ));do
                grep  ${array[0]} ${array[i]} > /dev/null && sed -i.bak "s/${array[0]}/${array[1]}/g"  ${array[i]}
        done
fi


Last edited by danmero; 08-30-2011 at 11:24 PM.. Reason: Provide the full script not only sed solution
# 4  
Old 08-31-2011
Ok thanks for the reply! Smilie

For Corona:
It's part of the book assignment so I have to do what it says, I don't have a choice haha. So unfortunately, your code doesn't work Smilie.

Danmero:
Code doesn't work unfortunately.

Here is what the book says:
Create a new script, subst2, taking the parameters: the string to be replacedthe string with which to replace itthe name of the file in which to make the substitution, that performs the substitution and backup file creation when the target string occurs somewhere in the file, but leaves the file completely unchanged (and does not create the .bak file) if the string being replaced is nowhere in the file.

Generalize your subst2 script, producing a new script subst that will apply a substitution to any number of files given on the command line. For example ~/UnixCourse/scriptAsst/subst foo bar myFile1.txt myFile2.txt myFile3.txt should apply the same substitution throughout each of the three files named there.
# 5  
Old 08-31-2011
Quote:
Originally Posted by jzhang172
Danmero:
Code doesn't work unfortunately.
doesn't work is not very useful to solve your problem, try to post any/all errors returned by your script.

Take a look at the following script:
Code:
#!/bin/bash

array=( "${@}" )
if [ ${#array} -lt 3 ];then
        echo "Usage:  $0 a b file1 file2 ..."
else
        for (( i=1 ; ++i<${#array}; ));do
                grep  ${array[0]} ${array[i]} > /dev/null &&\
                echo "ON FILE  ${array[i]} SUBSTITUTE ${array[0]} FOR ${array[1]} AND BACKUP FILE ${array[i]} TO ${array[i]}.bak" ||\
                echo FILE ${array[i]} UNCHANGED.
                # grep  ${array[0]} ${array[i]} > /dev/null && sed -i.bak "s/${array[0]}/${array[1]}/g"  ${array[i]}
        done
fi

Running this script give me the following output:
Code:
/temp/script happy cow myFile1.txt myFile2.txt myFile3.txt
ON FILE  myFile1.txt SUBSTITUTE happy FOR cow AND BACKUP FILE myFile1.txt TO myFile1.txt.bak
FILE myFile2.txt UNCHANGED.
FILE myFile3.txt UNCHANGED.

Where only file myFile1.txt match the pattern.

---------- Post updated at 08:09 AM ---------- Previous update was at 08:04 AM ----------

Quote:
Originally Posted by jzhang172
For Corona:
It's part of the book assignment so I have to do what it says, I don't have a choice haha.
Please read the Forum Rules regarding the homework's and assignments.
# 6  
Old 08-31-2011
Quote:
Originally Posted by jzhang172
Ok thanks for the reply! Smilie

For Corona:
It's part of the book assignment so I have to do what it says, I don't have a choice haha. So unfortunately, your code doesn't work Smilie
Throw out the book, get one where you're allowed to use loops in a sane way.

Unless this is homework, in which case you're in the wrong subforum. There's special rules for homework.
# 7  
Old 08-31-2011
Oh, sorry, correction, I think there was alot of confusion about what I was looking for: I am just trying to edit this code:

#!/bin/bash if grep "$1" "$3" > /dev/null; then mv $3 $3.bak sed "s/$1/$2/g" $3.bak > $3 fi
So that it will take in any amount of files and make the substitution.

Corona, i was trying to use your code:
if [ "$#" -lt 3 ] then echo "usage: a b file1 file2 ..." exit fi A="$1" shift B="$1" shift while [ "$#" -gt 0 ] do echo "substitute $A for $B in $1" shift done

I used this code, and it outputted this when I did this: ~/test/subst happy dog happy.txt sad.txt neutral.txt

PHP Code:
substitute happy for dog in happy.txt
substitute happy 
for dog in neutral.txt
substitute happy 
for dog in sad.txt 
When I checked the file, nothing happened to the files.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Shell script newbie- how to generate service log from shell script

Hi, I am totally a newbie to any programming languages and I just started an entry level job in an IT company. One of my recent tasks is to create a script that is able to show the log file of linux service (i.e. ntpd service) lets say, if I run my script ./test.sh, the output should be... (3 Replies)
Discussion started by: xiaogeji
3 Replies

2. Shell Programming and Scripting

Pass C shell array to another C shell script(csh) and shell(sh)

Dear Friends, Please help me on this my script name is send.csh In this i have written the statement like this set args = ( city state country price ) I want to pass this array to another c shell called receiver.csh. and i want to use it in this c shell or how to pass to... (2 Replies)
Discussion started by: SA_Palani
2 Replies

3. Shell Programming and Scripting

How to write config shell script to pass variables in master shell script?

Dear Unix gurus, We have a config shell script file which has 30 variables which needs to be passed to master unix shell script that invokes oracle database sessions. So those 30 variables need to go through the database sessions (They are inputs) via a shell script. one of the variable name... (1 Reply)
Discussion started by: dba1981
1 Replies

4. UNIX for Dummies Questions & Answers

How to write Config shell script to pass variables in master shell script?

Dear Unix gurus, We have a config shell script file which has 30 variables which needs to be passed to master unix shell script that invokes oracle database sessions. So those 30 variables need to go through the database sessions (They are inputs) via a shell script. one of the variable name... (1 Reply)
Discussion started by: dba1981
1 Replies

5. Shell Programming and Scripting

Unable to pass shell script variable to awk command in same shell script

I have a shell script (.sh) and I want to pass a parameter value to the awk command but I am getting exception, please assist. diff=$1$2.diff id=$2 new=new_$diff echo "My id is $1" echo "I want to sync for user account $id" ##awk command I am using is as below cat $diff | awk... (2 Replies)
Discussion started by: Ashunayak
2 Replies

6. Shell Programming and Scripting

Correct shell script to Call One shell script from another shell script

Hi All, I have new for shell scripting. Problem : I have one scrip at serv1 and path of server is /apps/dev/provimage/scripts and script name:extract_ancillary.bat. I need to call this script at server2(my working server) and execute at server2 . Please let me know how to build the... (5 Replies)
Discussion started by: Vineeta Nigam
5 Replies

7. Shell Programming and Scripting

call another shell script and pass parameters to that shell script

Hi, I basically have 2 shell scripts. One is a shell script will get the variable value from the user. The variable is nothing but the IP of the remote system. Another shell script is a script that does the job of connecting to the remote system using ssh. This uses a expect utility in turn. ... (2 Replies)
Discussion started by: sunrexstar
2 Replies

8. Shell Programming and Scripting

How to use ssh execute other shell script on other host (shell script include nohup)?

i want use ssh on the host01 to execute autoexec.sh on the host02 like following : host01> ssh host02 autoexec.sh autoexec.sh include nohup command like follwing : nohup /home/jack/deletedata.sh & after i execute ssh host02 autoexec.sh one the host01. i can't found deletedata.sh... (1 Reply)
Discussion started by: orablue
1 Replies

9. Shell Programming and Scripting

invoking a shell script inside cgi shell script

Hi, I have an HTML form through which I get some text as input. i need to run a shell script say script.sh inside a perl-cgi script named main_cgi.sh on the form input. I want to write the contents of the form in a file and then perform some command line operations like grep, cat on the text... (2 Replies)
Discussion started by: smriti_shridhar
2 Replies

10. Shell Programming and Scripting

How to Run a shell script from Perl script in Parent shell?

Hi Perl/UNIX experts, I have a problem in running a shell script from my perl script (auto.pl). I run the perl script using perl auto.pl from the shell prompt The shell script picks the files in "input" folder and procesess it. The shell script blue.sh has this code. export... (16 Replies)
Discussion started by: hifake
16 Replies
Login or Register to Ask a Question