Shell Programming and Scripting

Hi,
I am new to unix, trying to learn things
I have written unix script to stop Informatica server and re-start them.
In order to stop the servers i need to check the below
1. Check if the infa servers are already running.
2. If the servers are already running then, i need to stop the servers.
3. If the servers are not running then exit.
4. Once the servers are stopped, check if the they stopped successfull.
5. If not forcefull shutdown the servers.

Below is the script for checking the services are running or not.

Defined all the variable

Code:

#*********Check whether the Integration services is still running*************
ps -ef| grep $username | grep $INFA_INT_SERVICE | grep -vq grep
if [ $? -eq 1 ]
then
#exit 1
error_flag1=1
fi
#********** Check to see if Repository Service is still running**************
ps -ef| grep $username | grep $INFA_REPO_SERVICE | grep -vq grep
if [ $? -eq 1 ]
then
echo "$datetimestamp: $INFA_REPO_SERVICE is not running" 
error_flag2=2
fi
#***********To check whether the informatica Domain is still running**********
ps -ef| grep $username | grep $INFA_DOMAIN | grep -vq grep
if [ $? -eq 1 ]
then
error_flag3=3
fi
 
if [[ $error_flag1 -eq 1 && $error_flag2 -eq 2 && $error_flag3 -eq 3 ]]
then
echo "Informatica services are not running"
exit 1
fi

The script is working fine as excepted.
I wanted to know if it can be fine tuned. Is the error handling process is correct.

And also
when i am doing pidof DINFA_DOMAINS_FILE
its returing null.

Please suggest.

Moderator's Comments:

Please use [CODE] tags when posting source listings, console output, ...