Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

If, elif, else statements help

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting If, elif, else statements help
# 1  
Old 02-07-2011
If, elif, else statements help
I am in need of some help. I am not an advance scripter or programmer, I have novice knowledge. I cannot get a script to work as expected. The script basically does an FTP (which I have work perfectly) and writes to a log. However, I want the script to echo "Not Connected" if the FTP fails to connect (checks log and sees not connected errors) or echo "Successfully Connected" if the FTP transmits successfully (status code equals 0) or "Error" if the script fails for any other reason (any other status code except 0).

Code:
if grep "Not Connected" $LOG
then
    echo "Not Connected"

elif [ $? -eq 0 ]
then    
    echo "Successfully Connected"
    
else
    echo "Error, please review"

fi

Can anyone tell me what I'm doing wrong with the if, elif, else statements above? The script runs without error, but only the last is echoed "Error, please review" regardless if it completes successfully or not. Please help. Thanks.
# 2  
Old 02-07-2011
Every command sets $?. You are expecting $? to be the status of the last command that interests you. Immediately after the command you want do status=$? and later you can check $status. But I'm also worried that you are checking the return code of ftp. Are you sure that your version of ftp will set the return code you expect? The ftp process may think it worked correctly even if a disered file was not present.
# 3  
Old 02-07-2011
Quote:
Originally Posted by Perderabo
Every command sets $?. You are expecting $? to be the status of the last command that interests you. Immediately after the command you want do status=$? and later you can check $status. But I'm also worried that you are checking the return code of ftp. Are you sure that your version of ftp will set the return code you expect? The ftp process may think it worked correctly even if a disered file was not present.
Thanks for replying.

So basically to check the status of FTP using $? I'll need to check that immediately after FTP quits to be sure it exited properly? FYI, I am using Cygwin and the default FTP. Here is the entire code,

Code:
#!/bin/bash
FILE=SOMETHING.zip
LOG=SOMETHING.log

ftp -vin <<-ENDFTP
open ftp.SOMETHING.com
user SOMEUSER SOMEPASSWD
bin
prompt off
put $FILE 
disconnect
quit
ENDFTP

if grep "Not Connected" $LOG
then
    echo "Not Connected"

elif [ $? -eq 0 ]
then    
    echo "Successfully Connected"
    
else
    echo "Error, please review"

fi

echo $?

So how can I logically get this code working properly to check all three conditions? Thanks.

---------- Post updated at 11:25 AM ---------- Previous update was at 11:07 AM ----------

Thanks to your insight @Perderabo I got the script working as expected. I completely nix the exit status statement and replaced it with a grep in the log for "Transfer complete". Now the code is working properly. Thank you.

Here's an example of the working code,

Code:
#!/bin/bash
FILE=SOMETHING.zip
LOG=SOMETHING.log

ftp -vin <<-ENDFTP
open ftp.SOMETHING.com
user SOMEUSER SOMEPASSWD
bin
prompt off
put $FILE 
disconnect
quit
ENDFTP

if grep "Not Connected" $LOG
then
    echo "Not Connected"

elif grep "Transfer complete" $LOG
then    
    echo "Successfully Connected"
    
else
    echo "Error, please review"

fi

echo $?

Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Convert to case statements from if/elif

Hello, I wrote the case on code but it mistakes. I am not sure. If/elif code: #!/bin/ksh you=$LOGNAME hour=`date | awk '{print substr($4, 1, 2)}'` print "The time is: $(date)" if (( hour > 0 && $hour < 12 )) then print "Good morning, $you!" elif (( hour == 12 )) then (7 Replies)
Discussion started by: Masterpoker
7 Replies

2. Shell Programming and Scripting

If / elif

Hello all, I have a scenario where I take user input values and accordingly take actions say I run a script with sh scriptname -x GB -e txt (txt can also be text) I have used if clause for the first input (-x GB)and it is working fine Now for second the scenario is if then echo... (3 Replies)
Discussion started by: nnani
3 Replies

3. UNIX for Advanced & Expert Users

if else elif

Hi all,i have configured the following script to check if the file exists or not, #!/bin/sh sleep 30 { FILEFULL=$1`date +$2`* if ; then echo $FILEFULL exist else echo "$FILEFULL File not Found" | mail -s 'server' myaccount@mydomain.com fi } but i have a problem, i need to... (2 Replies)
Discussion started by: charli1
2 Replies

4. Shell Programming and Scripting

While-read and if-elif

Hi there, new to this forum and I recently encounter this problem: I tried to use if-elif loop in a while-read loop, something like this: #!/bin/bash while read myline1 myline2 do if ; then echo "Successful!" elif ; then echo "Failed" fi done < $1 Input file looks like this: 200... (13 Replies)
Discussion started by: kennethtls
13 Replies

5. Homework & Coursework Questions

if/elif help

Use and complete the template provided. The entire template must be completed. If you don't, your post may be deleted! 1. The problem statement, all variables and given/known data: This is my problem for the class. Write a script that asks for the user's age. If it is equal to or higher... (6 Replies)
Discussion started by: aggie6970
6 Replies

6. Shell Programming and Scripting

If -elif-else error.

I am getting below error from this code (which is at line 24): if ] #this is line24 in code then mv $File_source_path/$File_name $File_name'_'`date '+%d%m%y'` Error: line 24: Any help with the syntax. I am putting 2 condition with 'AND' clause. This is bash shell. (2 Replies)
Discussion started by: amit.mathur08
2 Replies

7. Shell Programming and Scripting

Query on If-Elif!!

Script Gurus, Need your help in getting this script to come out of logical error : I have pasted the script below: This script finds disk utilzation ... the script is written for both AIX and SUN OS... and option will be given in the initial to select DB or Non DB... its required for my prj...... (1 Reply)
Discussion started by: vangalli
1 Replies

8. UNIX for Dummies Questions & Answers

Help with ELIF statement

I am receiving an elif error on line 13 and I can not figure out the reasoning behind it. I have added the then statement that I was initially missing. Any help would be great. #The purpose of this script is for the end user to be able to enter a positive number #User enters a number NUM=$1... (4 Replies)
Discussion started by: Brewer27
4 Replies

9. Shell Programming and Scripting

If..elif..else...fi

Hi all, I got some problems on executing the following scripts. Scripts: if ]; then echo "M${str}O 0 1" >> ${tempFile} elif ]; then echo "M${str}O 1 0" >> ${tempFile} else echo "M${str}O 0 0" >> ${tempFile} fi Error: "`;' is not expected." what's the problem? (2 Replies)
Discussion started by: Rock
2 Replies

10. Shell Programming and Scripting

elif not expected

Hi, I have a shell script which runs fine when i do it from Unix simulator on Widnows. When i try to run the same for Unix it throws me the error syntax error at line 87: `elif' unexpected. Piece of code for the same is while do if ; then shift configFile="$1"... (9 Replies)
Discussion started by: pv0428
9 Replies
Login or Register to Ask a Question