help with bourne shell script


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting help with bourne shell script
# 1  
Old 08-12-2010
help with bourne shell script

Attempting to write a script to eventually notify me via email for when there is packetloss across the backbone. I am looking for values greater than 0% in the mtr field.

Code:
#!/bin/sh
target=www.google.com
date +"%D"_"%T" >> /home/rich/mtr.log
echo "----------------------------------------" >> /home/rich/mtr.log
mtr -report -c 5 $target >> /home/rich/mtr.log
mtrlog=`cat /home/rich/mtr.log | awk '/%/ { print $2 }'`
zeroloss=0%
if [ "$mtrlog" = "$zeroloss" ] ; then
        echo "No packetloss"
fi

With what I have above, it's echoing more than one 0% for the mtr field ( obiously) and comparing it to the zeroloss of 0% which results in it not echoing no packetloss. Do I need a for loop in there for each line?

Example when stripping script to just variables it comes up with:
Code:
mtrlog 0% 0% 0% 0% 0% 0% 0% 0% 0% 0% 0% 0% 0% 0% 0% 0%

zeroloss 0%


Last edited by Franklin52; 08-13-2010 at 05:10 AM.. Reason: Please use code tags.
# 2  
Old 08-12-2010
I'm not familiar with the 'mtr' command, but I'll guess that its sending out pings and presenting a summary that includes packet loss. Your getting tripped up because you are parsing the whole log file and not just the last mtr output.

I'd write the script just a bit differently; piping all of the mtr output straight to awk and letting it do all of the work.

Code:
#!/usr/bin/env sh
target=www.google.com
log=/home/rich/mtr.log
date +"%D"_"%T" >>$log

mtr -report -c 5 $target | awk -v logf=$log '
   { print >>logf; }          # save all mtr output to log file for history
   index( $2, "%" ) > 0  {  # you could do /%/ but that might catch more than youd like  /packet loss/ would be best if that is in the output
        if( max < $2+0 )     # allow for multiple in output; keep largest
             max = $2+0;     # +0 forces it to be numeric
   }
   END { 
      if( max == 0 )          # write to tty the findings of this pass
           printf( "no packet loss\n" );
      else
           printf( "packet loss of %d%%\n", max );
   }'

I'd also use Kshell or bash over sh, unless for some reason you're required to use sh. #!/usr/bin/env ksh at the top should be all you need to switch.
This User Gave Thanks to agama For This Post:
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Homework & Coursework Questions

New user needs help with bourne shell script

This is my question, below the question is the template Write and execute a Bourne shell script called homework that will From within the script, create three background processes: a) (2 points) one that saves a long listing of your hidden files to a file named hiddenlist b) (2 points) ... (4 Replies)
Discussion started by: luislozoya
4 Replies

2. Shell Programming and Scripting

Open a file from within a Bourne shell Script

I am suppose to make a program that cuts the extension off of a file. It uses that .ext to decide which program needs to be used to open the file. This only finds the name of the program from a list of programs I made. My problem is when it has the name of the program it needs to use, how can I... (3 Replies)
Discussion started by: dordrix
3 Replies

3. Shell Programming and Scripting

bourne shell script error on line containing declare...

Hi, Get the following error when running a shell script with following statement. Syntax error at line 150 : `(' is not expected 150: declare -a VPO_SEV=(Normal Warning Minor Major Critical) it runs fine using bash, so I guess the script should be using bash but is there a... (1 Reply)
Discussion started by: wilsonee
1 Replies

4. Shell Programming and Scripting

Bourne Shell script - log for users loggin on and off

Hello all, I'm new to shell scripting and want to make a script that I can write to log the users logging on and off the a unix system. I have had a good look over the past few days to crack it, I think I am getting close. I want a script that runs an infinite loop to check every 5 seconds... (14 Replies)
Discussion started by: noodlesoup
14 Replies

5. Shell Programming and Scripting

Bourne: How to invoke an alias from within a shell script

Bourne: How to invoke an alias from within a shell script If I type in the alias in the command line, it runs If I insert that same alias into my shell script and run the shell script, the alias is not invoked. Help please. (2 Replies)
Discussion started by: techshots
2 Replies

6. Shell Programming and Scripting

cd from a Bourne Shell Script - Please Help

Dear Bourne Shell Expert, I am trying to change the current working directory from within a Bourne Shell script. Simply enough i thought ! As I am sure you are well aware, Inside the script i echo `pwd` and it seems ok, but the shell spawns another shell to execute this and as such, when my... (10 Replies)
Discussion started by: fawqati
10 Replies

7. Shell Programming and Scripting

Trouble using substr function with Bourne shell script

Hi, I'm a newbie to UNIX scripting and I'm having some trouble compiling my script. I'm using the Bourne Shell and cannot seem to use the substr function correctly. I'm trying to extract the last two digits of a year that's stored in a variable based off of a condition. I've searched the... (4 Replies)
Discussion started by: E2004
4 Replies

8. UNIX for Dummies Questions & Answers

Bourne Shell Script

Hello, I'm throwing this out there as a novice to the Unix world...I've been working on a project that requires me to ouput (using the echo command) a list of names in a single column format, but the problem is the input is in row format followed by a blank space...If anyone could give me a... (2 Replies)
Discussion started by: dmhonor914
2 Replies

9. Shell Programming and Scripting

bourne shell script

Hi all, Can somebody answer the following query Thanks, Srinivas A shell program that takes one or any number of file directory names as input; sorts the directories given as parameters jointly in the ascending or decending order of choice For EX : dips abc etc desc will sort the files... (2 Replies)
Discussion started by: psrinivas
2 Replies

10. UNIX for Advanced & Expert Users

Bourne shell script need help please ?

i have this assignment.. and i mad this script but there is something wrong with it.. if anyone can tell me.. watz going on... i would appreciate it.. tHnX in advance.. count=1 val=$2 op=$1 ans=0 if then if then while do ... (7 Replies)
Discussion started by: dezithug
7 Replies
Login or Register to Ask a Question