Getting confused about passing parameters to perl


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Getting confused about passing parameters to perl
# 1  
Old 07-06-2010
Getting confused about passing parameters to perl

I've got a large text file, cleanme, that I want to process for all combinations of words in a second file, commonwords.

So I can iterate through commonwords like so:
Code:
filearray=( `cat commonwords | tr '\n' ' '`)
filearray=( `cat commonwords | tr '\n' ' '`)

for firstword in ${filearray[@]}

	do
		for lastword in ${filearray[@]}
		do	
		./word_extractor_script.sh $firstword $lastword
		done

	done

However, when I call word_extractor_script.sh , I don't get quite the output I expect.

word_extractor_script.sh is as follows

Code:
perl -p -e 's/^.*?$1/$2/' cleanme > CleanerExtract

sed 's/^/$1 /g' CleanerExtract > CleanerExtract1

sed -n '/$2/p' CleanerExtract1 > CleanerExtract2

sed G CleanerExtract2 > CleanerExtract3

sed -e 's/.*$1//' -e 's/$2.*//' CleanerExtract3 > CleanerExtract4

sed '/^.\{1000\}/d' CleanerExtract4 > OutputShorter_$1_$2

rm CleanerExtract
rm CleanerExtract1
rm CleanerExtract2
rm CleanerExtract3
rm CleanerExtract4

If I replace $1 and $2 in word_extractor_script.sh with actual words, everything runs fine - am I doing something very dumb with the parameters I'm passing to the second script? Or is it something to do with the $ being a metacharacter in the regex and this causing thigns to get confused?

Thanks,

James


commonwords (for this example) could be

cat
dog
elephant

and cleanme could be

There is a cat next to a dog. The dog is next to the cat. The elephant is behind the dog but under the cat which is to one side of the elephant and underneath the dog.

I'd expect CleanerOutput_cat_dog to be produced as one of the results, and contain

which is to one side of the elephant and underneath the

... although instead I get nothing (unlike what happens if I run word_extractor_script.sh with the $1 and $2 replaced with cat and dog).
# 2  
Old 07-06-2010
Change all single-quotes to double-quotes in your shell script, like so -

Code:
$
$
$ cat word_extractor_script.sh
perl -p -e "s/^.*?$1/$2/" cleanme > CleanerExtract
 
sed "s/^/$1 /g" CleanerExtract > CleanerExtract1
 
sed -n "/$2/p" CleanerExtract1 > CleanerExtract2
 
sed G CleanerExtract2 > CleanerExtract3
 
sed -e "s/.*$1//" -e "s/$2.*//" CleanerExtract3 > CleanerExtract4
 
sed "/^.\{1000\}/d" CleanerExtract4 > OutputShorter_$1_$2
 
rm CleanerExtract
rm CleanerExtract1
rm CleanerExtract2
rm CleanerExtract3
rm CleanerExtract4
$
$

It should work thereafter -

Code:
$
$ # show the contents of file "cleanme"
$ cat cleanme
There is a cat next to a dog. The dog is next to the cat. The elephant is behind the dog but under the cat which is to one side of the elephant and underneath the dog.
$
$ # show the contents of script "word_extractor_script.sh"
$ cat word_extractor_script.sh
perl -p -e "s/^.*?$1/$2/" cleanme > CleanerExtract
 
sed "s/^/$1 /g" CleanerExtract > CleanerExtract1
 
sed -n "/$2/p" CleanerExtract1 > CleanerExtract2
 
sed G CleanerExtract2 > CleanerExtract3
 
sed -e "s/.*$1//" -e "s/$2.*//" CleanerExtract3 > CleanerExtract4
 
sed "/^.\{1000\}/d" CleanerExtract4 > OutputShorter_$1_$2
 
rm CleanerExtract
rm CleanerExtract1
rm CleanerExtract2
rm CleanerExtract3
rm CleanerExtract4
$
$ # execute the script passing "cat" and "dog" as parameters
$ ./word_extractor_script.sh cat dog
$
$ # show the contents of "OutputShorter_cat_dog"
$ cat OutputShorter_cat_dog
 which is to one side of the elephant and underneath the
$
$

In any case, are you trying to do this ?

Code:
$
$ perl -plne 's/^.*cat(.*?)dog.*$/$1/' cleanme
 which is to one side of the elephant and underneath the
$

You don't need so many calls to sed in such a case.

tyler_durden
This User Gave Thanks to durden_tyler For This Post:
# 3  
Old 07-07-2010
Thanks.

That single line of perl looks more elegant than what I had: I'll try that tonight.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Passing Parameters to Crontab

Hello Experts, I have a requirement to pass some parameters to Linux cron tab. For ex: My default cron entry looks like this as below: ------------------------------- 55 10 * * --... (7 Replies)
Discussion started by: MaheshChaudhari
7 Replies

2. Shell Programming and Scripting

Passing 2+ parameters to one command

I have a script that uses more than one parameter. It looks like this: for i in `cat /tmp/listofpolicies`; do for x in $(cat /tmp/lst |sed 's/^/\/usr\/openv\/netbackup\/db\/class\//g'); do /usr/openv/netbackup/bin/admincmd/bpplinclude $i -delete -f $x;done;done The problem is that the... (3 Replies)
Discussion started by: newbie2010
3 Replies

3. Shell Programming and Scripting

passing parameters with spaces

we are using following script to execute stored procedue. The problem is run_pmcmd.ksh script is using $* parameter which is not taking in account 'Men Shirt' parameter which includes spaces. 1. Step 1 run_pmcmd.ksh CONVERT_TEST script for run_pmcmd.ksh /u01/$(whoami)/run_pmcmd.ksh... (11 Replies)
Discussion started by: sandy162
11 Replies

4. Shell Programming and Scripting

passing parameters to the script

how can i make a script to run only when parameters are given, if parameters are not given it should through an error , saying "please enter a parameter" for ex: i want a find command to run only when the parameters are given (4 Replies)
Discussion started by: knip
4 Replies

5. UNIX for Dummies Questions & Answers

Passing the parameters through a file

Hi All, I have written a shell script and the script is working fine, I am passing my MIT_ID(NUMBER VALUE) to the shell script from the command prompt and my script is executing as expected. Now I have to pass all the MIT_ID's from a .txt file to the shell script,as I am automating this I... (6 Replies)
Discussion started by: gaur.deepti
6 Replies

6. Shell Programming and Scripting

Passing the parameters using a function

Hi All, I am new to shell scripting required some help in passing the parameter value to the shell script. I am writing a shell script, in the script I have created two functions as below. first function get_trend_ids () { Here I am connecting to the database and getting all the... (3 Replies)
Discussion started by: shruthidwh
3 Replies

7. Shell Programming and Scripting

Automate the passing of parameters

I am writing a script that should read the csv file and pass the values in the file as parameters to the script. The csv file looks like this: TEST_1,20110221 TEST_2,20110220 TEST_3,20110218,20110219 Currently this is how i am running the script ./test.sh <param1> <date> Ex: ./test.sh... (6 Replies)
Discussion started by: stunnerz_84
6 Replies

8. Shell Programming and Scripting

passing parameters using awk

Hi, The below script is working fine awk1.sh ======= awk BEGIN { FS="|" } FNR==NR { f1=$2; next } $1 in f1 && $2 =="xx" && $1 == "DAILY_JOB" {print $3} awk -f awk1.sh a.txt b.txt--Its working fine . When passing parameters its not working .Any help it should be appereciated. ... (4 Replies)
Discussion started by: akil
4 Replies

9. Shell Programming and Scripting

passing more than 9 parameters

hi, i am passing around 14 parameters for a script a=$1 b=$2 c=$3 d=$4 e=$5 f=$6 g=$7 h=$8 i=\"${9}\" shift j=\"${1}\" still for j it is displaying the 1st parameter value..how to make it take the 10th parameter (2 Replies)
Discussion started by: dnat
2 Replies

10. Shell Programming and Scripting

Passing parameters through a file

I have created a script "myscript.sh" I need to run this script with diffrent parameters. The parameters are stored in a file myparam.txt. I need to run myscript.sh script for every parameter supplied in myparam.txt. Example: If myparam.txt contains following lines: param1 param2 param3... (3 Replies)
Discussion started by: chawlaaman
3 Replies
Login or Register to Ask a Question