What's wrong with my script ....


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting What's wrong with my script ....
# 1  
Old 05-20-2010
What's wrong with my script ....

Please see below mentioned my script ... it ran once without any issue .... then after it is not coming out .... please suggest what is wrong?

Code:
#!/bin/ksh
## if (( ${num_errors} > 0 ));
export ACULOG=/home/varshnes/input
export num_errors=10
**** Search for 'Start correcting roll up conflicts' ****
STRING=$(find $ACULOG -name "*" | xargs grep -i "Start" | grep -i "correcting" | wc -l)
echo $STRING
 if (( ${STRING} > 0 ));
 then
 echo -n "$num_errors "
 num_errors=`expr $num_errors - 1`
 fi
STRING=$(find $ACULOG -name "*" | xargs grep -i "End" | grep -i "correcting" | wc -l)
echo $STRING
 if (( ${STRING} > 0 ));
 then
 echo -n "$status "
 num_errors=`expr $num_errors - 1`
 fi
echo -n "$num_errors "
 if (( ${num_errors} > 0 ));
 then
 echo "SEND MAIL NOW"
 fi
exit 0


Last edited by Scott; 05-20-2010 at 05:28 PM.. Reason: Code tags please...
# 2  
Old 05-20-2010
Can you post the errors that you face?
The script looks fine assuming your 5th line as an comment line.
# 3  
Old 05-20-2010
5th line is not an acceptable comment line...needs to be preceded with a hash/#-sign.
# 4  
Old 05-20-2010
What's wrong with my script ....

There is not any error ... it is simply not doing anything ... not coming out either. it ran once and do not know what I did and it has stoped working ... please suggest ..thx
# 5  
Old 05-21-2010
right, because it gets to the 5th line and it starts trying to use globbing...for no reason, and stalls.

Comment out the 5th line...and maybe even redirect the script itself to 2>&1, and you may get it to run.
# 6  
Old 05-21-2010
That was corerct ...removed *'s and it works fine ... a quick question though ...
the line ...
Code:
STRING=$(find $ACULOG -name "*" | xargs grep -i "Start" | grep -i "correcting" | wc -l)

Can it by write in different style? I'm trying to grep complete line here.

Thanks!

Moderator's Comments:
Mod Comment Added code tags
# 7  
Old 05-21-2010
I'm not sure what you mean by grep complete line...? Looks like you're just grabbing any line in any file in that directory that contains "Start", and then counting only those that also contain "correcting"...

I would suggest maybe the following if you're looking for a more compact approach:
Code:
typeset -i STRING=$(find $ACULOG -name "*" |xargs grep -i "Start" |grep -c "correcting" )

Otherwise, if you mean to return the entire line, then you'd want to just stop counting:
Code:
COMP_LINE=$(find $ACULOG -name "*" |xargs grep -i "Start" |grep -i "correcting" )

Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Why result is wrong here ? whether break statement is wrong ?

Hi ! all I am just trying to check range in my datafile pls tell me why its resulting wrong admin@IEEE:~/Desktop$ cat test.txt 0 28.4 5 28.4 10 28.4 15 28.5 20 28.5 25 28.6 30 28.6 35 28.7 40 28.7 45 28.7 50 28.8 55 28.8 60 28.8 65 28.1... (2 Replies)
Discussion started by: Akshay Hegde
2 Replies

2. Shell Programming and Scripting

What is wrong with my script?

Dear All The following is part of my script: echo ${myarray} mytitle=`awk '{print substr(${myarray}, 0, length(${myarray})-4)}' /dev/null` the echo ${myarray} works fine; however, I keep getting following error for the mytitle=.. part: awk: line 1: syntax error at or near { awk: line... (3 Replies)
Discussion started by: littlewenwen
3 Replies

3. Shell Programming and Scripting

Can anyone tell me what's wrong with my script

Hi... I am fed up in file handing with array for comparing.... 1st I want save first 2 columns of file 1 I tried like this,, {getline< "file1";ln=$1; lt=$2}then I read second file's 1st and 2nd column..and saved like this and small calculation and initialization var1 =$1 var2 =$2... (5 Replies)
Discussion started by: Akshay Hegde
5 Replies

4. UNIX for Dummies Questions & Answers

What's wrong on this script?

I get this error on these lines when i run this script:"for i in /home;do file2=`ls -s $i` if ;then ls - s $i fi done (7 Replies)
Discussion started by: kotsos13
7 Replies

5. Shell Programming and Scripting

Script Gone Wrong

Hello all, so this is a script i did for an assignement, - first option greets the user according to the time after fetching his name - second options isn't implemented - third check the performance according to how many users are using the system - creates a log of names, time and ip of the... (14 Replies)
Discussion started by: ibzee33
14 Replies

6. Shell Programming and Scripting

what is wrong with this script?

Hi I've made a short script but it is not working. Can some pl. help me out in this? ./123.sh #! /usr/bin/ksh # for changing to this directory cd /layered/relational/scripts When I run the above scripts, it doesn't change to the above directory. I don't what is the problem? the... (2 Replies)
Discussion started by: Mike1234
2 Replies

7. UNIX for Dummies Questions & Answers

what is wrong with this script?

Hi, I have this example script which gives error ": unexpected operator/operand". I need the '' brackets for operator precedence. #!/bin/ksh x="abc" y="xyz" z="123" if -a then print "yes" else print "no" fi Thanks (2 Replies)
Discussion started by: rs1969
2 Replies

8. Shell Programming and Scripting

What's wrong with this script

I am trying to create a script but it is giving me errors on Cygwin for the following script. Could someone tell me, what am I doing wrong? choice=1000 echo "choice is $choice" while ; do echo "choice is $choice" echo 'Please select your option:' echo '1. Option 1' echo '2. Option 2'... (3 Replies)
Discussion started by: amitg1980
3 Replies

9. Shell Programming and Scripting

What is wrong with this script?

I keep getting errors messages for the "else" statement at line 81? #!/bin/ksh ######### Environment Setup ######### PATH=/gers/nurev/menu/pub/sbin:/gers/nurev/menu/pub/bin:/gers/nurev/menu/pub/mac :/gers/nurev/menu/adm/sbin:/gers/nurev/menu/adm/bin:/gers/nurev/menu/adm/mac:/ge... (8 Replies)
Discussion started by: heprox
8 Replies

10. UNIX for Dummies Questions & Answers

What is wrong with my script?

Hey guys, can someone help me with this script... #!/bin/sh dir=`pwd` for i in *.f do if then M=`wc -l < ${i} sed -e 's://.*::' < ${i} | \ (echo "//${i} -"$M ; cat - ) > $i.tmp chmod 700 $i ; mv ${i}.tmp $i ... (6 Replies)
Discussion started by: Lem2003
6 Replies
Login or Register to Ask a Question