Request to code review Suggestions Plz

Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Request to code review Suggestions Plz
# 1  
Old 10-22-2009
Request to code review Suggestions Plz

Hello All,

I have 2 questions,

1) I am on Unix Sun Solaris korn shell, in my shell scripts i am using

Instead of

, though it is still working is this correct way of doing and also I am saving the shell script file as instead of abc.ksh, please let me know the best practice does it really matters are there any issues involved if i specify different shell.

2) Do you have any suggestions or best practice syntax for below shell script, in this script i have some commands which would invoke other stuff for that i need to supply the login credentials in that syntax, is there any way i can hide the password in shell script so that it is not readable to others though it should execute fine at run time,

Appreciate your help, Thank you!!


cat /dev/null > $logfile

cd $HOME
echo "Date Executed: "`date`>> $logfile
echo "Current Directory: "`pwd` >> $logfile

. /u03/app/OracleBI/setup/
if [ $? -eq 0 ] ; then
echo "Successfully Invoked OBIEE Initialization Shell Script" >> $logfile
echo "Error in Invoking OBIEE Intialization Shell Script" >> $logfile

/u03/app/oraclebi/server/Bin/nqcmd -d AnalyticsWeb -u Administrator -p PASSWORD -s /u03/app/dac/DAC/purgecache.nqcmd
if [ $? -eq 0 ] ; then
echo "Successfully Cleared The Analytics Cache" >> $logfile
echo "Error In Clearing the Analytics Cache " >> $logfile

# 2  
Old 10-22-2009
On a different platform, /bin/sh may be a Bourne-derived shell or even an old-fashioned plain Bourne shell. Linux systems in particular tend to be based around BASH, an extended Bourne shell, and may not have ksh at all.

It's only coincidentally the same thing as ksh under Solaris. If your scripts demand ksh features, use #!/bin/ksh. I had to break myself of the habit too, when I tried moving some of my scripts over to an embedded environment that had a plain sh but not a bash...

As for preventing others from reading the password, don't give anyone read-permissions to the script. You could also include an encrypted form of the password in the script that's decrypted with another password I suppose, but then why not just ask for the database password instead. And you'd still ultimately be passing the password to something else on the commandline which is just as big a security hole, commandline parameters can be viewed by anyone via /proc/. (Your database might fork and exec to hide its parameters though.)

Last edited by Corona688; 10-22-2009 at 03:41 PM..
Login or Register to Ask a Question

Previous Thread | Next Thread

7 More Discussions You Might Find Interesting

1. Programming

Code review: recursion in circular array, reduce two functions to one?

Hello, I think there's an easier way to do this but can't seem to recall but given an array of animals and an initial value is a random index in the array, here it's 3. 3,4,5,4,3,2,1,0,1,2,3,4,5,4,3,2,1,0... inifinite repeat a quick brute force solution i came up with was two functions, i... (6 Replies)
Discussion started by: f77hack
6 Replies

2. UNIX for Dummies Questions & Answers

Any tips/suggestions for a newbie beginning to read the Linux Kernel Source Code

Hi All, I recently downloaded the Linux kernel source code, added them all to a project in MS VC++ and plan to read through it so that I can improve the way I code, read/understand a large code database and hopefully contribute something to the development of the Linux OS. I have taken a... (3 Replies)
Discussion started by: clavian
3 Replies

3. UNIX for Advanced & Expert Users

Pls review this code and suggest if it can be written in a better way

Pls review this code and provide your feedbacks to make it more efficient.I have tried to add to each section. Code ############################################################### #!/bin/ksh RRSRC=/test RREP=/test #Directories test_dir=/test #Imp Files FILENAME=/test/files.txt #... (5 Replies)
Discussion started by: w020637
5 Replies

4. UNIX for Dummies Questions & Answers

Where can I review the source code?

A very n00b question: After compiling and installing software, where does the original source code reside? I'd like to study the source code of some of the ports I've installed. Thanks! :D (1 Reply)
Discussion started by: Aaron Van
1 Replies

5. Shell Programming and Scripting

Can someone review my code tell me where I am going wrong?

Started writing my code. my read input is not even asking nor working? And I get a EOF script error. echo "1)" echo "2)" echo "3)" echo "4)" echo "5)" echo "What server would you like... (4 Replies)
Discussion started by: chrchcol
4 Replies

6. Shell Programming and Scripting

Can some review my code would be appreicated?

I am getting an error " syntax error at line 8 : `<<' unmatched" #!/bin/ksh PATH=/usr/sbin/:/usr/bin:/usr/ucb:/etc:/usr/local/bin:. cd $HOME if ;then if ; then echo 'DSC file already ftp to epm server' else ftp -n epmdev00 <<SCRIPT... (1 Reply)
Discussion started by: sibghat
1 Replies

7. Shell Programming and Scripting

a piece of code, plz help to review

use "getopts" to get params from command. Need replace black with a specified string like "%20 DEFAULT_DELIM=%20 ... while getopts dek:f:t:vh OPTION do case $OPTION in t) DELIM=`tvar=/'"$OPTARG"'/ svar="$DEFAULT_DELIM" awk 'BEGIN{T=ENVIRON;S=ENVIRON; while(index(T,S)!=0){S=S"0"};print... (0 Replies)
Discussion started by: anypager
0 Replies
Login or Register to Ask a Question