Long file names within shell script


Login or Register to Reply

 
Thread Tools Search this Thread
# 1  
Old 12-07-2016
Long file names within shell script

I am downloading a zip file that contain files that are very long. I am trying to process them, but cannot. I can move the files from one directory to another at the shell prompt, but not within a shell script, I get a stat error.

The files look somewhat like this;

Code:
08fe457ab_34fed678_MCRXCOMM.FIL_999.edi

I do not know what the problem is.

Any help would be appreciated!

---------- Post updated at 08:51 PM ---------- Previous update was at 07:59 PM ----------

I was able to resolve this problem.

I was trying to delete the original post, but did not know how.

Last edited by Scrutinizer; 12-07-2016 at 11:09 PM..
# 2  
Old 12-08-2016
Quote:
Originally Posted by trolley
I was trying to delete the original post, but did not know how.
Don't! Write your solution here instead, so that others, which have the same (or a similar) problem can learn from your findings.

bakunin
This User Gave Thanks to bakunin For This Post:
rbatte1 (12-08-2016)
# 3  
Old 12-08-2016
Not sure how I resolve my issue. I was trying many things and it just finally worked. I was using the following code;

Code:
mv $filxfr/*.edi  $filtmp/.
for RPTFIL in `ls`
do
    mv $RPTFIL FLXRPT.DAT
    rpt999
       .
       .
       .
done

In the filxfr directory, I had zip and text files. So the above code would not work. I made sure the text files were in another directory for processing. I later found an error in my subroutine (ie. rpt999) that was not looking in the correct directory.

Again, I am not sure this helps. I would have posted this last night, but I thought it would not be helpful. That is why I wanted to delete my original post. I am a firm believer in sharing results or ideas.
# 4  
Old 12-08-2016
"

Quote:
Originally Posted by trolley
Code:
mv $filxfr/*.edi  $filtmp/.
for RPTFIL in `ls`
do
    mv $RPTFIL FLXRPT.DAT
    rpt999
       .
       .
       .
done

First off: thanks for sharing. And because you did that (instead of just saying you have a solution) you get something back immediately in return: some explanation why your script probably hasn't worked. So this will be at least helpful to you (but perhaps some others, because what you did is a common error). Here it goes:

When you write scripts, as a rule of thumb, NEVER use relative paths or filenames. See, you can call a script from everywhere and its workings should always be the same, regardless of from where you called it. The line

Code:
for RPTFIL in `ls`

will work if you call the script in one directory, but fail if you call it in another. Save for that, you should avoid the backticks (they are obsolete) but you do not need them anyway: for file in *edi ; do will work the same and you do not need to call ls for that. You see, "*" means already "all files" and is interpreted b the shell, not the program called. A command like:

Code:
ls *file

is processed this way: first, the shell sees the asterisk and "expands" it to a list of files matching, in this case: all files with names ending in "file" in the current directory. Then the result of this "expansion" is put on the (intermediate) command line:

Code:
ls *file                     # your command
ls a.file b.file c.file      # after expansion (you won't see that)

Finally the command itself (here ls) is called and given the list of files, which it displays. If you call ls without any parameters it doesn't do much at all, only when you use additional options it gets more and more useful. But try, to test what i have said, on the commandline:

Code:
echo *

and you will see that it produces the same list as ls without options. And with the explanation above you know why.

Anyway, preferable is to provide what the script needs to know on the commandline, like:

Code:
myscript.sh /path/to/my/data

UNIX has a quite fixed directory hierarchy and there is a certain place for all sorts of things. You put i.e. temporary files always in /tmp and, on the other hand, whatever is in /tmp can be deleted without question. So your script can assume some paths to be given.

Second: as a rule of thumb, always quote your variables! The shell treats space as separators, so a line like:

Code:
a b c

will call a program "a" with the first parameter "b" and the second parameter "c". It is possible to name a program "a b" or pass parameters with enclosed spaces you need to quote:

Code:
"a b" "c d"    # will start a program "a b" with a single parameter "c d"

Now let us see your script itself:

The first thing is: when you start programming, keep a strict order. It will help you to organize your code. We always start with a shebang line, telling the OS which shell to use (instead of relying on an arbitrary default that could change), then declare the variables we use. This gives us the opprtunity to write in commentary what should go into these variables. Note that everything after "#" is a commentary.

Code:
#! /bin/ksh
# maybe you want to use "#! /bin/bash" instead, this line is called "shebang"

dir="$1"                     # working directory
tmpdir="/tmp/mydir"          # temporary workspace
file=""                      # filename buffer

if [ -e "$tmpdir" ] ; then
     mkdir -p "$tmpdir"
fi

mv ${dir}/*edi  "$tmpdir"

for file in "$tmpdir/*" ; do
    mv "file" "/some/place/FLXRPT.DAT"
    process_file
    if [ $? -ne 0 ] ; then         # you might want some error reporting here
        echo "ERROR processing $file" >2&
    fi
    ....
done

rmdir "$tmpdir"

exit 0

This will first copy all files "*edi" from some directory to "/tmp/mydir", then copy one file after other to the name "/some/place/FLXRPT.DAT" and process it. if the (hypothetical) command "process_file" exits with any other value than 0 (conventionally this means success) an error message is produced and the script continues (it might also stop if you put an "exit" command after the echo). Once the list is finished the temporary directory is deleted and the script exits with 0 itself.

Now, i suppose this is not exactly what you wanted to do and you could (and should) modify it to better suit your needs. It is not so much about how to write a certain script but to show the princinples of how to write any script. Always bear in mind that scriptingis like any other form of software engineering and the same principles apply. In fact it is even more demanding (mostly on self-control) because you can get away initially with a lot of slack where other programming languages are more demanding from the start. You should mostly not rely on these shortcuts, because the longer your scripts get (and, believe me, once you get the hang of it you are NEVER going to stop) the more you need to drop these bad habits and do it the correct way. So better start developing good habits from the start.

In either case, if you have troubles extending your script we will be here to help you.

I hope this helps.

bakunin

Last edited by bakunin; 12-08-2016 at 02:59 PM..
This User Gave Thanks to bakunin For This Post:
trolley (02-15-2017)
# 5  
Old 02-15-2017
the shebang line needs to be corrected, do not place a space between exclamation mark and slash, type it like this
Code:
 
 #!/bin/ksh

This User Gave Thanks to migurus For This Post:
trolley (02-15-2017)
# 6  
Old 02-23-2017
Quote:
Originally Posted by migurus
the shebang line needs to be corrected, do not place a space between exclamation mark and slash, type it like this
Code:
 
 #!/bin/ksh

Sorry, but this is not correct: in fact both shebang lines:

Code:
#! /path/to/interpreter

and
Code:
#!/path/to/interpreter

will work because the three-byte "magic number" "#!/" as well as the 4-byte magic number "#! /" is built into the UNIX-kernel. You need to use absolute pathes, though, and i.e.

Code:
#! ../path/to/interpreter

will not work, regardless of a space being there or not.

I hope this helps.

bakunin
Login or Register to Reply

|
Thread Tools Search this Thread
Search this Thread:
Advanced Search

More UNIX and Linux Forum Topics You Might Find Helpful
shell script for long listing of groupnames mike12 UNIX for Dummies Questions & Answers 3 01-31-2011 11:01 PM
script regarding listing long group names mike12 UNIX for Advanced & Expert Users 1 01-31-2011 09:55 PM
specified path name is too long passing parameters to awk via shell script script_op2a Shell Programming and Scripting 0 11-09-2010 07:03 PM
Find and rename long file names (html) Rajmani Shell Programming and Scripting 7 04-22-2010 04:22 AM
Urgent!! : How to read very long line using shell script hrvispute Shell Programming and Scripting 3 06-24-2009 05:14 AM
want only file names (not whole path) in shell script crackthehit007 Shell Programming and Scripting 6 02-11-2009 12:09 AM
Renaming file names in a shell script rudoraj Shell Programming and Scripting 1 01-26-2009 08:05 PM
Dealing with spaces in file names in a shell script same1290 Shell Programming and Scripting 5 08-13-2008 12:01 AM
Is there a way to tell how long does a shell script's execution take? meili100 UNIX for Dummies Questions & Answers 4 02-25-2008 07:49 AM
shell script takes long time to complete ozzman Shell Programming and Scripting 12 02-05-2007 11:25 PM
Reading file names from a file and executing the relative file from shell script anushilrai Shell Programming and Scripting 4 03-10-2006 05:25 AM
Displaying VERY long process names with ps -ef m223464 UNIX for Dummies Questions & Answers 8 02-07-2006 10:44 AM
mkisofs and long file names XP_2600 Solaris 2 02-07-2006 09:26 AM
Dos window, long file names prob kymberm Windows & DOS: Issues & Discussions 4 10-11-2002 02:18 AM
linux question, pardon, on long file names kymberm UNIX for Dummies Questions & Answers 2 09-11-2002 09:28 PM