Problem with signal handler and interrupted system call


 
Thread Tools Search this Thread
Top Forums Programming Problem with signal handler and interrupted system call
# 1  
Old 01-26-2009
Problem with signal handler and interrupted system call

Hi,

I have a daq program that runs in an infinite loop until it receives SIGINT. A handler catches the signal and sets a flag to stop the while loop. After the loop some things have to be cleaned up.
The problem is that I want my main while loop to wait until the next full second begins, to start some action. To do so it waits for the RTC interrupt. Unfortunately the read() which waits for the interrupt seems to be interrupted itself by SIGINT. That causes my program to exit abnormally with
Code:
read: Interrupted system call

and without cleaning up.
I already tried it with SIGHUP and SIGUSR1 instead of SIGINT without succes.

How could I prevent my read() from being interrupted?

Thanks in advance


Here are the important code snippets:
the loop in main()
Code:
    /* 
     * Signal handling 
     */ 
    struct sigaction act;
    /* define the signal action */
    act.sa_handler = terminate;
    /* make "act" an empty signal set */
    sigemptyset(&act.sa_mask);
    act.sa_flags = 0;
    /* instead of SIGHUP do "act" */
    sigaction(SIGHUP, &act, 0);
    
    /* 
     * main loop : runs until the signal handler  
     * receives a SIGINT to change "keep_running" to 0
     */
    while(keep_running){
        /* wait for irq */
        retval = await_rtc_irq(freq);
        /*.....*/
    }
    syslog (LOG_NOTICE, "clean up and exit\n");
    close(fdlock);
    unlink(DAQD_LOCK_FILE);
    closelog();
    return 0;

the wait_for_the_interrupt function
Code:
long int await_rtc_irq(int freq)
{
    int fd;
    long int retval, controlval;
    unsigned long data;
    
    /* open the RTC IRQ */
    fd = open ("/dev/rtc", O_RDONLY);
    
    if (freq == 1) {
        /* Enable periodic 1Hz interrupts */
        retval = ioctl(fd, RTC_UIE_ON, 0);
        if (retval == -1) {
            perror("ioctl");
            exit(errno);
        }
        /* call the read function to await the Alarm interrupt */
        retval = read(fd, &data, sizeof(unsigned long));
        if (retval == -1) {
            perror("read");
            exit(errno);
        }
        controlval = retval;
        /* Turn off update interrupts */
        retval = ioctl(fd, RTC_UIE_OFF, 0);
        if (retval == -1) {
            perror("RTC_UIE_OFF ioctl");
            exit(errno);
        }    
    }
    /* For frequencies different from 1 the irq has to be set differently.*/
    else if (freq == 2 || freq == 4 || freq == 8 || freq == 16 || 
         freq == 32 ||   freq == 64|| freq ==128){
        /* set peridoc interrupt frequncy */
        retval = ioctl(fd, RTC_IRQP_SET, freq);
        if (retval == -1) {
            perror("ioctl");
            exit(errno);
        }
        /* Enable periodic interrupts */
        retval = ioctl(fd, RTC_PIE_ON, 0);
        if (retval == -1) {
            perror("ioctl");
            exit(errno);
        }
        /* call the read function to await the Alarm interrupt */
        retval = read(fd, &data, sizeof(unsigned long));
        if (retval == -1) {
            perror("read");
            exit(errno);
        }
        controlval = retval;
        /* Disable periodic interrupts */
        retval = ioctl(fd, RTC_PIE_OFF, 0);
        if (retval == -1) {
            perror("RTC_PIE_OFF ioctl");
            exit(errno);
        }
    }
    else {
        puts("frequency not supported");
        exit(1);
    }
    close(fd);
    return(controlval);
}

# 2  
Old 01-26-2009
Quote:
Code:
       retval = read(fd, &data, sizeof(unsigned long));
        if (retval == -1) {
            perror("read");
            exit(errno);
        }

That's your problem, more or less. If read() is interrupted by a system call, it returns -1, sets errno to EINTR. Your program itself does the perror and exiting, not read(). So just check if the return is -1 and errno != EINTR and restart the loop (for instance). You'll have to handle the logic for the ioctls and what not, too, or every now and then, your signal will interrupt the ioctl and exit.
# 3  
Old 01-27-2009
That did it.
I totally missed to consider and change the error handling for the ioctls...

Thanks from Garmisch to Tirol
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Programming

Serial port signal(IRQ) handler (using C)

Hello, I'm writing some serial(UART) handler but have stuck on few issues, maybe anyone can help to show me what I'm doing wrong. Basically I'm intending to write serial RX signal handler. Application receives defined packages of data over serial which contains header and payload. Handler... (3 Replies)
Discussion started by: Lauris_k
3 Replies

2. Programming

problem in doing coding of signal handler

i m unble to execute code of signal handler using a) Wait b) Waitpid (1 Reply)
Discussion started by: madhura
1 Replies

3. Shell Programming and Scripting

Perl Signal Handler

I was working on some Perl code that does signal handling and I came across this one liner and wasn't sure what it was doing. local $SIG{__DIE__} = sub {$! = 2; die $_;}; I think the first part of the anonymous subroutine is setting $! to 2, but I am not sure what the second part is doing. ... (1 Reply)
Discussion started by: SFNYC
1 Replies

4. Programming

Signal Handler Hangs

Hi, I have a problem with signal handler algorithm in linux. My code is hanging ( It is continuously looping inside the signal handler) . I am pasting my code here... Please provide me some help regarding this. I googled many places and wrote this code.. but doesnt seem to be working without... (6 Replies)
Discussion started by: sree_ec
6 Replies

5. Shell Programming and Scripting

Perl - Problems with Signal Handler

I have a problem with signal handlers not working. I have a long 1000 line code and somehow this code for signal handling is not working: $SIG{INT} = \&interrupt; sub interrupt { print STDERR "Caught a control c!\n"; exit; # or just about anything else you'd want to do } Any... (2 Replies)
Discussion started by: som.nitk
2 Replies

6. Programming

Runaway SIGALRM signal handler

I have written a program to demonstrate a problem I have encountered when using BSD style asynchronous input using the O_ASYNC flag in conjunction with a real time interval timer sending regular SIGALRM signals to the program. The SIGIO handler obeys all safe practices, using only an atomic update... (8 Replies)
Discussion started by: stewartw
8 Replies

7. Programming

signal handler problems

Hey guys, I am trying to write a little shell, and was writing a signal handler to handle SIGINT (I am using 'stty intr ^C' and using ctrl-C to give SIGINT). I wrote this signal handler: void handle_sigint() { write(2,"handling sigint\n",16); write(1,"\nshell% ",8); } ... (4 Replies)
Discussion started by: blowtorch
4 Replies

8. Programming

signal handler for SIGCHLD

Hi, I have an c++ application which uses the function fork and execvp(). The parent does not wait until the child ends. The parents just creates children and let them do their stuff. You can see the parent program as a batch-manager. I have added a SIGCHLD handler to the program: void... (3 Replies)
Discussion started by: jens
3 Replies

9. Programming

sigwait system call in UNIX signal

Hi Everybody, I have gone through man of sigwait and new to UNIX signals. Could anyone explain me about the following lines mentioned in sigwait man help ? "The selection of a signal in set is independent of the signal mask of the calling thread or LWP. This means a thread or LWP can ... (1 Reply)
Discussion started by: md7ahuja
1 Replies

10. Shell Programming and Scripting

shell script signal handler

AIX 4.3.3 I am trying to write a signal handler into a ksh shell script. I would like to capture the SIGTERM, SIGINT, and the SIGTSTP signals, print out a message to the terminal, and continue executing the script. I have found a way to block the signals: #! /bin/ksh SIGTERM=15 SIGINT=2... (2 Replies)
Discussion started by: jalburger
2 Replies
Login or Register to Ask a Question