What am I doing wrong!!!


 
Thread Tools Search this Thread
Top Forums Programming What am I doing wrong!!!
# 1  
Old 06-07-2008
What am I doing wrong!!!

Hi all, I'm just getting back in to C programming after some time and I thought I would start off with a simple XOR encryption program. However I'm having trouble getting it to work. The code in prompt() function works great when it is just placed in side of main() however I want to be able to pass my arrays and file pointers to the prompt function to make the code more modular. Any help is much appreciated!

Code:
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

char encrypt(char, char *);
int prompt(FILE **, FILE **, char *, char *, char *, char *); 

int main()
{
    FILE *inputFile, *outputFile;   // Self explantory
    char fileIn[256] = {'\0'}, fileOut[256] = {'\0'},
          password[30] = {'\0'}, password2[30] = {'\0'}; /* Input file name,  output file name and password and password2 */                                                                          
    int holding = 1, fcharin = 1, retStat;   /* Where we keep the byte from the file thats been
                                       encrypted and the byte read from the file */
                                     
    printf("XORencrypt by David James\nCreated: 29/05/08\n\n");

    retStat = prompt(&inputFile, &outputFile, fileIn, fileOut, password, password2);
    
         /*   Below is the encryption part.  Each byte from the file is read in to a (char) then XOR'd with element 0
            of the password array, then element 1 then element 2 etc until NULL is reached in the password array.  Then
            the now encrypted (char) byte is written to the output file.
         */ 

         while ( (fcharin = fgetc(inputFile)) != EOF ) {
            holding = encrypt(fcharin, password);
            fputc(holding, outputFile);
         }
         
    printf("\nEncryption/Decryption complete!\n");
               
    return 0;
}


/* The XOR encryption function */

char encrypt(char fcharin, char *password)
{
    int i = 0, holding = 0;
    
    for ( i = 0; password[i] != '\n'; i++ ) {
        holding = fcharin ^ password[i];
    }
    
    return holding; 
}

/* If the user gives no command line arguments */

int prompt(FILE **inputFile, FILE **outputFile, char *fileIn, char *fileOut, char *password, char *password2)
{
    printf("File to encrypt/decrypt?: ");
    scanf("%255s", fileIn);

         if ( (*inputFile = fopen(fileIn, "rb")) == NULL ) { 
            printf("Error opening file.\n");
            exit(1);
         }
    
         printf("Save the encrypted/decrypted file as?: ");
         scanf("%255s", fileOut);
      
        do {
            printf("Enter a password (less than 30 characters [no spaces]): ");
            scanf("%29s", password);
            printf("Again: ");
            scanf("%29s", password2);
        } while ( strcmp(password, password2) );
       
        if ( (*outputFile = fopen(fileOut, "wb")) == NULL ) { 
           printf("Error writing file %s or it could not be opened.\n", fileOut);
           exit(1);
        }

        return 0;
}

# 2  
Old 06-08-2008
I have simplified your example to just print out the file so that the required change is more obvious:
Code:
#include <stdio.h>
#include <stdlib.h>

/* prototype */
int prompt(FILE **);

int
main(int argc, char *argv)
{
    int fcharin;
    FILE *in;

    prompt(&in);

    while ((fcharin = fgetc(in)) != EOF )
      fprintf(stdout, "%d\n", fcharin);

    return 0;
}


int
prompt(FILE **inp)
{
   char fileIn[256];

   printf("File to encrypt/decrypt?: ");
   scanf("%255s", fileIn);

   if ((*inp = fopen(fileIn, "rb")) == NULL ) {          
       printf("Error opening input file.\n");
       exit(1);
   }
}

# 3  
Old 06-08-2008
Thanks

Thanks for simplifying it. Next time I post code I will too. I can't see what I'm doing wrong its driving me mad! I did have lots of books on C untill my house got robbed... so I'm at the mercy of fellow C coders for help Smilie

Dave
# 4  
Old 06-09-2008
This is the case of the dangling pointer problem. You declare and initialize the variables in the prompt() function but when it returns to main() all of those disappear leaving the pointer variable in a state of limbo. The fact that your code works when it is all in main() should tell you that there is a disconnect in the way the functions exchange data.
# 5  
Old 06-09-2008
ok

Yeah I guessed there was some kind of dissconnect between the funtions. So how do I fix it? The variables where declared in function main btw. And I passed them by address so there values where changed in main as they where processed in function prompt(); however, thay are not the variables I am having trouble with. Its the FILE ** that are messing up. Anyhelp please?!

Dave
# 6  
Old 06-09-2008
Show errors

What machine are you running this program on and can you show the errors you are getting.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Why result is wrong here ? whether break statement is wrong ?

Hi ! all I am just trying to check range in my datafile pls tell me why its resulting wrong admin@IEEE:~/Desktop$ cat test.txt 0 28.4 5 28.4 10 28.4 15 28.5 20 28.5 25 28.6 30 28.6 35 28.7 40 28.7 45 28.7 50 28.8 55 28.8 60 28.8 65 28.1... (2 Replies)
Discussion started by: Akshay Hegde
2 Replies

2. UNIX for Advanced & Expert Users

What am I doing wrong here?

I am working on a simple login ID check shell script that should prompt for a user ID then check to see if this user is logged on. Trying to get the hang of this stuff so I am thinking of my own little projects. #! /bin/sh echo "please enter a user name" read user if user=$user then... (3 Replies)
Discussion started by: jsk319342
3 Replies

3. UNIX for Dummies Questions & Answers

What is wrong in here ???

]#PATH=/usr/bin:/etc:/bin:/boot/grub:/boot/grup/bin: /boot/solaris/bin:/sbin:/usr/openwin/bin:/usr/5bin://usr/X11/bin:/usr/apache/bin:/usr/apache2/bin:/usr/appserver/bin:... (9 Replies)
Discussion started by: microbot
9 Replies

4. Shell Programming and Scripting

what I m doing wrong?

when user select option 2 nothing happen.for testing purpose I put echo command but is not executing . basically when user prompt for option 2,I want to get list of database name from user separeted by space (TEST DEVL) and put into the file seprated by new line TEST DEVL after that stay on... (1 Reply)
Discussion started by: okreporthai
1 Replies

5. UNIX for Dummies Questions & Answers

what is wrong with this tr -d?

here is my command in bash shell on Mac OS X tiger: history | tr -d emacs here is what I get: hitory | grp "" | tr -d "" hitory | grp "" | tr -d """" hitory | grp "" | tr -d '' hitory | grp "" | tr -d '' hitory | grp "" | tr -d '' hitory | grp "" | tr -d... (3 Replies)
Discussion started by: cleansing_flame
3 Replies

6. UNIX for Dummies Questions & Answers

What am I doing wrong?

I really just mess around in UNIX, for the most part, when I want to get something done. I can usually piece things together by searching for brief how-to's on Google, but the syntax errors in my following .sh file are really confusing me. I've got lots of programming experience in other places, so... (7 Replies)
Discussion started by: demonpants
7 Replies

7. UNIX for Dummies Questions & Answers

what is wrong here

Hello, I have a simple script such as ----------------------------- #! /bin/sh YEAR=`date -u +%Y`; MONTH=`date -u +%m`; DAY=`date -u +%d`; DATE=$MONTH$DAY$YEAR LOGFILES=auditTrail-$DATE LOGMATCH=$LOGFILES\* ARGUM='' # find all files and write them to a file find . -name... (7 Replies)
Discussion started by: arushunter
7 Replies

8. Shell Programming and Scripting

Anything wrong with this

Does anyone see anything wrong with this. #getInfraFiles() #{ # cd Infra/$DAY # rm * # /usr/bin/ftp -i -n $LINE << cmd # user "$USER" "$PASSWD" # cd $INFRAPATH # binary # mget * # bye #} besides that its commented out (4 Replies)
Discussion started by: rcunn87
4 Replies

9. UNIX for Dummies Questions & Answers

Please tell me what do I do wrong here!

#!/usr/bin/csh # DAY=`date +%y%m%d` H=`date +%H` M=`date +%M` mailx -s "$H-Myfile" email@email.com</home/mydir/myfile Thanks! (4 Replies)
Discussion started by: bobo
4 Replies

10. UNIX for Advanced & Expert Users

What am I doing wrong

When I execute following shell script I am getting the following error syntax error at line 50 : `<<' unmatched What am I doing wrong :confused: Script begins here ---------------- MPAN_FILE=$1 exec 3<$MPAN_FILE ... (2 Replies)
Discussion started by: guptan
2 Replies
Login or Register to Ask a Question