Regardign strtok() output directing to 2-D string array


 
Thread Tools Search this Thread
Top Forums Programming Regardign strtok() output directing to 2-D string array
# 1  
Old 04-28-2008
Regardign strtok() output directing to 2-D string array

Hi,


I just wrote a program in C to split a comma seperated string in to group of strings using strtok() function. The code is:

Code:
int main()
{
    char *temp;//not used here but basically we extract one string after another using strtok() and assign to a string pointer defined like this.
    char *str="aa,bb,cc,dd";
    int count=0;
    for(int i=0;i<strlen(str);i++)
    {
      if(str[i]==',')
      count++;
    }

    char *ss[count];//2-d array where i want to store splitted results
    int j=0;
    *(ss+j)=strtok(str,",");

    while(*(ss+j)!=NULL)
    {
      *(ss+j)=strtok(NULL,",");
      j++;
    }
    
    //print  output
    for(int i=0;i<strlen(*ss);i++)
    printf("%s\t",*(ss+i));

    return 0;

}



The program compiles without error(please bear any syntax error, since i typed in hand without the code with me but the orignial program compiles successfully) but i am getting runtime error like 'Segmentation Fault'. I hope there needs to be proper memory handling here which i am not sure of.


Please help me in getting this splitted set of strings to a new 2-D array.


Thanks in advance.
# 2  
Old 04-28-2008
Quote:
Originally Posted by SankarV
Hi,


I just wrote a program in C to split a comma seperated string in to group of strings using strtok() function. The code is:

Code:
int main()
{
    char *temp;//not used here but basically we extract one string after another using strtok() and assign to a string pointer defined like this.
    char *str="aa,bb,cc,dd";
    char *ss;
    int count=0;
    for(int i=0;i<strlen(str);i++)
    {
      if(str[i]==',')
      count++;
    }

    char *ss[count];//2-d array where i want to store splitted results
    int j=0;
    *(ss+j)=strtok(str,",");

    while(*(ss+j)!=NULL)
    {
      *(ss+j)=strtok(NULL,",");
      j++;
    }
    
    //print  output
    for(int i=0;i<strlen(*ss);i++)
    printf("%s\t",*(ss+i));

    return 0;

}



The program compiles without error(please bear any syntax error, since i typed in hand without the code with me but the orignial program compiles successfully) but i am getting runtime error like 'Segmentation Fault'. I hope there needs to be proper memory handling here which i am not sure of.


Please help me in getting this splitted set of strings to a new 2-D array.


Thanks in advance.
Hi,
Just a little comment after a quick look to your code: i would suggest you to allocate memory properly (using malloc) and not use a shortcut like this
Code:
for(int i=0;i<strlen(str);i++)
    {
      if(str[i]==',')
      count++;
    }

    //char *ss[count];//2-d array where i want to store splitted results
    ss = malloc(count*sizeof(char)); // try this one!

# 3  
Old 04-28-2008
Thanks a ton.

This is working fine now....
# 4  
Old 04-28-2008
No problem, glad i could help Smilie
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

awk Associative Array and/or Referring to Field by String (Nonconstant String Value)

I will start with an example of what I'm trying to do and then describe how I am approaching the issue. File PS028,005 Lexeme HRS # M # PhraseType 1(1:1) 7(7) PhraseLab 501 503 ClauseType ZYq0 PS028,005 Lexeme W # L> # BNH # M #... (17 Replies)
Discussion started by: jvoot
17 Replies

2. UNIX Desktop Questions & Answers

Re-directing output

ps –xyz >/tmp/proc 2>&1 Can anyone explain what does '2' and '&1' will do here? Thanks to explain (1 Reply)
Discussion started by: kkalyan
1 Replies

3. Shell Programming and Scripting

PERL : Read an array and write to another array with intial string pattern checks

I have an array and two variables as below, I need to check if $datevar is present in $filename. If so, i need to replace $filename with the values in the array. I need the output inside an ARRAY How can this be done. Any help will be appreciated. Thanks in advance. (2 Replies)
Discussion started by: irudayaraj
2 Replies

4. Filesystems, Disks and Memory

iostat output vs TPC output (array layer)

Hi Guys, I've been having some arguments with my colleagues about one thing. Always my thought was that as as far as disk performance is concern by looking at the output of the iostat command (AIX) you would be able to identify if you have a hot disk and then by moving some files out that disk... (3 Replies)
Discussion started by: arizah
3 Replies

5. Shell Programming and Scripting

Directing only part of a script's output to piped application

Is there a way to keep the output of a script displayed on the terminal when it's run by itself, but suspend part of that output and only have a specific part delivered when it's piped to another script or program? I'm thinking something like the following pseudocode: #!/bin/bash ... (1 Reply)
Discussion started by: trigg
1 Replies

6. Shell Programming and Scripting

Directing awk output to a folder

Dear All I have a simple bash script that creates a folder ( I called it TEMP) in the current directory. The question is: how do I direct the output of my awk script into folder TEMP? Below is my attempt: #!/bin/bash mkdir TEMP echo Enter input file: read infile awk... (4 Replies)
Discussion started by: Ghetz
4 Replies

7. Shell Programming and Scripting

directing output to multiple files

I have a script in which some outputs are directed to one file echo "Load Started" >>${LOGFILE1} If I have another file LOGFILE2 and i want to redirect the output of the above echo command to LOGFILE2 as well with the same command line... how can i do that? Thanks (2 Replies)
Discussion started by: cobroraj
2 Replies

8. Shell Programming and Scripting

Directing program output to a file

When I do time tar cvf /dev/st0 /mnt/junk >> /root/benchlog, I want it to put the output of the time command into the benchlog file, but it put /mnt/junk. How do I get it to put the output of the tar command? (1 Reply)
Discussion started by: jeriryan87
1 Replies

9. Programming

better way than strtok?

Hi all, Right now I'm using this but it seems to be a hack: if (prefix(arg, "mark=")) { for (markid = strtok(args,"="); markid; markid=strtok((char *)NULL, "=")) { basically the user passes "mark=ny" to the command. I want to be able to extract "ny" from that... (7 Replies)
Discussion started by: annie
7 Replies

10. UNIX for Dummies Questions & Answers

directing output

How do I direct the output of an at command at now < backupprogram so that I see something happening. It says the job has been executed but I am not getting the tar file that my backup program on the computer anywhere at all Please help me - I really am a struggling begginer. (1 Reply)
Discussion started by: Cynergetix
1 Replies
Login or Register to Ask a Question

Featured Tech Videos