Programming

hi I read from *.txt file size of my array and then I want to alocate this array. I have this part of code:


typedef struct tmatrix
{
int rows, cols;
int *matrix;
} TMatrix;

int readMatrix(FILE *f, TMatrix *matrix)
{
.
.
.
*matrix=alocateMatrix(rows,cols);
.
.
.
}


int alocateMatrix(r,c)
{
int **array = malloc(r*sizeof(int *));
for (j = 0; j < matice->r; j++)
array[j] = malloc(c*sizeof(int));
return // what would this funcion return? I tried something, but wasnot OK
}



//then I dealocated:
void freeMatrix(TMatrix *matrix)
{
int i;
for (i=0;i<matrix->rows;i++) free(matrix->matrix[i]);
free(matrix->matrix);
free(matrix);
}


If you give some ideas or some other help, I will be lucky
Thanks a lot
Milla

Your allocate and free are imbalanced.

You should have

Code:

TMatix *allocateMatrix(...)

thanks for your idea I'm trying as you wrote, but I think, that I make mistake somewhere.


// I would like to alocate as 2D array
TMatrix alocation(unsigned int row, unsigned int col)
{
TMatrix matrix;

int *mat = malloc(row * col * sizeof(int));
if (mat == NULL)
{
matrix_error();
free(mat);
}

matrix.col = col;
matrix.row = row;
matrix.matrix = mat;

return matrix;
}


void freeMatrix(TMatrix *matrix)
{
free(matrix->matrix);
}


or I tried this:

TMatrix alocation(unsigned int row, unsigned int col)
{
int**array = malloc(row*sizeof(int*));
if(array == NULL)
mistake();
for (int i = 0; i < row; i++)
{
array[i] = malloc(col*sizeof(int));
if (array[i] == NULL)
{
for(int u = 0; u < i; u++)
free(array[u]);
free(array);
mistake();
break;
}
}
}

//dealocation
void freeMatrix(int)
{
for (int i=0; i<row; i++)
{
free(array[i]);
}
free(array);
}

I am agonized, I'm trying all night and I can't make it in order to be OK. I can try write something else...
Milla

I suggest you treat TMatrix as like an object and have functions that refer to it by pointer:

Code:

TMatrix *allocateMatrix(unsigned int row, unsigned int col);
void freeMatrix(TMatrix *matrix);

every where else in the code also uses it by pointer

Code:

main(...)
{
    TMatrix  *m=allocateMatrix(3,3);

    m->thing=whatever;

    doThingWithMatrix(m);

    freeMatrix(m);
}

thx to porter in the end I wrote it like this:

int allocate(TATRIX *matrix, int rows, int cols)
void deallocate (TMATRIX *matrix)