Why does fflush(stdin) fail to work ?


 
Thread Tools Search this Thread
Top Forums Programming Why does fflush(stdin) fail to work ?
# 1  
Old 09-02-2018
Why does fflush(stdin) fail to work ?

Code:
   #include <stdio.h>
    #include <stdlib.h>
    int main(void)
    {
        double number;
        while (scanf("%lf", &number) != 1)
        {   
            printf("Error\n");
           
        }   
        printf("%lf\n", number);
    
    
        return 0;
    }

Look at the above code.

I want the program to stop for me to type something again every time scanf gets an invalid value.


Never ending loop occurs.

I know the first invalid value has not been cleared and is still in the buffer.

So I use fflush(stdin).

Code:
    #include <stdio.h>
    #include <stdlib.h>
    int main(void)
    {
        double number;
        while (scanf("%lf", &number) != 1)
        {   
            printf("Error\n");
            fflush(stdin);
        }   
        printf("%lf\n", number);
    
    
        return 0;
    }


However, it keeps failing to work.

Why am I wrong and how can I modify the code to make that work?
# 2  
Old 09-03-2018
When an invalid character is entered the code goes into an endless loop. It seems this line:
Code:
while (scanf("%lf", &number) != 1)

Is essentially the same as this:
Code:
while(1)

It may check the condition, but in this case that condition will never change. You could that same check in an if statement so it is only checked once. Or use the while(1) in that loop with breaks to jump out of the loop when needed. You might want to look into fgets. The scanf function is great for learning, but can introduce potential security problems. Hope that helps.
# 3  
Old 10-07-2018
It is learnt that scanf will not consume any input if the first byte in input buffer itself does not match the format. So, when an invalid input is entered it will remain in input buffer until some one(getchar() ?) consume it.
# 4  
Old 10-08-2018
A call to fflush() flushes data held in an output stream buffer to the underlying file; it doesn't flush input streams. The return value from scanf() has told you that you don't have a floating point number at the start of the stream, but there is still unmatched data sitting in the buffer. If there wasn't any unmatched data, it would have reported EOF. Another call to scanf() with a different format might successfully match a hexadecimal input value, a character value, or a string value. If you replace the fflush(stdin); with another scanf() to skip over a string value (i.e. scanf("%*s");), you might get what you want... Or, you might not. You haven' t given a very clear description of what sort of input might be entered by your input source.

Note, however, that an EOF or an I/O error condition on the input stream will still leave you with an infinite loop. And, if you're dealing with humans typing input, you need to perform much better error handling.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. IP Networking

Discussion at work, would a router work pluging a cable in wan1 and lan1?

hi all. and sorry for the random question, but this sparkled a raging flame-war at work and i want more points of view situation a router, with linux of some sort, dhcp client requesting for ip in wan1 (as usual with wan ports) dhcp server listening in lan1, and assigning ip (as usual... (9 Replies)
Discussion started by: broli
9 Replies

2. Shell Programming and Scripting

tr command fail to work in script

Hi, I has the following command in the script. This command works fine if I execute on command prompt. If I run the script, this is not working as expected (deleting CR). tr -d "\015" < ${FilePath}/${FileName} > ${FilePath}/${File_Prefix}.csv I could not figure out whats... (6 Replies)
Discussion started by: kavuri
6 Replies

3. UNIX for Dummies Questions & Answers

redirection stdin

Bonjour, Mon application en C sous linux tourne en redirigeant stdin vers un fichier. Exemple; $appli1 <file1. PB: Je voudrais temporairement redonner la main au user sur le clavier. Alors je pensais ajouter system("appli2"); dans appli1. Dans son main() , appli2() fait seulement un... (1 Reply)
Discussion started by: cypleen
1 Replies

4. UNIX for Dummies Questions & Answers

fork and stdin

When a process fork(), the child share the same file descriptors as his father. Thus, they share the same stdin. Quick and dirty exemple below (sorry for the ugly gets() call) : #include <stdio.h> #include <unistd.h> int main() { char buf; if (fork()) { /*parent */ ... (1 Reply)
Discussion started by: milouz
1 Replies

5. UNIX for Dummies Questions & Answers

How to write to stdin of another program (program A -> [stdin]program B)

Hi, Program A: uses pipe() I am able to read the stdout of PROGAM B (stdout got through system() command) into PROGRAM A using: * child -> dup2(fd, STDOUT_FILENO); -> execl("/path/PROGRAM B", "PROGRAM B", NULL); * parent -> char line; -> read(fd, line, 100); Question: ---------... (3 Replies)
Discussion started by: vvaidyan
3 Replies

6. Programming

How to write to stdin of another program (program A -> [stdin]program B)

Hi, Program A: uses pipe() I am able to read the stdout of PROGAM B (stdout got through system() command) into PROGRAM A using: * child -> dup2(fd, STDOUT_FILENO); -> execl("/path/PROGRAM B", "PROGRAM B", NULL); * parent -> char line; -> read(fd, line, 100); Question: ---------... (1 Reply)
Discussion started by: vvaidyan
1 Replies

7. Shell Programming and Scripting

redirect STDIN

can you redirect STDIN with command arguments? I have tried this approach: # ./script -option <argument1> <argument2> 0<$2 # $2: ambiguous redirect Is this possible? (4 Replies)
Discussion started by: prkfriryce
4 Replies

8. UNIX for Dummies Questions & Answers

Script doesn't work, but commands inside work

Howdie everyone... I have a shell script RemoveFiles.sh Inside this file, it only has two commands as below: rm -f ../../reportToday/temp/* rm -f ../../report/* My problem is that when i execute this script, nothing happened. Files remained unremoved. I don't see any error message as it... (2 Replies)
Discussion started by: cheongww
2 Replies

9. Shell Programming and Scripting

redirection stdin

hello all, I need to create a password change utility for a database. I need to gather at the command line the username, password and database sid. I have the program currently doing this. What I would like to do is not have the new password appear on the screen when I do my read command.... (2 Replies)
Discussion started by: whited05
2 Replies

10. Programming

stdin

hi, how does a program know whether some data are available from stdin? I would like to make a program which could read its data from stdin and _if_there_is_nothing_at_stdin_ from a file which name is given as an argument. If there is nothing in stdin and no filename is given as argument,... (2 Replies)
Discussion started by: marquis
2 Replies
Login or Register to Ask a Question