Memory corruption in dynamic array of strings


 
Thread Tools Search this Thread
Top Forums Programming Memory corruption in dynamic array of strings
# 1  
Old 04-30-2018
Memory corruption in dynamic array of strings

I put together a C function to add strings to a dynamic array of strings (mostly for educational purpose to explain pointers to my kid). It works, but sometimes one or two strings in the array becomes corrupted. Running example on 64 bit Ubuntu, gcc ver. 4.8.4

Hope my code is self-explanatory:
Code:
#include <stdio.h>

main(int argc, char *argv[])
{
  char  **list = NULL;
  long  lcnt = 0;
  int   n;

        add_str2list(&list, "1.ABCDEF", &lcnt);
        add_str2list(&list, "2.123456", &lcnt);
        add_str2list(&list, "3.qwerty", &lcnt);
        add_str2list(&list, "4.654321", &lcnt);
        add_str2list(&list, "5.zxc", &lcnt);
        add_str2list(&list, "6.asd", &lcnt);

        printf("list is at %p\n", &list);
        for(n = 0; n < lcnt; n++)
        {
                printf("%i) %p <%s>\n", n, &list[n], list[n]);
        }
        return(0);
}

And here is the culprit, I removed error checking and temp pointer to hold results of the realloc for brevity:
Code:
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

add_str2list(char ***arr, const char *str, long *cnt)
{
  const int     newsz   = sizeof(char *) * (*cnt + 1);
  const long    indx    = *cnt;

        if(*cnt == 0)
                *arr = malloc(newsz);
        else
                **arr = realloc(**arr, newsz);

        arr[0][indx] = strdup(str);
        *cnt = *cnt + 1;
        return(0);
}

Result:
Code:
list is at 0x7ffce9962180
0) 0x124c010 <1.ABCDEF>
1) 0x124c018 <2.123456>
2) 0x124c020 <3.qwerty>
3) 0x124c028 <��$>
4) 0x124c030 <5.zxc>
5) 0x124c038 <6.asd>

The length of those strings does not seem to matter. If I have 2 - 3 strings in the array it is OK, but when I add more than 4 then some strings got corrupted.

When I debug I see it happens when indx is 4 and I assign address of duplicated string to the array: arr[0][indx] = strdup(str);

Any help with finding the bug would be appreciated.

Also, I hate the [0][indx] notation, but could not come up with a better one.
# 2  
Old 04-30-2018
Code:
       if(*cnt == 0)
                *arr = malloc(newsz);
        else
                **arr = realloc(**arr, newsz);

**arr accesses the first element, not the base. Remove one * from these dereferences.
These 2 Users Gave Thanks to Corona688 For This Post:
# 3  
Old 04-30-2018
Quote:
Originally Posted by migurus
Also, I hate the [0][indx] notation, but could not come up with a better one.
(*arr)[0], (*arr)[1], etc.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Solaris

Solaris 10 Shared Memory Corruption with X11

I am having a problem with shared memory corruption. I have two 86 servers running Solaris 10 (150400-06). One of the servers is accessed by a Sun Ray thin client Version 11.1.3.0.2.6. I login into server one from the thin client. I then ssh -X to server two. When a process that contains a... (2 Replies)
Discussion started by: salerno
2 Replies

2. Programming

*** glibc detected *** ./a.out malloc() memory corruption

I am facing a problem of memory corruption. The loop runs for the first time but does not go through the second time. What could be the problem? for(int z=0;z<2;z++) { fp=fopen("poly.dat","r"); /*do something which reads this file into a 2D array*/ fclose(fp); ... (10 Replies)
Discussion started by: dare
10 Replies

3. Programming

*** glibc detected *** : malloc(): memory corruption (fast)

Hi Friends, while executing the below code, am getting *** glibc detected *** ./ok: malloc(): memory corruption (fast) error, please suggest how to solve this issue. #include <stdio.h> #include <string.h> #include <sqlca.h> #include <alloca.h> /* Define constants for VARCHAR... (2 Replies)
Discussion started by: mpjobsrch
2 Replies

4. Programming

*** glibc detected *** ./a.out: malloc(): memory corruption (fast):

*** glibc detected *** ./a.out: malloc(): memory corruption (fast): Posted A minute ago M trying to make multiway tree and dont know what happend when this part of code get executed: 01void ins(NODE *ptr) 02{ 03 //working 04 if(ptr!=NULL) 05 { 06 SNODE *var=NULL; 07 var=(SNODE... (3 Replies)
Discussion started by: exgenome
3 Replies

5. Programming

./match_pattern.out: malloc(): memory corruption: 0x0000000013a11600 ***

Hi All, I have a simple code which does some computation by matching string patterns. In brief: 1. The code reads .dat and .txt files. 2. .dat files are huge text files and .txt files contain some important words. 3. I am just doing strstr to find the patterns. 4. The function returns the... (3 Replies)
Discussion started by: shoaibjameel123
3 Replies

6. Programming

readdir and dynamic array memory corruption

Hi everyone I am developing an utility. At some part of it I read directory entries to a dynamic array: struct list It stores pointers to items: list.entries, which are structures: struct entry If a number of files in a directory is greater then number of elements an array was initially... (11 Replies)
Discussion started by: torbium
11 Replies

7. SCO

SCO openserver Dynamic linker corruption

Hi every body I have a problem like that "Dynamic linker error" message. I can't load many of programs in sco unix openserver 5.0.6. I guess this problem appear after my last effort to install "SCO Development System" package. How can I fix this problem? would you please help me ? (1 Reply)
Discussion started by: javad1_maroofi
1 Replies

8. Programming

Why does this occur? *** glibc detected *** malloc(): memory corruption: 0x10013ff8 ***

there seems not to be error in this segment. In some computers, it can work well. But in others, it will give a failure. why it ocurrs and how to deal with it? in a function: if( *ver == NULL ) { *ver = (vertex *) malloc(sizeof(vertex)); //this line ... (17 Replies)
Discussion started by: cdbug
17 Replies

9. UNIX for Dummies Questions & Answers

'memory corruption' error when using Awk

Hello, everyone. I got the following error when I am using awk to analysis some text file: *** glibc detected *** awk: malloc(): memory corruption: 0x080c67f8 *** ======= Backtrace: ========= /lib/tls/i686/cmov/libc.so.6 /lib/tls/i686/cmov/libc.so.6... (5 Replies)
Discussion started by: kooyee
5 Replies

10. Programming

Creating an array to hold posix thread ids: Only dynamic array works

I am facing a strange error while creating posix threads: Given below are two snippets of code, the first one works whereas the second one gives a garbage value in the output. Snippet 1 This works: -------------- int *threadids; threadids = (int *) malloc (num_threads * sizeof(int)); ... (4 Replies)
Discussion started by: kmehta
4 Replies
Login or Register to Ask a Question