Bus Error: 10...Help please!


 
Thread Tools Search this Thread
Top Forums Programming Bus Error: 10...Help please!
# 1  
Old 02-21-2013
Bus Error: 10...Help please!

Hi all,

I am writing a phonebook program to store names and number using a list. Here is the code for the function which allows the user to enter the name and number (where the error occurs).

Code:
//THIS FUNCTION ADDS A NEW ENTRY TO THE phonebook_list
void insert(void){
    //variables
    int flag=0, length=0, menu=0, i=0, check=0;
    NODE *p,*q, *temp;

    //USER MUST ENTER FIRST NAME ONLY FOR ADDITION TO PHONEBOOK
    printf("\nPlease insert the <First Name> of the entry you would like to add not separated by a space.\n");
    if((temp=(NODE *)malloc(sizeof(NODE))) == (NODE *)NULL)
    {
        printf("Memory could not be allocated! Returning to menu...\n\n");
        return;
    }
    scanf("%s", temp->name);
    //check if name is too long for the array IF IT IS PROMPTS USER TO RE ENTER SHORTER NAME
    while(flag==0)
    {                                    
        length=strlen(temp->name);
        if(length<50){
            for(i=0;i<length;i++)
                temp->name[i] = toupper(temp->name[i]);
            flag=1;
        }else{                    
            printf("\nName is too long! Please re-enter (less than 50 characters).\n");
            scanf("%s", temp->name);
            length=strlen(temp->name);
        }
    }
    //prompt user for telephone number
    printf("%s",temp->number);
    printf("\nPlease insert the telephone number in the following format XXXXXXXXXX.\n");
    scanf("%s", temp->number);
    flag=0;

    //check if number has the correct number of chars
    while(flag==0){
        length=strlen(temp->number);
        if(length==10){
            flag=1;
        }else{
            printf("\nThis is an invalid number. Please re-enter.\n");
            scanf("%s", temp->number);
            length=strlen(temp->number);
        }
    }
    printf("%s", head->name);
    //IF PHONEBOOK IS EMPTY THEN THE HEAD WILL BE A NULL POINTER AND TEMP NODE WILL BE ADDED
    if(head==NULL)
        {
        if((head=(NODE *)malloc(sizeof(NODE))) == (NODE*)NULL)
        {
            printf("Memory could not be allocated!\nReturning to menu...\n\n");
            return;
        }else{    
            strcpy(head->number,temp->number);
            strcpy(head->name,temp->name);
            head->next=tail;
            free(temp);
            printf("Entry successfully added.\n\n");
            return;
        }
    }else{
        //IF NEW NODE IS NOT THE FIRST ENTRY(NODE) IN PHONEBOOK(LIST) WILL LOOP THROUGH PHONEBOOK TO FIND CORRECT SPOT TO ADD
        p=head;
        printf("%s", p->name);
        while(p->next!=NULL)
        {
            //IF NAME IS ALREADY IN PHONEBOOK ERROR IS GIVEN AND PROGRAM RETURNS USER TO MAIN MENU
            if(strcmp(p->name,temp->name)==0)
            {
                printf("This name already exists in phonebook!\nReturning to menu...\n\n");
                return;
            //OTHERWISE THE WHILE LOOP WILL CONTINUE THROUGH LIST UNTIL IT FIND THE ADDITION THAT IS ALPHABETICALLY HIGHER
            //AND WILL ADD THAT NODE IN ITS CORRECT SPOT
            }else if(strcmp(p->name,temp->name)<0)
            {
                printf("\nTRUE\n");
                temp->next=p;
                temp->prev=p->prev;
                p->prev->next=temp;
                p->prev=temp;
                printf("Entry successfully added.\n\n");
                return;
            }
            p=p->next;
        }
        //IF NO NAME IS ALPHABETICALLY HIGHER, THAN IT SHOULD REACH THE LAST NODE AND WILL BE ADDED TO THE END OF THE PHONEBOOK(LIST)
        if(p->next==NULL)
        {
            if((temp=(NODE *)malloc(sizeof(NODE))) == (NODE *)NULL)
            {
                printf("Memory could not be allocated!\nReturning to menu...\n\n");
                return;
            }
            temp->next=tail;
            temp->prev=q;
            q->next=temp;
            free(temp);
            printf("Entry successfully added.\n\n");
            return;
        }
    }
}

The program allows the user to enter the name once, but the second time around, after entering the number I get the error Bus Error: 10. I've been debugging for a few hours here and I've narrowed it down to something having to do with how the number is stored. I'm also not completely sure I understand the function of free(), because when I attempt to free(temp) and them printf("%s",temp->name) right after free(temp), it still prints whatever name had been stored in name originally.

Help please!

Thanks in advance!
Khaaliq

Last edited by Corona688; 02-22-2013 at 01:05 PM..
# 2  
Old 02-22-2013
Where's the code for 'head'? You printf it and it has not been declared or written.
# 3  
Old 02-22-2013
Sorry, this is the rest of the program I have so far, had and tail are global variables declared as NULL.

Code:
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#define NODE struct node

void insert(void);
/*
int delete(void);
int list(void);
*/

NODE *head = NULL;
NODE *tail = NULL;

struct node{
	char name[51];
	char number[11];
	char *next;
	char *prev;
	
};


int main(void){
	//variables
	int menu=0, flag=0;


		//INSTRUCTIONS for user in main program
	printf("Welcome to our phone book.\n\n");

	while(flag==0){
		printf("Press (1) to add a new name and number.\n");
		printf("Press (2) to delete an entry.\n");
		printf("Press (3) to list all entries.\n");
		printf("Press (4) to quit.\n");
		scanf("%d", &menu);	
	

	//switch statement for menu selection -- calls functions to main that perform the functions described in INSTRUCTIONS above
		switch(menu){
	
			case 1:
				insert();
				break;
			
			case 2:
				counter = delete();
				break;
	
			case 3:
				list();
				break;
			
			case 4:
				flag=1;
				break;
			
			default:
				break;
		}
	
	}	
	return 0;
}


Last edited by Corona688; 02-22-2013 at 01:05 PM..
# 4  
Old 02-22-2013
This code is still missing variables and functions, and has numerous compiler errors, so is probably not the code you're actually compiling...

I fixed the blatant errors and stripped out the functions you didn't paste, and it runs without crashing, but without those functions I can't thoroughly test it either.

Your input code isn't working either, probably because you're using scanf, which leaves things stuck in the input buffer whenever things go wrong. fgets() to read entire lines, and sscanf() to process the lines, is a good combination.

Last edited by Corona688; 02-22-2013 at 01:20 PM..
# 5  
Old 02-22-2013
My suggestion would be to build functions to separate your linked list from your input code.

Code:
NODE *create_node(const char *name, const char *num, NODE *prev, NODE *next)
{
        int n;

        NODE *mem=malloc(sizeof(NODE));
        if(mem == NULL) return(NULL);

        strncpy(mem->number, num, sizeof(mem->number));
        mem->number[sizeof(mem->number)-1]='\0';

        strncpy(mem->name, name, sizeof(mem->name));
        mem->name[sizeof(mem->name)-1]='\0';
        for(n=0; mem->name[n] != '\0'; n++)
                mem->name[n]=topper(mem->name[n]);

        mem->next=next;
        mem->prev=prev;
        return(mem);
}

void insert(NODE *node)
{
        node *h=head;

        if(h == NULL) // List is empty, just set it to this node
        {
                head=node;
                return;
        }

        // Loop until the end of the list,
        // but STOP at the last one.  h will not be NULL after this loop.
        while(h -> next != NULL)
        {
                int v=strcmp(node->name, h->name);

                if(v == 0) return; // Reject duplicate
                else if(v < 0)
                {
                        h=h->next;
                        continue;
                }

                // We want to change a <-> b <-> d <-> e into
                // a <-> b <-> c <-> d <-> e
                // We are at node d.

                // point ahead to d
                node->next=h;
                // point back to b
                node->prev=h->prev;

                // make b point ahead to us
                if(h->prev != NULL) h->prev->next=node;
                // make d point back to us
                h->prev=node;

                return;
        }

        if(h->next == NULL) // append to list
        {
                h->next=node;
                node->prev=h;
                return;
        }
}

# 6  
Old 02-22-2013
gdb or dbx 'where' is a stack trace, which for your core file and unstripped, unoptimized code will gladly tell you where it crashed, if it did not say at crash time.

This sort of thing is why they invented OO, containers, PERL, C++ and JAVA !
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Programming

Bus error in tree insertion

Hi, I am new to C++ and unix. I am trying to write a programm for inserting elements into a binary tree. To get the code flow I used few Couts and m facing buss error while insertion. Below is the code snippet. explainations needed. thanks :) #include <iostream.h> struct mytree { int... (1 Reply)
Discussion started by: vineetjoshi
1 Replies

2. Programming

Bus error

Hi everyone, I have a GUI project and when I run it and left in idle state for a long time(there is nothing done, just opened GUI, no more actions),I get bus error after trying to do anything with it. I've tried to build it in debug mode and use gdb, but I don't get any error in debug mode.It... (3 Replies)
Discussion started by: sisi
3 Replies

3. HP-UX

Bus Error

I am getting bus error when i include "#!/bin/ksh". If i remove interpreter then script is working. Can anyone explain this and how can i avoid this error? Operating System is HP-UX B.11.23 U 9000/800 1091834454 (2 Replies)
Discussion started by: anbu23
2 Replies

4. HP-UX

Need help on Bus error(coredump)

Hi all, I am quite weak in C but I need to get some work done. Hope someone can help me out. I keep getting this error when i try to run my C application in my HP-UX 10.20 machine. Some code snippet: Month(DBTime) =====This is a function which will return variable "CutOffTime" to be use... (5 Replies)
Discussion started by: Vision©
5 Replies

5. UNIX for Dummies Questions & Answers

bus error (coredump)

Hi all, I am getting bus error problem in SunOS. Can you please help me out in this regard. Actually, my entire code till the last line has been executed. But after tht i am getting a bus error. Please help me. Thanks in advance. Charu. (4 Replies)
Discussion started by: charu
4 Replies

6. Programming

BUS error

Hi! I've got a program which runs fine under Linux, but I have compiled it to run under SunOS 5.8 in a Sparc computer, and now it sometimes fails with "bus error". Ussing gdb I surfed to the error line, which is *pointer = some_vector; where some_vector is a 16 byte struct (4 integers)... (1 Reply)
Discussion started by: shesatmine
1 Replies

7. UNIX for Advanced & Expert Users

Bus Error(coredump)

Hi, I am using HP-UX. While i try to run the Sqlplus command using the shel script in encounter the following error: <shell script name>: some number Bus Error(coredump) What may be the reason behind this. I read few previous threads in this forum where i found some similar case. There it was... (2 Replies)
Discussion started by: Jayesh
2 Replies

8. UNIX for Dummies Questions & Answers

Bus error(coredump

aix 5.3 ML1 system was functioing well, when suddenly telnet session hung and then I got the following message "Bus error(coredump)" would appreciate if anyone would assist as to what to do next. (3 Replies)
Discussion started by: Student37
3 Replies

9. UNIX for Dummies Questions & Answers

bus error on solaris

Hi there I am running soalris 9 on a sun fire 480r and all of a sudden (today) whenever the users run the command `top` we get the following message `bus error` does anybody have any information on what this is all about and whether there is a routine i can perform to gather more... (3 Replies)
Discussion started by: hcclnoodles
3 Replies

10. UNIX for Dummies Questions & Answers

Bus Error

This may belong in the C Programming forum, but here goes anyway... What would cause a bus error? I searched google for a cause, but came up with some conflicting reports... Could it be caused by disk space? A lot of the pages I found mentioned linking with the incorrect versions of the... (4 Replies)
Discussion started by: LivinFree
4 Replies
Login or Register to Ask a Question