readdir and dynamic array memory corruption


 
Thread Tools Search this Thread
Top Forums Programming readdir and dynamic array memory corruption
# 1  
Old 01-27-2011
readdir and dynamic array memory corruption

Hi everyone

I am developing an utility.
At some part of it I read directory entries to a dynamic array: struct list
It stores pointers to items: list.entries,
which are structures: struct entry

If a number of files in a directory is greater then number of elements an array was initially allocated,
I reallocate memory for this array.
if (c > list_size)

And at this point something strange happens.
Pointers are correct.
While I can successfully allocate memory for new items
list.entries[c] = malloc(sizeof(struct entry));
list.entries[0]->pde->d_name is corrupted at some iteration, but always if list.entries was reallocated.

See the test code provided.

If I do not realloc list.entries everything goes fine.
I played with list_size values.
On Mac OS X (10.4.0 Darwin Kernel Version 10.4.0) memory is corrupted while list.entries[124] is processed.
On Ubuntu Linux 2.6.24-23-xen #1 SMP Wed Apr 1 23:47:10 UTC 2009 x86_64 GNU/Linux while list.entries[196] is processed.
If I don't use readdir and explicitly allocate
list.entries[c]->pde = malloc(sizeof(struct dirent));
memory is not corrupted.

What is wrong?
Where is the problem?
What is the best way to read dir entries to a dynamic array?

Code:
#include <sys/stat.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <dirent.h>
#include <math.h>
#include <pwd.h>
#include <dirent.h>
#include <unistd.h>

int
main (void)
{
    int i, c, ac;
    unsigned int list_size = 10;
    char * fname;
    
    DIR *pdir;
    struct dirent *pde;
    
    
    struct entry {
        struct stat st;
        struct dirent *pde;
    };
    
    struct list {
        int count;
        struct entry **entries;
    } list;
    
    struct entry **ppent;
    pdir = NULL;
    pde = NULL;
    
    pdir = opendir("/usr/bin");
    
    if ((list.entries = malloc(list_size * sizeof(struct entry *))) == NULL)
        return 1;
    
    c = 0;
    ac = 0; /* allocation counter */
    while ((pde = readdir(pdir)) != NULL) {
        if (c > list_size - 1) {
            list_size <<= 1;
            if ((list.entries = realloc(list.entries,
                                    list_size * sizeof(struct entry*))) == NULL) {
                perror("unable to realloc");
                return 1;
            }
            ac++;
        }

        list.entries[c] = malloc(sizeof(struct entry));
        list.entries[c]->pde = pde;

        if (strcmp(list.entries[0]->pde->d_name, ".") != 0) {
            printf("memory corruption. size of array %d items\n", c);
            printf("number of reallocations %d\n", ac);
            return 1;
        }
        
        printf("base address: %p pointer address: %p entry pointer value: %p name: %s\n",
               list.entries, &list.entries[c], list.entries[c], list.entries[c]->pde->d_name);
        c++;
    }
    
    return 0;
}

# 2  
Old 01-27-2011
readdir returns the same pointer every time. So your structure gets filled with copies of whatever your last readdir() gave you.

Store the structure's data, not a pointer to data.

Code:
struct entry {
        struct stat st;
        struct dirent de;
    };

...

list.entries[c]->de = *pde;

...

---------- Post updated at 04:12 PM ---------- Previous update was at 03:59 PM ----------

if (c > list_size - 1) might not be doing what you expect. C has an odd order of operations sometimes. try if(c > (list_size-1))
# 3  
Old 01-27-2011
Hm,
if readdir returned the SAME pointer every time
list.entries[c]->pde would have the SAME value.
BUT they don't.

Of course what you propose solves the problem, thanks you.

BUT WHY and by WHOM heap memory is corrupted after list.entries has been reallocated?
# 4  
Old 01-27-2011
If you read the man pages for readdir you will see that the pointer returned is not guaranteed to be valid beyond the next call. It could be to a location in memory that gets reused, or to a location that is freed, or whatever the implementors feel like.

Essentially, since you are attempting to store the result of readdir into a location that you will use after that call, you are breaking the above rule. So, either use readdir_r or copy the results of the readdir into a "struct dirent" before making the next call (and hope there's no other thread in the application using readdir concurrent to yours....).

If you want to continue using "readdir", you'd change:

Code:
struct entry {
        struct stat st;
        struct dirent pde;
    };

Notice pde is no longer a "struct dirent *".

Then change this line "list.entries[c]->pde = pde;" to this "list.entries[c]->pde = *pde;".

If you want to use readdir_r then you'll need to restructure the while loop a little. I'll leave that to you, but if you know this isn't a multi-threaded program then IMO there's no reason to use readdir_r other than it's safer for the future if your code gets thrown into a multi-threaded environment. Since it's not that much harder to use, I suppose you could just do it right now...but I'll leave it to you to decide.

Last edited by DreamWarrior; 01-27-2011 at 06:30 PM..
# 5  
Old 01-27-2011
if(c > (list_size-1))
does not help. The same result.
# 6  
Old 01-27-2011
UGH...way beaten to the punch, lol...that's what happens when I start typing a response, go into a meeting and come back to finish it up...haha...at least we're all telling you the same thing.
# 7  
Old 01-27-2011
Ok. Thanks to everyone for your comments. Smilie
I understood and have got several good ideas.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Programming

Memory corruption in dynamic array of strings

I put together a C function to add strings to a dynamic array of strings (mostly for educational purpose to explain pointers to my kid). It works, but sometimes one or two strings in the array becomes corrupted. Running example on 64 bit Ubuntu, gcc ver. 4.8.4 Hope my code is self-explanatory: ... (2 Replies)
Discussion started by: migurus
2 Replies

2. Solaris

Solaris 10 Shared Memory Corruption with X11

I am having a problem with shared memory corruption. I have two 86 servers running Solaris 10 (150400-06). One of the servers is accessed by a Sun Ray thin client Version 11.1.3.0.2.6. I login into server one from the thin client. I then ssh -X to server two. When a process that contains a... (2 Replies)
Discussion started by: salerno
2 Replies

3. Programming

*** glibc detected *** ./a.out malloc() memory corruption

I am facing a problem of memory corruption. The loop runs for the first time but does not go through the second time. What could be the problem? for(int z=0;z<2;z++) { fp=fopen("poly.dat","r"); /*do something which reads this file into a 2D array*/ fclose(fp); ... (10 Replies)
Discussion started by: dare
10 Replies

4. Programming

*** glibc detected *** : malloc(): memory corruption (fast)

Hi Friends, while executing the below code, am getting *** glibc detected *** ./ok: malloc(): memory corruption (fast) error, please suggest how to solve this issue. #include <stdio.h> #include <string.h> #include <sqlca.h> #include <alloca.h> /* Define constants for VARCHAR... (2 Replies)
Discussion started by: mpjobsrch
2 Replies

5. Programming

*** glibc detected *** ./a.out: malloc(): memory corruption (fast):

*** glibc detected *** ./a.out: malloc(): memory corruption (fast): Posted A minute ago M trying to make multiway tree and dont know what happend when this part of code get executed: 01void ins(NODE *ptr) 02{ 03 //working 04 if(ptr!=NULL) 05 { 06 SNODE *var=NULL; 07 var=(SNODE... (3 Replies)
Discussion started by: exgenome
3 Replies

6. Programming

./match_pattern.out: malloc(): memory corruption: 0x0000000013a11600 ***

Hi All, I have a simple code which does some computation by matching string patterns. In brief: 1. The code reads .dat and .txt files. 2. .dat files are huge text files and .txt files contain some important words. 3. I am just doing strstr to find the patterns. 4. The function returns the... (3 Replies)
Discussion started by: shoaibjameel123
3 Replies

7. SCO

SCO openserver Dynamic linker corruption

Hi every body I have a problem like that "Dynamic linker error" message. I can't load many of programs in sco unix openserver 5.0.6. I guess this problem appear after my last effort to install "SCO Development System" package. How can I fix this problem? would you please help me ? (1 Reply)
Discussion started by: javad1_maroofi
1 Replies

8. Programming

Why does this occur? *** glibc detected *** malloc(): memory corruption: 0x10013ff8 ***

there seems not to be error in this segment. In some computers, it can work well. But in others, it will give a failure. why it ocurrs and how to deal with it? in a function: if( *ver == NULL ) { *ver = (vertex *) malloc(sizeof(vertex)); //this line ... (17 Replies)
Discussion started by: cdbug
17 Replies

9. UNIX for Dummies Questions & Answers

'memory corruption' error when using Awk

Hello, everyone. I got the following error when I am using awk to analysis some text file: *** glibc detected *** awk: malloc(): memory corruption: 0x080c67f8 *** ======= Backtrace: ========= /lib/tls/i686/cmov/libc.so.6 /lib/tls/i686/cmov/libc.so.6... (5 Replies)
Discussion started by: kooyee
5 Replies

10. Programming

Creating an array to hold posix thread ids: Only dynamic array works

I am facing a strange error while creating posix threads: Given below are two snippets of code, the first one works whereas the second one gives a garbage value in the output. Snippet 1 This works: -------------- int *threadids; threadids = (int *) malloc (num_threads * sizeof(int)); ... (4 Replies)
Discussion started by: kmehta
4 Replies
Login or Register to Ask a Question