Segment Violation


 
Thread Tools Search this Thread
Top Forums Programming Segment Violation
# 1  
Old 05-28-2010
Segment Violation

Hi to all.

I'm reciving a "Segment violation" error from this code and I don't know why.

Code:
void insertAtEnd(NodeType *pList) {

    char element;

    printf("Introduce a element: \n");
    setbuf(stdin, NULL);
    scanf("%c", &element);

    //Find the end of the list;
    while (pList->nextNode != NULL) {
        pList = pList->nextNode;
    }

    //Makes a new node.
    NodeType *newNode = (NodeType *) malloc(sizeof(NodeType));
    newNode->caracter = element;
    newNode->nextNode = NULL;
    //Links the new node.
    pList->nextNode = newNode;
}


Thanks for reading.
# 2  
Old 05-28-2010
There are a no. of things that could be wrong...post the code that calls this function as well as the typedef of the struct NodeType.
# 3  
Old 05-28-2010
The code thats calls this function is quite simple.

Code:
typedef struct node {

    char caracter;
    struct node *nextNode;
} NodeTipe;

int main(int argc, char argv[]) {
NodeTipe *pList; insertAtEnd(pList);
}

# 4  
Old 05-28-2010
The value of pList in main is undefined and probably pointing off into hyperspace somewhere. The instant you try to use it you're trying to access memory you never allocated.

Your logic is also a touch incorrect. An empty list has no memory allocated to it at all in this scheme, hence can't be modified without modifying the base pointer itself, which your function cannot do, being passed only a copy of it.

Pass a pointer to the pointer so it can modify it, check for the special case of creating the first node, and make sure you set the value of the empty list to NULL.

Code:
void insertAtEnd(NodeType **ppList) {
    NodeType *plist=(*ppList);
    char element;

    printf("Introduce a element: \n");
    setbuf(stdin, NULL);
    scanf("%c", &element);

    //Makes a new node.
    NodeType *newNode = (NodeType *) malloc(sizeof(NodeType));
    newNode->caracter = element;
    newNode->nextNode = NULL;

    // Empty list.
    if(plist == NULL)
    {
          // Set the base of the list to the new node
          (*ppList)=plist;
          return;
    }


    //Find the end of the list;
    while (pList->nextNode != NULL) {
        pList = pList->nextNode;
    }

    //Links the new node.
    pList->nextNode = newNode;
}

int main(int argc, char argv[]) {

    NodeTipe *pList=NULL;
    insertAtEnd(&pList); 
}

# 5  
Old 05-28-2010
Code:
typedef struct node
{
    char caracter;
    struct node *nextNode;
} NodeTipe;

int main(int argc, char argv[])
{
     NodeTipe *pList;
     // you need code here to create the initial Node for the linked list and then start inserting to it
     insertAtEnd(pList);
}

also there's a big difference between NodeTipe and NodeType
Login or Register to Ask a Question

Previous Thread | Next Thread

9 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

[Solved] Trimming out segment

I have a file with a combination of binary characters and words, and need to trim out the segment i.e. SleeperThreadAborting {{username::RAB2002}} {{scriptname::scs_get_pending_by_loc}} and put the lists into a text file. Luckily, the segment I am looking for i.e. has readable words ... (8 Replies)
Discussion started by: Daniel Gate
8 Replies

2. Programming

why segment fault,

I always get segment fault, why? can sb help me and modify it, I have spend on much time on #include <pthread.h> #include <stdio.h> #include <stdlib.h> #include <sys/time.h> #include <string.h> #define MAX 10 pthread_t thread; void *thread1() { int *a; int i, n; ... (1 Reply)
Discussion started by: yanglei_fage
1 Replies

3. Programming

Data segment or Text segment

Hi, Whether the following piece of code is placed in the read-only memory of code (text) segment or data segment? char *a = "Hello"; I am getting two different answers while searching in google :( that's why the confusion is (7 Replies)
Discussion started by: royalibrahim
7 Replies

4. Programming

How can I know where the segment of memory is all Zero?

I mean, I malloc a segment of memory, maybe 1k maybe 20bytes.. assume the pointer is pMem How can I know the content pMem refered is all Zero or \0 . I know memcmp but the second parameter should another memory address... thanx (4 Replies)
Discussion started by: macroideal
4 Replies

5. Shell Programming and Scripting

How to change a segment in a particular position

I need help in removing a leading zero in a particular position. For eg.: XYZ*04567472*0099*020091231*0123*0.12 In the above line, I want to replace "*0123" with "123" and "0.12" with ".12". I want to remove the leading zero only in position number 4 and 5 (the bolded segments) I was able... (10 Replies)
Discussion started by: ananthmm
10 Replies

6. UNIX for Dummies Questions & Answers

code segment

how do i close a do code segment? od? (1 Reply)
Discussion started by: trob
1 Replies

7. Shell Programming and Scripting

Cutting segment of a string

Hi, I am using bash. My question concerns cutting out segments of a string. Given the following filename: S2002254132542.L1A_MLAC.x.hdf I have been able to successfully separate the string at the periods (.): $ L1A_FILE=S2002254132542.L1A_MLAC.x.hdf $ BASE=$(echo $L1A_FILE | awk -F.... (5 Replies)
Discussion started by: msb65
5 Replies

8. Shell Programming and Scripting

extract segment

Hey all, could someone please direct me on how to extract a segment from a file between two tags? Thanks! (1 Reply)
Discussion started by: mpang_
1 Replies

9. Programming

Segment Fault

When run it, segment fault. What is wrong? #include <stdio.h> #include <stdlib.h> const int max =20; //**************************************************** // Input Matrix //**************************************************** void inMatrixAA(int *AA, int row, int col)... (9 Replies)
Discussion started by: zhshqzyc
9 Replies
Login or Register to Ask a Question