Noob trying to improve

Tags
beginners, faq, regexp, sed, solved

 
Thread Tools Search this Thread
# 8  
Old 12-26-2016
This may serve as a starting point (file contains the web content downloaded before):

Code:
awk '/href.*view more/ {sub (/^[^<]*<a href="/, "curl -s https://www.dotmed.com")
                        sub (/">.*$/, "")
                        print}
' file | sh | awk '
/<\/*title>/ ||
/id=\"price/ ||
/id=\"condition/ ||
/id=\"date_updated/     {gsub (/<[^>]*>/, _)
                         if (length) print
                        }
' 

 
Used GE Lunar DPX Bone Densitometer For Sale - DOTmed Listing #2299124: 
			Price:$20,000.00 USD [convert]
			Condition:Used - Excellent
			Date updated:December  18, 2016
 
New OSTEOSYS DEXXUM T Bone Densitometer For Sale - DOTmed Listing #2299556: 
			Price:$19,990.00 USD [convert]
			Condition:New
			Date updated:December  09, 2016
 
Used HOLOGIC DISCOVERY C Bone Densitometer For Sale - DOTmed Listing #1184884: 
			Price:$19,000.00 USD [convert]
			Condition:Used - Good
			Date updated:December  07, 2016
.
.
.


Last edited by RudiC; 12-26-2016 at 02:41 PM..
This User Gave Thanks to RudiC For This Post:
Ardzii (12-26-2016)
# 9  
Old 12-26-2016
Hey RudiC!

Thanks for that!SmilieSmilie It looks really great! I have got a lot of work ahead to understand your lines thoughSmilieSmilieSmilie

I'll let you know once I'm able to get the results as you did!

Best!

Ardzii
# 10  
Old 12-26-2016
A wee bit improved so you can add the search words at the end as parameters separated by pipe symbols:


Code:
curl -s "https://www.dotmed.com/equipment/2/92/1209/all/offset/0/all?key=&limit=20&price_sort=descending&cond=all&continent_filter=0&zip=&distance=5&att_1=0&att_row_num=1&additionalkeywords=&country=ES" |
awk '/href.*view more/ {sub (/^[^<]*<a href="/, "curl -s https://www.dotmed.com")
                        sub (/">.*$/, "")
                        print}
' |
sh |
awk '
match ($0, "id=\"(" IDS ")\"")  ||
/<\/*title>/    {gsub (/<[^>]*>/, _)
                 print
                }
' IDS="price|condition|date_updated" 

Used GE Lunar DPX Bone Densitometer For Sale - DOTmed Listing #2299124: 
			Price:$20,000.00 USD [convert]
			Condition:Used - Excellent
			Date updated:December  18, 2016
 
New OSTEOSYS DEXXUM T Bone Densitometer For Sale - DOTmed Listing #2299556: 
			Price:$19,990.00 USD [convert]
			Condition:New
			Date updated:December  09, 2016
 
Used HOLOGIC DISCOVERY C Bone Densitometer For Sale - DOTmed Listing #1184884: 
			Price:$19,000.00 USD [convert]
			Condition:Used - Good
			Date updated:December  07, 2016
.
.
.


Last edited by RudiC; 12-26-2016 at 03:01 PM..
This User Gave Thanks to RudiC For This Post:
Ardzii (12-26-2016)
# 11  
Old 12-26-2016
OK! I got most of it... SmilieSmilieSmilie

For the first step you get the listing:
Code:
curl -s "https://www.dotmed.com/equipment/2/92/1209/all/offset/0/all?key=&limit=5&price_sort=descending&cond=all&continent_filter=0&zip=&distance=5&att_1=0&att_row_num=1&additionalkeywords=&country=ES" | awk '/href.*view more/ {sub (/^[^<]*<a href="/, "curl -s https://www.dotmed.com")
                        sub (/">.*$/, "")
                        print}

The second one you created a variable IDS that looks for the price, condition and date_updated and print the results.
Code:
curl -s "https://www.dotmed.com/equipment/2/92/1209/all/offset/0/all?key=&limit=20&price_sort=descending&cond=all&continent_filter=0&zip=&distance=5&att_1=0&att_row_num=1&additionalkeywords=&country=ES" | awk '/href.*view more/ {sub (/^[^<]*<a href="/, "curl -s https://www.dotmed.com")                         sub (/">.*$/, "")                         print} ' | sh | awk ' match ($0, "id=\"(" IDS ")\"")  || /<\/*title>/    {gsub (/<[^>]*>/, _)                  print                 } ' IDS="price|condition|date_updated"

I added a >> "/Users/myuser/Desktop/test.csv" to get the print exported to a CSV file.
I've been looking around for the past hour now and I can't seem to find how I can put each listing in a line with a ";" dividing the "description" (or "title") and the price, condition and date_updated instead of having 4 lines create per entry.

I know that something has to change between the "||" after the match and before the print, but I have no idea where and how...
Could you help me once more?SmilieSmilieSmilie

Thanks as usual!!SmilieSmilieSmilieSmilieSmilieSmilie

Ardzii
# 12  
Old 12-27-2016
If you'd accept a trailing comma (removal would need additional measures), set the output record separator to comma: ORS=",". As ALL info would come in a long line, then, we need to find out how to separate a single machine's data from the next. I used the begin of a HTML doc for this. Try adding the following to your script
Code:
.
.
.
/^<!DOCTYPE/    {printf RS
                }
END             {printf RS
                }
' IDS="price|condition|date_updated|in_stock" ORS=","

Please be aware that any comma INSIDE fields will lead to misinterpretation if the result is read somewhere else based on comma separated fields.
This User Gave Thanks to RudiC For This Post:
Ardzii (12-27-2016)
# 13  
Old 12-27-2016
Quote:
Originally Posted by RudiC
If you'd accept a trailing comma (removal would need additional measures), set the output record separator to comma: ORS=",". As ALL info would come in a long line, then, we need to find out how to separate a single machine's data from the next. I used the begin of a HTML doc for this. Try adding the following to your script
Code:
.
.
.
/^<!DOCTYPE/    {printf RS
                }
END             {printf RS
                }
' IDS="price|condition|date_updated|in_stock" ORS=","

Please be aware that any comma INSIDE fields will lead to misinterpretation if the result is read somewhere else based on comma separated fields.
Hey RubiC!

Thanks a lot for your followup! I'm sorry but I think that you're too advanced for me... SmilieSmilieSmilieSmilie
I have no idea on how to combine bash commands with HTML and where to insert the new code into my script.SmilieSmilieSmilie

For now I have that:
Code:
curl -s "https://www.dotmed.com/equipment/2/92/1209/all/offset/0/all?key=&limit=20&price_sort=descending&cond=all&continent_filter=0&zip=&distance=5&att_1=0&att_row_num=1&additionalkeywords=&country=ES" | 
awk '
/href.*view more/ {sub (/^[^<]*<a href="/, "curl -s https://www.dotmed.com")
                         sub (/">.*$/, "")
                         print} ' | 
sh | 
awk ' match ($0, "id=\"(" IDS ")\"")  ||
 /<\/*title>/    {gsub (/<[^>]*>/, _)
                  print >> "/Users/MyUser/Desktop/test.txt"
                 } ' IDS="price|condition|date_updated"

I tried already to replace the portion:
Code:
/<\/*title>/    {gsub (/<[^>]*>/, _)
                  print >> "/Users/MyUser/Desktop/test.txt"
                 } ' IDS="price|condition|date_updated"

with your new code:
Code:
/^<!DOCTYPE/    {printf RS
                 }
END             {printf RS
                 } ' IDS="price|condition|date_updated|in_stock" ORS=","

But it yielded a blanc "page" on my terminal. Smilie Plus I'm not sure at all on how to export to a file?
Again, I'm truly sorry to be such a burden and would totally understand if you weren't able to help me further! SmilieSmilieSmilie

Oh! And one last thing: Having a coma is perfect, I'll try to deal with the "iner" comas afterwards. Using Excel, I can still fine tune that pretty easily I guess...

Thanks anyways and all the best,

Ardzii

Last edited by RudiC; 12-27-2016 at 11:18 AM.. Reason: Corrected ICODE tags.
# 14  
Old 12-27-2016
Well, I said "add", not "replace". Add the lines after the print statement.

EDIT: And, yes, replace this line:
Code:
                 } ' IDS="price|condition|date_updated"


Last edited by RudiC; 12-27-2016 at 11:56 AM..

|
Thread Tools Search this Thread
Search this Thread:
Advanced Search

More UNIX and Linux Forum Topics You Might Find Helpful
Improve script jiam912 Shell Programming and Scripting 23 11-28-2016 12:31 PM
Improve the performance of my C++ code yifangt Programming 11 01-16-2015 11:01 AM
How to improve an script? jiam912 Shell Programming and Scripting 4 12-15-2014 01:45 PM
Improve sftp script arrals_vl Shell Programming and Scripting 10 11-14-2014 07:54 AM
How to improve the performance of this script? vikatakavi UNIX for Dummies Questions & Answers 5 10-18-2013 07:08 PM
Help with improve the performance of grep cpp_beginner Programming 1 09-21-2011 12:32 AM
improve sulog sparcguy AIX 0 04-18-2011 01:10 AM
Want to improve the performance of script poweroflinux Shell Programming and Scripting 6 02-16-2011 04:40 PM
How to improve throughput? andrewust IP Networking 3 11-13-2010 03:20 PM
Any way to improve performance of this script sirababu Shell Programming and Scripting 3 03-19-2009 01:06 AM
Improve Performance mazhar99 UNIX for Dummies Questions & Answers 2 08-19-2008 01:52 PM
How to improve grep performance... pooga17 Shell Programming and Scripting 2 02-13-2008 07:34 AM
improve this? blowtorch Shell Programming and Scripting 11 08-04-2005 04:53 AM
improve performance by using ls better than find Nicol UNIX for Advanced & Expert Users 3 03-05-2004 08:53 AM
Can I improve this script ??? Cameron Shell Programming and Scripting 11 10-22-2002 09:39 PM