regular expression help


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting regular expression help
# 1  
Old 04-14-2009
regular expression help

Hi, I have a small script which uses egrep and a set of regexes to validate an IP address, however, i want to make it so that if somebody puts a leading space in front of the IP address to be validated it will fail, so this is my script

Code:
#!/bin/bash

#function
ip_checker() {

result=$( echo $1 | egrep "(^[01]?[0-9][0-9]?|2[0-4][0-9]|25[0-4])\.([01]?[0-9][0-9]?|2[0-4][0-9]|25[0-4])\.([01]?[0-9][0-9]?|2[0-4]
[0-9]|25[0-4])\.([01]?[0-9][0-9]?|2[0-4][0-9]|25[0-4]$)" )

if [ -z $result ]; then
echo " "
echo "That IP is invalid"
exit 1
else
echo "IP looks fine"
fi
}


IP=" 192.168.1.2"
ip_checker $IP

notice the space before the IP that I have set in $IP variable (in bold above)

this returns

Code:
# ./test.sh
IP looks fine

its the same however many spaces i put in front of the IP, however, if i put a different character in front of the IP e.g

Code:
IP="x192.168.1.2"
ip_checker $IP

it fails as expected

Code:
# ./test.sh
That IP is invalid

its just those pesky spaces .. as you can see I have entered a ^ in the regex at the beginning but that seems to be ignored

is there something im doing wrong here ?
# 2  
Old 04-14-2009
No, it's not ignored. In fact, any spaces you put before the IP address are stripped away with the echo in
Code:
result=$( echo $1 | egrep "(^[01]?[0-9][0-9]?|2[0-4][0-9]|25[0-4])\.([01]?[0-9][0-9]?|2[0-4][0-9]|25[0-4])\.([01]?[0-9][0-9]?|2[0-4]
[0-9]|25[0-4])\.([01]?[0-9][0-9]?|2[0-4][0-9]|25[0-4]$)" )

, most probably even sooner, with the call to ip_checker
Put double quotes around the $1/$IP and your script will fail as expected.

Just as a side node: most UNIX shells (all that I know) use spaces as argument seperators and strip away any that aren't explicitly literal (using quotes). There's usually no need to check for them manually.
# 3  
Old 04-14-2009
Also try changing
Quote:
... egrep "(^[01] ...
to

Code:
... egrep "^([01] ...

to have the space in the beginning recognized as not allowed.
# 4  
Old 04-14-2009
if you are able to use Perl and install module Data::Validate::IP, it makes your life much easier
Code:
#!/usr/bin/perl

use Data::Validate::IP qw(is_ipv4);
$ip = "192.168.0.1";
if(is_ipv4($ip)){
        print "$ip is valid ip address\n";
}else{
        print "$ip is an ip address\n";
}
$ip = "1.1.257.2";
if(is_ipv4($ip)){
        print "$ip is valid ip address\n";
}else{
        print "$ip is Not an ip address\n";
}

output
Code:
# ./test.pl
192.168.0.1 is valid ip address
1.1.257.2 is Not an ip address

# 5  
Old 04-14-2009
thats great thanks guys
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Regular expression

I would like to extract "JDBC Thin Client" from (PROGRAM=JDBC Thin Client); and "C:\Python26\python.exe" from (PROGRAM=C:\Python26\python.exe); "txm_v_awsrf_db.pr" from (PROGRAM=txm_v_awsrf_db.pr). if input line like "(PROGRAM=)", it return unknown. Would you help suggest a regular... (4 Replies)
Discussion started by: cstsang
4 Replies

2. Shell Programming and Scripting

Regular expression

Can someone please explain me what does this mean? ^{1,50}$ (1 Reply)
Discussion started by: Anupam_Halder
1 Replies

3. UNIX for Dummies Questions & Answers

Regular expression help

Hi, I am quite knew to scripting and I am trying to get a regular expression to work to check that a user enters a valid version number such as 1 or 1.1 or 12.3 etc. I dont seem to be able to get it to work as it picks up versions such as 1.......2. I only want it to work with a single dot.... (12 Replies)
Discussion started by: frodo61
12 Replies

4. UNIX for Advanced & Expert Users

sed: -e expression #1, char 0: no previous regular expression

Hello All, I'm trying to extract the lines between two consecutive elements of an array from a file. My array looks like: problem_arr=(PRS111 PRS213 PRS234) j=0 while } ] do k=`expr $j + 1` sed -n "/${problem_arr}/,/${problem_arr}/p" problemid.txt ---some operation goes... (11 Replies)
Discussion started by: InduInduIndu
11 Replies

5. Programming

Perl: How to read from a file, do regular expression and then replace the found regular expression

Hi all, How am I read a file, find the match regular expression and overwrite to the same files. open DESTINATION_FILE, "<tmptravl.dat" or die "tmptravl.dat"; open NEW_DESTINATION_FILE, ">new_tmptravl.dat" or die "new_tmptravl.dat"; while (<DESTINATION_FILE>) { # print... (1 Reply)
Discussion started by: jessy83
1 Replies

6. Shell Programming and Scripting

Integer expression expected: with regular expression

CA_RELEASE has a value of 6. I need to check if that this is a numeric value. if not error. source $CA_VERSION_DATA if * ] then echo "CA_RELESE $CA_RELEASE is invalid" exit -1 fi + source /etc/ncgl/ca_version_data ++ CA_PRODUCT_ID=samxts ++ CA_RELEASE=6 ++ CA_WEEK_NO=7 ++... (3 Replies)
Discussion started by: ketkee1985
3 Replies

7. UNIX for Dummies Questions & Answers

ls with regular expression

I currently list and sort all the files in a directory which begin with an Upper Case C and end with the extension '#finished#'. Here is the command I use: ls -tr $currentDir/*.#finished# what i need to do now is list all the files in a directory that begin with upper case C and end... (3 Replies)
Discussion started by: rkgudde
3 Replies

8. Linux

Regular expression to extract "y" from "abc/x.y.z" .... i need regular expression

Regular expression to extract "y" from "abc/x.y.z" (2 Replies)
Discussion started by: rag84dec
2 Replies

9. Programming

What does the regular expression ['(^[^~]+~).*'] mean?

What does the regular expression +~).*'] mean while using it with regexec.When the string "RCHNUSNT35C~rs07/ASM-RS07" is used with the regular expression +~).*'] regexec gives an error. I know what regexec does,but i do not understand what this expression means wrt to this string... any help... (2 Replies)
Discussion started by: anupamar
2 Replies

10. Shell Programming and Scripting

Regular Expression + Aritmetical Expression

Is it possible to combine a regular expression with a aritmetical expression? For example, taking a 8-numbers caracter sequece and casting each output of a grep, comparing to a constant. THX! (2 Replies)
Discussion started by: Z0mby
2 Replies
Login or Register to Ask a Question