Visit Our UNIX and Linux User Community


Perl Error Handling Problem

 
Thread Tools Search this Thread
Special Forums UNIX and Linux Applications Infrastructure Monitoring Perl Error Handling Problem
# 1  
Old 05-26-2010
Perl Error Handling Problem

I can get this working, but if something is down I get an error and the script does not move on. I can not get the "else" function working. What might I be doing wrong?

PHP Code:
use SNMP::Simple
my 
%ios = ();
$list="list.list";
open(DAT$list) || die("Can't Open List");
@
raw_data=<DAT>;
close(DAT);
foreach 
$dest (@raw_data)
{
chomp($dest);
my $s SNMP::Simple->new(
DestHost => $dest,
Community => 'string',
Version => 1,
);
if 
(
$data{name} = $s->get('sysName'))
(
$data{sys} = $s->get('sysDescr'))
(
$data{rom} = $s->get('romId')) {
push @device_data, \%ios;
#print "$data{name} - $data{sys} - $data{rom}\n";
$file "iosfull.txt";
open(OUT">>$file");
print 
OUT "$data{name} - $data{sys} - $data{rom}\n";
close(OUT);
} else {
print 
$s did not answer\n";
next;

This is the error I am getting.
PHP Code:
syntax error at ios.pl line 16near ")
       (" 
# 2  
Old 05-26-2010
There are a couple things very wrong here (marked in red):
Code:
use strict; # These 2 lines should be in every Perl program
use warnings;

use SNMP::Simple; #Missing semicolon

my %ios = ();
$list = "list.list";
open( DAT, $list ) || die("Can't Open List");
@raw_data = <DAT>;
close(DAT);
foreach $dest (@raw_data) {
    chomp($dest);
    my $s = SNMP::Simple->new(
        DestHost  => $dest,
        Community => 'string',
        Version   => 1,
    );
    if ( $data{name} = $s->get('sysName') ) #What exactly are you trying to do here??
       ( $data{sys} = $s->get('sysDescr') )
       ( $data{rom} = $s->get('romId') ){
              push @device_data, %ios;

                #print "$data{name} - $data{sys} - $data{rom}\n";
                $file = "iosfull.txt";
                open( OUT, ">>$file" );
                print OUT "$data{name} - $data{sys} - $data{rom}\n";
                close(OUT);
        } else {
              print "$s did not answern "; # Missing opening quotes
              next;
        }
} # Missing closing bracket

Hint: when you've finished writing a program, check it with perl -c first. Also, Perl::Tidy (and the command line utility perltidy) help to improve the readability of your programs a lot, and will help with the visual identification of syntax errors.
This User Gave Thanks to pludi For This Post:
# 3  
Old 05-27-2010
PHP Code:
    if ( $data{name} = $s->get('sysName') ) #What exactly are you trying to do here??
       
$data{sys} = $s->get('sysDescr') )
       ( 
$data{rom} = $s->get('romId') ){ 
I am trying to loop through a list of devices and get 3 snmp variables. If a device in my list is down I want to print "$s did not answer" and move on.
# 4  
Old 05-27-2010
I still don't catch your logic. Do you want to check if all 3 get() calls returned a value? If so, rewrite it to
Code:
    if ( defined ( $data{name} = $s->get('sysName') ) &&
         defined ( $data{sys} = $s->get('sysDescr') ) &&
         defined ( $data{rom} = $s->get('romId') ) )

Otherwise, please describe the logic you're thinking of in these 3 specific lines.
# 5  
Old 05-27-2010
Quote:
Originally Posted by pludi
I still don't catch your logic. Do you want to check if all 3 get() calls returned a value? If so, rewrite it to
Code:
    if ( defined ( $data{name} = $s->get('sysName') ) &&
         defined ( $data{sys} = $s->get('sysDescr') ) &&
         defined ( $data{rom} = $s->get('romId') ) )

Otherwise, please describe the logic you're thinking of in these 3 specific lines.

Ok,

I have a list of devices. Device A, Device B, etc.

I am trying to get the snmp variables from each device. Name, IOS and ROM. All 3 variables will responsed if the device is online.

If a device is not responding, then skip and move on to the next device on the list.

Name -> IOS -> ROM
Name -> IOS -> ROM
No responsing
Name -> IOS -> ROM
etc.

Previous Thread | Next Thread
Test Your Knowledge in Computers #263
Difficulty: Easy
Alan Turing played a key role in cracking intercepted coded messages that enabled the Allies to defeat the Nazis in many crucial engagements, including the Battle of the Atlantic, and in so doing helped win and end the war.
True or False?

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Perl file handling error

Hi, I am reading and file and writting each word to other file. where I have used array to store the data. I am getting below error as "Use of uninitialized value in concatenation (.) or string at customize_split_raw.pl line 51, <IN_FILE> " Where my line 51 code is 50 foreach... (8 Replies)
Discussion started by: Beginer123
8 Replies

2. UNIX for Dummies Questions & Answers

Error Handling using ISQL for oracle connection in Perl

Hi Am making connection to oracle using ISQL as shown in the code. This code is just a minor part of a big code. I want to capture the error if the password/login is wrong or if connection is not made. I need to capture the error code also. Also, If such an error occurs, i need to exit out... (4 Replies)
Discussion started by: irudayaraj
4 Replies

3. Shell Programming and Scripting

PERL error handling

I have a PERL command line embedded in a UNIX script. The script doesn't handle errors coming out of this command. I'm processing large files and occassionally I run out of disk space and end up with half a file. perl -p -e 's/\n/\r\n/g' < TR_TMP_$4 > $4 How do I handle errors coming out... (1 Reply)
Discussion started by: OTChancy
1 Replies

4. Programming

Perl help for file handling

$# some text $$ some text $@ some text $$. some text Mg1 some text Mg2 some text . . . Mg10 some text The above 10 lines are to be extracted except the lines starting from $#,$$.,... (4 Replies)
Discussion started by: baig.abdul
4 Replies

5. Shell Programming and Scripting

Handling Parameters in Perl

Hi All, I'm pretty new to the forum and also to UNIX. I have a requirement for which I need some help. I have a script (example.script) where I get user inputs using the read command. I would need to pass the read-fetched input to a perl command (explained below) in my script. The part which... (3 Replies)
Discussion started by: bharath.gct
3 Replies

6. Shell Programming and Scripting

Perl and Sockets - Error handling

Hello all, I have created a Perl script that tries to open connections to various systems on different ports in order to see if the machines are reachable, the ports are open, etc. There appears to be a difference between Solaris (10) and Linux (RH/Oracle and Ubuntu) in the status or error it... (4 Replies)
Discussion started by: Hollinch
4 Replies

7. Shell Programming and Scripting

special characters handling in perl

Hi, Here is my piece of code-- sub per_user_qna_detail { for($index=0;$index<@records;$index++) { if($records =~ m/^(.*)\s*Morocco.*Entering\s*Module::authenticate/) { printf "INSIDE per_user_qna_detail on LINE NO $index\n"; $Time_Stamp = $1;... (0 Replies)
Discussion started by: namishtiwari
0 Replies

8. Programming

XML Handling in Perl

Hi there, I'm newby in perl and XML. I can read and parse Xml with XML-Node upper XML::Parser, but how can I create XML tags and pack my individual data in it then send through socket. PLZ lead me :) Thanks in Advance. (1 Reply)
Discussion started by: Zaxon
1 Replies

9. Shell Programming and Scripting

Signal handling in Perl

Guys, I'm doing signal handling in Perl. I'm trying to catch ^C signal inside the script. There two scripts : one shell script and one perl script. The shell script calls the perl script. For e.g. shell script a.sh and perl scipt sig.pl. Shell script a.sh looks something like this :... (6 Replies)
Discussion started by: obelix
6 Replies

10. UNIX for Dummies Questions & Answers

file handling problem in perl......

Hi, I am opening a file......then i am wrting some data into it......and i am reopening the file again but ......i get a error cannot open file....... $::file= "\adder\testfile.txt" open(TEST1,$::file); some write operation close(TEST1) open(TEST1,$::file) 'I GET A ERROR CAN OPEN... (2 Replies)
Discussion started by: vivekshankar
2 Replies

Featured Tech Videos