Script performs the right task but fails against check


Login or Register for Dates, Times and to Reply

 
Thread Tools Search this Thread
# 1  
Script performs the right task but fails against check

Use and complete the template provided. The entire template must be completed. If you don't, your post may be deleted!

1. The problem statement, all variables and given/known data:
  1. Write a script checkFiles.sh that takes an arbitrary number of file paths from the command line and carries out the same analysis on each one, printing a line containing the file name, a colon, a blank, and then one of the two output strings from Stage 1, for each file in the command line.
    For example,
    Code:
    ./checkFiles.sh /usr/share/dict/words fileType.sh /home/cs252/Assignments/ftpAsst/d3.dat /usr/share/dict/words: Something else fileType.sh: Something else /home/cs252/Assignments/ftpAsst/d3.dat: Windows ASCII

  2. When you believe that you have your script working, run
    Code:
    ~cs252/bin/scriptAsst.pl   again to check your work.



2. Relevant commands, code, scripts, algorithms:
I have another script called fileType.sh

Code:
#!/bin/sh                                                                       
file="$1"
case $(file "$file") in
    *"ASCII text, with CRLF line terminators" )
        echo "Windows ASCII"
    ;;
    * )
        echo "Something else"
    ;;
esac

3. The attempts at a solution (include all code and scripts):

Code:
#!/bin/bash                                                                     
for i  in "$@"; do

    echo $i":" "`sh ./fileType.sh`"

done

I used the other code for the previous step. So for the new part, the script I wrote appears to be working, however when I test it against the teacher's checker I end up with:

Code:
Failed when running: ./checkFiles.sh 'aardvark.cpp' 'bongo.dat' 'cat.dog.bak'

I used the tag for urgent since this is due today, but if it's too late for me, I'd still love to understand this. I may fail the course (pass or fail so one fail means total fail) but that doesn't stop me from learning. Thanks ahead of time to anyone reading this!

Oh and the forum won't let me link the course since I don't have 5 post.

4. Complete Name of School (University), City (State), Country, Name of Professor, and Course Number (Link to Course):
Old Dominion University, Norfolk VA USA, Professor Steven Zeil, CS252

Note: Without school/professor/course information, you will be banned if you post here! You must complete the entire template (not just parts of it).

Last edited by Ezraek; 12-05-2014 at 03:55 PM..
# 2  
When fileType.sh is working correctly for you, do you invoke it with any operands?

When you invoke fileType.sh in checkFiles.sh, what operands to you supply?
# 3  
You forgot to pass the file name to fileType.sh!
I would store the `command` in a variable first, then refer the variable in the echo statement.
# 4  
Tried editing the post to state I fixed the second script by adding $1 to the fileType.sh that I attempt to run. Still failing some other tests though.

fileType.sh does work properly. I had to run that for the first part of the assignment and the checker approved it but this second piece is coming back as failing some other files jay.23, king cobra.dat, and mouse.a b.

The command I ran to test is was ./checkFiles.sh [insert ascii file I have] and it gave me back the appropriate
[insert ascii file path]: Windows ASCII
# 5  
If your loop control variable is $i, you probably don't want to pass $1...
# 6  
./checkFiles.sh runs it by /bin/bash (its shebang).
Running it with sh is different. Depends on the sh how much different.
Login or Register for Dates, Times and to Reply

Previous Thread | Next Thread
Thread Tools Search this Thread
Search this Thread:
Advanced Search

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Script that performs action when receiving an SMS.

My case is the following: -I have a Linux system where I have an smsd installed (SmsTools3) -This system works through a GSM module in which I can send and receive text messages. -Text messages arrive in a certain folder (/ var / spool / sms / incoming) -I need a script that does... (3 Replies)
Discussion started by: dMihawkCL
3 Replies

2. Shell Programming and Scripting

Except script fails to check file exists or not in remote node

Dear members, The following expect script connects to remote node and check for the file "authorized_keys" in directory /root/.ssh in remote node. However the result is always found even if the file exist or doesn't exist. expect { "$fname" { send_user "found\n" } Any idea what is... (4 Replies)
Discussion started by: Sudhakar333
4 Replies

3. Shell Programming and Scripting

Script to check one command and if it fails moves to other command

Input is list of Server's, script is basically to remove old_rootvg, So it should check first command "alt_rootvg_op -X old_rootvg" if it passes move to next server and starts check and if it fails moves to other command "exportvg old_rootvg" for only that particular server. I came up with below,... (6 Replies)
Discussion started by: aix_admin_007
6 Replies

4. Shell Programming and Scripting

Record length check fails due to '\' character

When I check the length for the records in the file, it does not give me the correct value. I used wc -l command. Example records: abcdefghij abcd\efghij abcdefghi Expected output is: 10 11 9 But the output returned is 10 10 9 Please help me on this issue. (10 Replies)
Discussion started by: Amrutha24
10 Replies

5. Shell Programming and Scripting

File check script fails for multiple files

I want to check if any file with testing*.txt exists but my script fails if more than 1 file exists. It works fine for a single file if then echo "TEST21" fi -------------- bash: How do I fix this? Thanks Please use code tags next time for your code and data. (8 Replies)
Discussion started by: sumang24
8 Replies

6. Shell Programming and Scripting

Script to performs checks

Hi , I need a script which performs below activity I have one file named "testfile" in 9 different directories with same name. I want to perform below action with each testfile of each directory. if ; then mv listfiles listfiles_`date +%b%y` else echo No Such files fi ... (4 Replies)
Discussion started by: sv0081493
4 Replies

7. What is on Your Mind?

Monzy performs kill -9 at Stanford

Hello people, Have you all seen this? Fow7iUaKrq4 (1 Reply)
Discussion started by: nigelc
1 Replies

8. Solaris

lib/cpp fails sanity check

I'm trying to install a new library for php but everytime I run configure I got the following error "lib/cpp" fails sanity check. My OS is solaris 10 Any help on how to solve this issue would be highly appreciated (3 Replies)
Discussion started by: dahr
3 Replies

9. Shell Programming and Scripting

comment and Uncomment single task out of multiple task

I have a file contains TASK gsnmpproxy { CommandLine = $SMCHOME/bin/gsnmpProxy.exe } TASK gsnmpdbgui { CommandLine = $SMCHOME/bin/gsnmpdbgui.exe I would like to comment and than uncomment specific task eg TASK gsnmpproxy Pls suggest how to do in shell script (9 Replies)
Discussion started by: madhusmita
9 Replies

10. Debian

./configure is broken - /lib/cpp fails sanity check

Hi, I first wanted to install my NIC drivers but it said: Makefile:62: *** Linux kernel source not found. Stop. So I installed the kernel source: linux-source-2.6.18_2.6.18.dfsg.1-13etch5_all.deb 1) cd /usr/src 2) -xjvf linux-source.2.6.18.extension (forget what it was) 3) ln -s... (12 Replies)
Discussion started by: Virtuality
12 Replies

Featured Tech Videos