Homework & Coursework Questions

Use and complete the template provided. The entire template must be completed. If you don't, your post may be deleted!

1. The problem statement, all variables and given/known data:
Generalize your sub2 script, producing a new script sub3 that will apply a substitution to any number of files given on the command line. For example

Code:

~/UnixCourse/scriptAsst/sub3 foo bar myFile1.txt myFile2.txt myFile3.txt

should apply the same substitution throughout each of the three files named there.
Give the command:

Code:

~cs252/bin/scriptAsst.pl

to complete the assignment.


2. Relevant commands, code, scripts, algorithms:
Using pico for scripting in putty


3. The attempts at a solution (include all code and scripts):
My attempt at the Assignment:

Code:

#!/bin/sh
p1="$1"
shift
p2="$1"
shift

for FILE in "$@"
do 
echo $p1
echo $p2
echo "$p1" | sed -e 's/\([*.[^$]\)/\\\1/g' > temp
p1="`cat temp`"
rm temp 
echo $p1

sed "s/$p1/$p2/g" "$FILE > temp.out
mv temp.out "$FILE"
done

I noticed there was a previous thread about this, but with my code its not working and i dont know why.

The error im recieving is

Code:

sub3 produced incorrect output on test 37: /home/bnaranjo/UnixCourse/scriptAsst/sub3 'l*' 'L' '_cat.dog.dat' '/home/bnaranjo/UnixCourse/scriptAsst/../_hippo.cpp'

I appreciate any help and anybodys time for looking at it, its my last assignment
4. Complete Name of School (University), City (State), Country, Name of Professor, and Course Number (Link to Course):
Old Dominion University, Norfolk(VA), USA, Zeil, csc 252



Note: Without school/professor/course information, you will be banned if you post here! You must complete the entire template (not just parts of it).

There seems to be a double quote missing with the second sed command.

Oh that mustve been a typing error i did, the code includes the parenthesis in my code, im sorry. Thank you for taking a look, any other ideas you could give me?

---------- Post updated at 12:19 AM ---------- Previous update was at 12:17 AM ----------

Oh that mustve been a typing error, i include the parenthesis in my code, im sorry. Thank you for taking a look, any other ideas ?

I meant a double quote: ", around "$FILE" not a parenthesis (). What is not working? What is producing this error message?

Yeah the double quotes you mentioned, thats whats in my original code.But im not sure what the error is, my guess maybe sed isnt working well for the last file being changed, it works fine up from 1 to 36, then at 37 it gives me trouble. It says sub3 produced incorrect output on test 37

the full error message is up in my original message up top

Yes but the error message is not produced by the shell interpreting the script, or a Unix utility but by something else. We have no way of knowing what that is. What could be is that the variables in the sed statement contain a forward slash, which would mess up the command. Then you could use another character instead of the /. For example:

Code:

sed "s#$p1#$p2#g"

oh yeah, i tried the sed command, still no luck, gave me the same results, i really appreciate you being patient with me and helping, i just dont know how else i could go about this, do you know how i could debug that file?