Memory fault(coredump)

 
Thread Tools Search this Thread
Homework and Emergencies Homework & Coursework Questions Memory fault(coredump)
# 1  
Old 09-04-2011
Memory fault(coredump)

I am writing a program that copies a program and prints the program with a line count.

this is the program I wrote:
Code:
#include <stdio.h>

main()
{
        int c;
        int nl_cnt = 0;

        while((c = getchar()) != EOF){
                if(c = '\n'){
                   nl_cnt++;
                   printf("%10s ", nl_cnt);}

                 else{
                   putchar(c); }
        }

}

I am testing the program by doing a line count for Hello World.

Code:
 

#include <stdio.h>

main()
{
        printf("Hello World\n");
        return 0;
}

both programs compile with gcc. My program that copies and counts lines is line_number.c and is compiled as line_number. I have to use ./ or my terminal can't find the file.

To read the hello world program I type at the command line:
./line_number < hello.c

and I get the following error message: Memory fault(coredump)

I am new to Unix and not sure how to fix this. Thanks for any help!

Cal State Northridge, Northridge(California), Dr, Gabrovsky, Comp322
# 2  
Old 09-04-2011
%10s is for strings but nl_cnt isn't of this type.
# 3  
Old 09-04-2011
changing the s to a d helped a lot. thanks!

this is my new code:
Code:
#include <stdio.h>

main()
{
        int c;
    int nl_cnt = 0;

        while((c = getchar()) != EOF){

                if(c == '\n'){
                nl_cnt++;
                printf("%d ", nl_cnt);}

                putchar(c);

        }

}

this is the output I am getting:

Code:
$ ./line_number < hello.c
1 
#include <stdio.h>2 
3 
main()4 
{5 
    printf("Hello World\n");6 
}7 
8 
9

how do I get the numbers and the code to line up correctly?
# 4  
Old 09-04-2011
Code:
#include <stdio.h>

main()
{
        int c;
    int nl_cnt = 0;

        while((c = getchar()) != EOF){

                if(c == '\n'){
                nl_cnt++;
                printf("%d ", nl_cnt);}

                putchar(c);

        }

}

Quote:
Originally Posted by heywoodfloyd
how do I get the numbers and the code to line up correctly?
Your logic is a bit off. Check if c is a newline. If it is, print c, and then print a line number. Otherwise, just print c. You might also want to print a line number before your loop so that your first line is numbered.

A couple of other things:
  1. You should have warnings turned on for your compiler. This would have helped you catch your initial problem much easier. For example, if you were using gcc to compile, you would use (at minimum) the -Wall and -Wextra switches, e.g.,
    Code:
    gcc -Wall -Wextra -o myprog myprog.c

    Consult your manual pages for specific details about your system.
  2. The second is more nitpicky, but still good to know. The above program is not exactly conforming C - not to C89, and not to C99. In C89, main may be declared as above, but must have an explicit return statement. Under C99, main must be declared as one of the following:
    Code:
    int main(void)
    int main(int argc, char *argv[]) /* int main(int argc, char **argv)
                                 * is also acceptable
                                 */

    Additionally, under C89, an explicit return at the end of main is required. In C99, it is not, and if not provided, a return value of zero is implied. Had you turned your compiler warnings on, it may have told you that you did not return a value from main in your 'cat -n' program.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Advanced & Expert Users

Memory fault(Coredump)

Hi, In my application we have one job which is used to process the files. But that job is failing with memory fault while processing a file or while shutting down the job. Sometime it generates the coredump and sometimes not. When I analysed the core dump I got below code snippet where it... (3 Replies)
Discussion started by: shilpa_20
3 Replies

2. AIX

Error: Memory fault(coredump)

Hi Experts, While running a command, i saw this error below # ls -lrt total 74008 -rw-r--r-- 1 rr57104 edcfes 37889134 May 16 12:41 LGTOnw.clnt.7.4.2.0.bff.tar.gz drwxr-xr-x 2 root system 256 May 18 12:42 lost+found # gunzip LGTOnw.clnt.7.4.2.0.bff.tar.gz Memory fault(coredump) ... (2 Replies)
Discussion started by: EngnrRG
2 Replies

3. Shell Programming and Scripting

Memory fault(coredump) while using cat cmd

i have few log files that are input to my perl script... i am executing the script as below cat RTR*.log | test.pl and getting the following error -ksh: 25014: Memory fault(coredump) cat: write error: Connection reset by peer can anyone help me on this.... Thanks in... (2 Replies)
Discussion started by: niteesh_!7
2 Replies

4. Programming

Memory fault(coredump) while using Environment variables

Hi, Actually I am facing one issue while using the getenv() in the C/C++ program. I want to take the file path from environment variables and if am not defining the environment path, its showing the message like this…! Memory fault(coredump) Actually I want to handle the error ,... (6 Replies)
Discussion started by: Kattoor
6 Replies

5. Shell Programming and Scripting

Segmentation Fault(coredump)

I'm getting this error when trying to run a Acucobol program thru UNIX.. Segmentation Fault(coredump) Precompiler error prevents compilation of xxxxxx.co. Please help me in this case.. (1 Reply)
Discussion started by: Manish4
1 Replies

6. Solaris

memory fault (coredump)

Getting memory fault (coredump) and segmentation fault(coredump) when i tried javac or java -version. what could be the problem? Regards Eswar (2 Replies)
Discussion started by: BhuvanEswar
2 Replies

7. Ubuntu

Memory fault(coredump)

Hey guys, I am new to the Linux world and have a question to post. When I ssh from a HP-UX machine to a ubuntu machine I get the following error message Memory fault(coredump) i.e. ssh 192.168.1.3 I get this message as shown below Memory fault(coredump) Can someone please explain... (2 Replies)
Discussion started by: fkaba81
2 Replies

8. AIX

Segmentation fault(coredump)

Hi All Can anybody help me? When ever am trying to run topas system gives me an error Segmentation fault(coredump) does anybody ahve solution for this? (4 Replies)
Discussion started by: vjm
4 Replies

9. Programming

Memory fault(coredump)

Dear All, I made a program which do some simple jobs like reading data from other process's shared memory and writing messages to the queues of other process. what happens is my program works fine and do all the task as expected but then then program ends it give Memory fault(coredump). I... (0 Replies)
Discussion started by: ralo
0 Replies

10. UNIX for Dummies Questions & Answers

Coredump (memory fault)

We are running a SQR program on Unix Platform with Oracle RDBMS. It's an interfacing program to integrate data from foreign sites to PeopleSoft database, using a flat file input. After many hours of processing, the program stops with a coredump error (memory fault). With top command we noticed... (1 Reply)
Discussion started by: araziki
1 Replies
Login or Register to Ask a Question

Featured Tech Videos