Sponsored Content
Full Discussion: C++/ROOT Memory Allocation?
Top Forums Programming C++/ROOT Memory Allocation? Post 302802791 by Tyler_92 on Saturday 4th of May 2013 11:27:31 PM
Old 05-05-2013
C++/ROOT Memory Allocation?

Hello,
I am new to C++ programming, so I'm still getting a feel for things. I recently wrote a simple C++ program (to be used as a ROOT Macro) to conduct a statistical analysis of a varied version of the Monty Hall problem (code below). Basically, the programs runs a few simple calculations to decide the winner, nothing too complex, and is designed to be run many times for a statistical analysis. What I have noticed is the program uses memory VERY inefficiently. Using Mac Activity Monitor, I notice that when I just loop through 10,000 times my free memory loses ~0.5 gigabytes. This is a program that I want to be able to run at least a million times if not more. Is there some basic error in my code that is causing this? Thanks in advance.
Code:
#include "stdint.h"
#include "TMath.h"
#include <cmath>
#include <TRandom1.h>
#include <iostream>

//Varied Monty Hall Program!

//Function to return a random number to serve as a pointer in the 'door_array' array
int RandomDoor(int& doors)
{
    TRandom1 *myran=new TRandom1(0,389);
    int returnVal=myran->Rndm()*doors;
    return returnVal;
}

//Function to Search for an available door
int Search(int* array,int& doors,int& choosedoor,int& host_doors)
{
    int returnVal;
    if ((doors-host_doors)==1) {
        returnVal=choosedoor;
    }
    
    int rNum=RandomDoor(doors);
    if ((array[rNum]==2)||(rNum==choosedoor)) {
        rNum=RandomDoor(doors);
        while ((array[rNum]==2)||(rNum==choosedoor)) {
            if ((rNum==(doors-1))&&(array[rNum]==2)) {
                rNum=0;
            }
            if ((rNum==(doors-1))&&(rNum==choosedoor)) {
                rNum=0;
            }
            else
            {
                rNum++;
            }
        }
        returnVal=rNum;
    }
    returnVal=RandomDoor(doors);
    return returnVal;
}

void MontyHall2(int doors, long iterations, int host_doors)
{
    double host_wins=0;
    double wins=0;
    double winpct=0;
    //generate array
    int* door_array=new int[doors];
    
    //loop through game 'iteratons' times
    for (long i=0; i<iterations; i++) {
        
        //populate array with 0's
        
        for (int j=0; j<doors; j++) {
            door_array[j]=0;
        }
        
        //choose winning door
        door_array[RandomDoor(doors)]=1;
        
        //player randomly chooses
        
        int choosedoor=RandomDoor(doors);
        
        //Host randomly chooses doors and turns them to "2"
        
        bool rightVal=false;
        for (int k=0; k<host_doors; k++) {
            int temp=Search(door_array,doors,choosedoor,host_doors);
            door_array[temp]=2;
            if (door_array[temp]==1) {
                rightVal=true;
            }
        }
        
        //If host chooses correctly, host_wins++ and game over
        if (rightVal==true) {
            host_wins++;
        }
        
        else {
            
            //Player switches doors
            int limit;
            if (host_doors>3) {
                limit=host_doors/3;
            }
            else {
                limit=1;
            }
            
            bool playerwins=false;
            for (int n=0; n<limit; n++) {
                if (door_array[Search(door_array,doors,choosedoor,host_doors)]==1) {
                    playerwins=true;
                }
            }
            if (playerwins==true) {
                wins++;
            }
        }
    }
    winpct=(100*wins)/iterations;
    cout<<winpct<<" %"<<endl;
    delete[] door_array;
}

 

10 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

memory allocation

I would like to know how I could allocate some more memory to a process. Please note that I am not the root user. (1 Reply)
Discussion started by: sagar
1 Replies

2. UNIX for Advanced & Expert Users

threads and memory allocation

Hello! First of all, forgive me for bad English. When I starts new thread (pthread_create), system allocates some memory for it (for example, for thread's stack). I wonder when does it deallocate this memory? The problem is that I have a program which sometimes creates new threads and sometimes... (3 Replies)
Discussion started by: prankster
3 Replies

3. HP-UX

HP-UX memory usage allocation

Hi all, I have a HP-UX Server with 4 gigabytes of physical RAM. When I use the 'Glance' utility to see what my memory utilization is, my memory usage shows up maxed out at 99%. I shut off all the known processes that I'm running on that box and the memory utilization is still at 78% (with Swap... (3 Replies)
Discussion started by: dehuang83
3 Replies

4. Programming

Is there a problem with the memory allocation???

I have a scenario like the client has to search for the active server.There will be many servers.But not all server are active.And at a time not more than one server will be active. The client will be in active state always i.e, it should always search for an active server until it gets one.I... (1 Reply)
Discussion started by: vigneshinbox
1 Replies

5. Programming

Memory allocation in C

Hi Experts I need some help in static memory allocation in C. I have a program in which I declared 2 variables, one char array and one integer. I was little surprised to see the addresses of the variables. First: int x; char a; printf("%u %u\n', &x, a); I got the addresses displayed... (2 Replies)
Discussion started by: unx_freak
2 Replies

6. Programming

Dynamic Memory Allocation

Hello Guys I have a small confusion in the dynamic memory allocation concept. If we declare a pointer say a char pointer, we need to allocate adequate memory space. char* str = (char*)malloc(20*sizeof(char)); str = "This is a string"; But this will also work. char* str = "This... (2 Replies)
Discussion started by: tene
2 Replies

7. Programming

Memory Allocation Query

When we dynamically allocate the memory say 100 integers say int *x = new int(1000); then does entire chunk of memory gets allocated at once after the completion of the statement? I mean will the the concept of page fault come into picture over here? (3 Replies)
Discussion started by: rupeshkp728
3 Replies

8. Shell Programming and Scripting

memory allocation to a variable

hello all.. i'm a beginner in shell scripting. I need to know what is really happening when we are creating a variable in shell scripting? how memory is allocated for that variable? (3 Replies)
Discussion started by: aarathy
3 Replies

9. Programming

memory allocation for string in C

hi in the following code, how the memory is allocated for a1 which holds the values of a2 after cpy function call. #include <stdio.h> #include <string.h> void cpy(char* d, const char* s){ while(*d++=*s++); } main(){ char* a1; char* a2="done"; cpy(a1,a2); ... (3 Replies)
Discussion started by: mprakasheee
3 Replies

10. UNIX for Dummies Questions & Answers

Memory allocation problem

I am using ubuntu. I have written a program to calculate prime factors. it works perfectly fine till entered number is less than 9989 (or so ) but when one enters a number higher than that, for example 15000, it does not work. Can anyone guide me whats the problem ? although new codes are welcome,... (2 Replies)
Discussion started by: Abhishek_kumar
2 Replies
All times are GMT -4. The time now is 12:22 AM.
Unix & Linux Forums Content Copyright 1993-2022. All Rights Reserved.
Privacy Policy