Need help with repeating variables in a shell script


 
Thread Tools Search this Thread
Top Forums UNIX for Dummies Questions & Answers Need help with repeating variables in a shell script
# 1  
Old 01-24-2013
Need help with repeating variables in a shell script

I should preface this by saying I have never worked with shell scripts before so this is all new to me. I was able to make something that worked, but is terribly optimized, and I have no idea how to improve it. If anything it's a pretty hilarious script:

Code:
   #/bin/bash
    
    get_char() {
    	old_tty_settings=`stty -g`
    	stty -icanon min 0 time 1
    	stty cbreak
    	grabbed_char=`dd if=/dev/tty bs=1 count=1 2>/dev/null`
    	stty -cbreak
    	stty "$old_tty_settings"
    }
    
    while true; do
    
    	unset char00
    	unset char01
    	unset char02
    	unset char03
    	unset char04
    	unset char05
    
    	echo -e "\nWaiting for keystroke..."
    	read -n 1 char00
    
    	while true; do
    
    		get_char; char01=$grabbed_char
    
    		if [ "$char01" != "" ]; then get_char; char02=$grabbed_char
    			else break
    		fi
    		if [ "$char02" != "" ]; then get_char; char03=$grabbed_char
    			else break
    		fi
    		if [ "$char03" != "" ]; then get_char; char04=$grabbed_char
    			else break
    		fi
    		if [ "$char04" != "" ]; then get_char; char05=$grabbed_char
    			else break
    		fi
    
    	done
    
    	fullstring=$char00$char01$char02$char03$char04$char05
    	echo -e "\nFULLSTRING:	!$fullstring!"
    
    done


The list is a lot longer, but I spared you.

Basically, the program needs to sit in terminal forever waiting for a keystroke. After an initial keystroke, it needs to wait a very short amount of time (1/10th of a second in this case) for another keystroke. If no keystroke is registered in that short time, it echos the output (which will be piped with sed commands), and restarts.

It is meant to be used with a barcode scanner, where you may scan 4 characters, or 100 characters. We want to process the data as quickly as possible, meaning we don't want a 1 second delay after something is scanned.

A good solution would be if "charXX" could be created as a character was received. Thanks for any help.
# 2  
Old 01-24-2013
Quote:
Originally Posted by ricco19
Basically, the program needs to sit in terminal forever waiting for a keystroke. After an initial keystroke, it needs to wait a very short amount of time (1/10th of a second in this case) for another keystroke. If no keystroke is registered in that short time, it echos the output (which will be piped with sed commands), and restarts.
Hmmm.

I think a terminal device can do that all by itself without bash's help, actually! From man termios:

Code:
       In non-canonical mode input is available immediately (without the  user
       having  to  type  a line-delimiter character), and line editing is dis-
       abled.  The settings of MIN (c_cc[VMIN]) and TIME (c_cc[VTIME])  deter-
       mine  the  circumstances  in  which a read(2) completes; there are four
       distinct cases:

       * MIN == 0; TIME == 0: If data is available,  read(2)  returns  immedi-
         ately,  with the lesser of the number of bytes available, or the num-
         ber of bytes requested.  If no data is available, read(2) returns 0.

       * MIN > 0; TIME == 0: read(2) blocks until the lesser of MIN  bytes  or
         the  number  of bytes requested are available, and returns the lesser
         of these two values.

       * MIN == 0; TIME > 0: TIME specifies the limit for a timer in tenths of
         a  second.   The  timer  is  started when read(2) is called.  read(2)
         returns either when at least one byte of data is available,  or  when
         the  timer  expires.  If the timer expires without any input becoming
         available, read(2) returns 0.

       * MIN > 0; TIME > 0: TIME specifies the limit for a timer in tenths  of
         a second.  Once an initial byte of input becomes available, the timer
         is restarted after each further byte is  received.   read(2)  returns
         either  when  the lesser of the number of bytes requested or MIN byte
         have been read, or when the inter-byte timeout expires.  Because  the
         timer  is  only  started after the initial byte becomes available, at
         least one byte will be read.

I'll see if I can build something quick.
# 3  
Old 01-24-2013
There are a few problems with your script, conceptually and otherwise. The bottom line - to spare you the effort of IMHO optimizing a hopeless case - is that this problem is IMHO suited to a high-level language (C, whatever - pick any).

First, the shells input function is based on the terminal handling of Unix and therefore not suited to the way you want to treat the input: basically a Unix terminal is a file, where you can read from (input) and write to (output). What's more Unix was historically designed as a multi-user system. One system at the center and a number (typically a dozen or two) terminals connected to it. The Unix terminal deals with lines of data: a "read" statement will take any amount of keystrokes but only process them once the user hits <ENTER>. This is so because this way the central system will have to pay only very limited attention to the terminal until the user does formally end his input. The system is similar to how IBM mainframes deal with their terminals and the reason why they can handle vast amounts of sessions at the same time with comparatively limited resources. Would the system have to pay attention to every keystroke it would do nothing else than paying attention as the number of sessions increases.

What you now want is to indeed pay attention to every keystroke. The shell is - because of historical reasons given above - not designed to do so.

Apart from the conceptual problem there are only very minor problems which usually happen to beginners. In fact you have done astonishingly well for a beginner:

Code:
old_tty_settings=`stty -g`

You use this device (the backticks) several times. Backticks are deprecated and only support for backwards compatibility. Instead of backticks use "$(..)":

Code:
old_tty_settings="$(stty -g)"

Then you don't pay attention to quoting:

Code:
fullstring=$char00$char01$char02$char03$char04$char05

This is not a high-level-language. The shell interpretes this line by replacing the variables with their content in a first pass, then executing what results in another pass (there are actually several passes, but these two matter in this case). To protect your variables content from being interpreted by the shell you should always quote them:

Code:
fullstring="$char00$char01$char02$char03$char04$char05"

For the same reason i quoted to subshell call with which i replaced the backticks before. This way you are always on the safe side. Only omit the quotes for the expressed purpose of having the string interpreted by the shell.

Last is you don't pay attention to the variable scope. Where is "grabbed_char" belonging to? Even if the shell allows you to introduce variables on the fly you should work like it doesn't, simply because this way you get more orer in your source and have less maintenance effort in the future.

You should define a variable (use "typeset") in the main program and then pass the output via <stdin>. The following sketch shows the mechanism:

Code:
#! /bin/bash

sub_function ()
{
     typeset argument="$1"
     echo "a $argument"
     return 0
}

# main ()
typeset string1=""
typeset string2=""

string1=$(sub_function "foo")"; echo "$string1"
string2=$(sub_function "bar")"; echo "$string2"

exit 0

I hope this helps.

bakunin
# 4  
Old 01-24-2013
This uses the terminal's built-in properties for read timeouts:
Code:
#!/bin/sh

old_tty_settings=$(stty -g)
# This restores the terminal settings even if you quit with ctrl-C
trap "stty $old_tty_settings" EXIT

stty -echo -icanon min 1 time 1

STRING=$(dd if=/dev/tty count=1 2>/dev/null)

echo "Read $STRING"

The terminal waits for multiple keystrokes yet times out quickly, and no loop is required. I can't type fast enough to get more than one letter in, but if I paste something to the terminal it gets the whole thing.

You still have to use dd, not the read builtin, because read messes with the terminal device too, undoing all the fancy settings you've been trying to arrange.
# 5  
Old 01-24-2013
Quote:
This uses the terminal's built-in properties for read timeouts:

Code:
#!/bin/sh

old_tty_settings=$(stty -g)
# This restores the terminal settings even if you quit with ctrl-C
trap "stty $old_tty_settings" EXIT

stty -echo -icanon min 1 time 1

STRING=$(dd if=/dev/tty count=1 2>/dev/null)

echo "Read $STRING"

The terminal waits for multiple keystrokes yet times out quickly, and no loop is required. I can't type fast enough to get more than one letter in, but if I paste something to the terminal it gets the whole thing.

You still have to use dd, not the read builtin, because read messes with the terminal device too, undoing all the fancy settings you've been trying to arrange.
This is a good solution and it works well. Thanks.

Yeah we knew we could make a working c program, but just using a script makes it a simpler process.
 
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Shell script to create runtime variables based on the number of parameters passed in the script

Hi All, I have a script which intends to create as many variables at runtime, as the number of parameters passed to it. The script needs to save these parameter values in the variables created and print them abc.sh ---------- export Numbr_Parms=$# export a=1 while do export... (3 Replies)
Discussion started by: dev.devil.1983
3 Replies

2. Shell Programming and Scripting

How to write config shell script to pass variables in master shell script?

Dear Unix gurus, We have a config shell script file which has 30 variables which needs to be passed to master unix shell script that invokes oracle database sessions. So those 30 variables need to go through the database sessions (They are inputs) via a shell script. one of the variable name... (1 Reply)
Discussion started by: dba1981
1 Replies

3. UNIX for Dummies Questions & Answers

How to write Config shell script to pass variables in master shell script?

Dear Unix gurus, We have a config shell script file which has 30 variables which needs to be passed to master unix shell script that invokes oracle database sessions. So those 30 variables need to go through the database sessions (They are inputs) via a shell script. one of the variable name... (1 Reply)
Discussion started by: dba1981
1 Replies

4. UNIX for Dummies Questions & Answers

Adding variables to repeating strings

Hello, I want to add a letter to the end of a string if it repeats in a column. so if I have a file like this: DOG001 DOG0023 DOG004 DOG001 DOG0023 DOG001 the output should look like this: DOG001-a DOG0023-a DOG004 DOG001-b (15 Replies)
Discussion started by: verse123
15 Replies

5. Shell Programming and Scripting

Shell script to extract data in repeating tags from xml

Hi, I am new to shell scripting. I need to extract data between repeating tags from an xml file and store the data in an array to process it further. <ns1:root xmlns:ns1="http://example.com/config"> <ns1:interface>in1</ns1:interface> <ns1:operation attribute1="true" attribute2="abd"... (2 Replies)
Discussion started by: sailendra
2 Replies

6. Shell Programming and Scripting

Variables in shell script

mysqldump --compact --add-drop-table -h192.168.150.80 -uroot -p somePass $combined | sed '/$combined/$table/g' | mysql $databaseThe sed part is not working from the above statement. The variables combined and table are already defined and instead of showing the actual variable, it is executing the... (4 Replies)
Discussion started by: shantanuo
4 Replies

7. Shell Programming and Scripting

Accessing variables of one shell script in another shell script

Hi All, I have a shell script called sample1.sh where I have 2 variables. Now I have another shell script called sample2.sh. I want the variables in sample1.sh to be available to sample2.sh. For example. In sample1.sh I am finding the sum of 2 numbers namely a and b. Now I want to access... (2 Replies)
Discussion started by: rsendhilmani
2 Replies

8. Shell Programming and Scripting

Accessing variables of one shell script in another shell script

I have a variable $exe in a shell script file a.sh which I need to access in another shell script file b.sh. How can I do that? :rolleyes: Thanks!! (2 Replies)
Discussion started by: looza
2 Replies

9. Shell Programming and Scripting

Repeating variables in the code

Hi all, I had written 3 KSH scripts for different functionalities. In all these 3 files there are some 30 variables in common. So I want to reduce the code by placing these variables in a common properties file named (dataload.prop/dataload.parms/dataload.txt) or txt file and access it... (1 Reply)
Discussion started by: mahalakshmi
1 Replies

10. Shell Programming and Scripting

Shell Script Variables

HI guys I need to store the output of a sql query in a variable, can you tell me how to do that eg) select count(*) from s_escl_req $count = count(*) from s_escl_req how would i store the count(*) from the sql statement in a variable called $count. thanks (3 Replies)
Discussion started by: ragha81
3 Replies
Login or Register to Ask a Question