Hello all,

I'm working on a general script for something at work. I'm an up-and-comer backup for a Shell Scripter this company has had for 35 years lol. Anyway, I have a config file I'm trying to pull Variables from as the Config File is used for multiple scripts. Does the below make sense and is there any better way to do this?

Config File:

DayOfWeek Fri

function GetConfigParms
{
     DayOfWeek=`grep DayOfWeek app.main.cfg | awk '{print $2}'`
}

DayOfWeek=$( awk '/DayOfWeek/{print $2}' app.main.cfg )

No need for patterns when we can use an exact parameter name:

awk '$1==s{print $2}' s=DayOfWeek file

Do you get to pick what your config file looks like? I'd have a config file like this:

DayOfWeek=Fri
SomethingElse=whatever

while read VAR VALUE
do
        if [ ! -z "$VAR" ]
        then
                read $VAR <<EOF
$VALUE
EOF
        fi
done < configfile

The ConfigFile is to my choosing. That's a similar format to how the guy I'm learning from had his, so I kept it. I prefer the

ParmName=Value

or

ParmName:Value

setup.

I appreciate your help guys! Note I only showed one Parm as an example, the file has many. I have it currently in multiple lines pulling it in. No loops, etc.

just follow the Corona688's suggestion with the paramName=paramValue format and 'sourcing' the config file - that's a better and an easier maintained paradigm.

Oh ok. I talked with him and I guess he's making more work for himself. He sets an environment variables AND a config file separately, sourcing the env.vars and then using a function to pull in config parameters. I don't see why I can't just use one file and source it, as Corona said above. I feel like creating a function and grep'ping each damn variable isn't necessary.