Hi Forum

Can anyone tell me whats wrong with my script. What i want to do read in values from a input file using a while loop then taking that input from the file into a function that i created. Every time i execute the script it goes through the while loop but the function doesn't see the values that im trying to pass it from the file.

Here is my code

##################################
#this function validate the cost of a product
validCost()
{
  
  echo ${1} | grep -E '[:digit:]+.[:digit:]+'

  if [ $? = 0 ]; then
  {
      echo 'this is valid'
      echo ${1}
  }
  else
  {
      echo 'fail hard out'
      echo ${1}
  }
  fi   
}


##################################
#Main body
##################################

#testing a while loop reading in file

echo '##################'
echo ${1}
echo '##################'
echo 'start of the loop'

echo '##################'
while read ${x} 
do
  
echo '##################'
  echo 'in the loop'
  validCost ${x}
echo '##################'
done < ${1}


echo 'end of loop'

CHI132456
CHI132456
CHI132
1.5
2.6

Hi.

What shell are you using?

Try:

while read x

while read ${x}

im using the bash shell oh i give that a try

---------- Post updated at 11:03 AM ---------- Previous update was at 09:35 AM ----------

didnt work
keeps comming up with blanks

how are you running it? please poste entire output after adding set -x to the top.

Removing all the junk:

validCost()
{
  
  echo $1 | grep -E '[0-9]+\.[0-9]+' > /dev/null

  if [ $? -eq 0 ]; then
      echo 'this is valid'
      echo $1
  else
      echo 'fail hard out'
      echo $1
  fi   
}
##################################
#Main body
##################################

#testing a while loop reading in file

while read x
do
  validCost $x
done < ${1:-file1}

fail hard out
CHI132456
fail hard out
CHI132456
fail hard out
CHI132
this is valid
1.5
this is valid
2.6

1) add a slash before the .
2) not an issue but i suggest using -q option to grep instead of redirecting stdout to /dev/null

echo ${1} | grep -q -E '[:digit:]+\.[:digit:]+'

Oh i found the problem I was not give the full path name to the script
i was using this

q1 text.txt

q1 ~/text.text

done < ${1:-file1}