The UNIX and Linux Forums  

Go Back   The UNIX and Linux Forums > Top Forums > Shell Programming and Scripting
.
google unix.com



Shell Programming and Scripting Post questions about KSH, CSH, SH, BASH, PERL, PHP, SED, AWK and OTHER shell scripts and shell scripting languages here.

More UNIX and Linux Forum Topics You Might Find Helpful
Thread Thread Starter Forum Replies Last Post
Request for Recommendations Ariean UNIX for Advanced & Expert Users 1 01-27-2009 09:25 AM
SAP swap recommendations jhtrice UNIX for Advanced & Expert Users 2 12-21-2008 10:28 AM
XTP recommendations overlap with CEP… iBot Complex Event Processing RSS News 0 06-13-2008 09:50 PM
your recommendations antalexi Shell Programming and Scripting 1 08-30-2005 05:23 PM
Recommendations for a convert Keith UNIX for Dummies Questions & Answers 2 02-06-2001 03:18 PM

 
English Japanese Spanish French German Portuguese Italian Dutch Swedish Russian Norwegian Hungarian Hebrew Danish Bulgarian Greek Powered by Powered by Google
 
LinkBack Thread Tools Search this Thread Rate Thread Display Modes
Prev Previous Post   Next Post Next
  #1 (permalink)  
Old 01-22-2009
Ariean Ariean is offline
Registered User
  
 

Join Date: Apr 2008
Posts: 25
Suggestions/Recommendations for coding

Quote:
Guru's, Could you please review my below code i wrote and let me know if you have any recommendations or suggestions for me. I just want to make sure i am not making any major outbreak or silly things while coding, Appreciate your time and help on this. Thanks a lot
Quote:
First Program to copy/move files and prepare list files
Code:
#!/bin/sh
#set -x
uploaddir="/u01/app/informatica/dev3/sample/GPMDir/UploadDir"
processdir="/u01/app/informatica/dev3/sample/GPMDir/ProcessDir"
datetime=`date +%Y%m%d`
logdir="$processdir/GPMLogFile_$datetime.log"

echo "<---------------Start Copying & Moving GPM Files To Process Directory-------------->" > $logdir

cat /dev/null >$processdir/dummy.txt
echo "Creating A Dummy File In The Process Directory" >> $logdir

rm -rf $processdir/*.list
echo "Removed All The List Files Generated Earlier In The Process Directory" >> $logdir

cd $uploaddir
echo "Current Directory Path Is:" >> $logdir
echo "`pwd`" >> $logdir

if [ -f "$uploaddir"/"GPM_"*".csv" ];then
	cp $uploaddir/GPM_*.csv $processdir
          if [ $? -eq 0 ] ; then
          echo "Master GPM Files Were Copied Successfully Into Process Directory" >> $logdir
          else
	  echo "Error In Copying Master GPM Files Into Process Directory" >> $logdir
          fi
else 
	echo  "Master GPM Files Doesn't Exists In Upload Directory, Hence Cann't Copy Over The Files Into The Process Directory" >> $logdir
fi

if [ -f "$uploaddir"/*"_FI.csv" ]; then
		for i in `ls -rt *_FI.csv`
		do
			echo $processdir/$i>> $processdir/GPM_FI.list
			cp $uploaddir/$i $processdir
			#mv $uploaddir/$i $processdir
		done
	echo "FI Files Exists, Generated The FI File List & Copied Over The FI Files Successfully Into The Process Directory" >> $logdir
else 
	echo "FI Files Doesn't Exists,Creating Dummy File List" >> $logdir
	ls -rt $processdir/dummy.txt > $processdir/GPM_FI.list
fi
Quote:
Second Program To Archive Files
Code:
#!/bin/sh
#set -x
processdir="/u01/app/informatica/dev3/sample/GPMDir/ProcessDir"
archivedir="/u01/app/informatica/dev3/sample/GPMDir/ArchiveDir"
zipfilename="$archivedir"/"GPMArchivedFiles_"`date +%y%m%d`".zip"

echo "<-----------Starting Archiving Of GPM Files For `date +%Y%m%d`-------------->" >> $archivedir/GPMArchive.log

cd $processdir
echo "The Current Directory Path Is:" >> $archivedir/GPMArchive.log
echo "`pwd`" >> $archivedir/GPMArchive.log

for i in `ls -rt *.csv *.log GPM_*.list`
do
echo $i >> $processdir/ArchiveFiles.list
done

while read line
do
zip -mqj $zipfilename $line
if [ $? -eq 0 ];then
echo "$line File Has Been Added To The Zip File $zipfilename"
else
echo "Error In Adding $line To The $zipfilename"
fi
done < $processdir/ArchiveFiles.list
 

Bookmarks

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On




All times are GMT -4. The time now is 10:19 AM.


Powered by: vBulletin, Copyright ©2000 - 2006, Jelsoft Enterprises Limited. Language Translations Powered by .
vBCredits v1.4 Copyright ©2007 - 2008, PixelFX Studios
The UNIX and Linux Forums Content Copyright ©1993-2009. All Rights Reserved.Ad Management by RedTyger

Content Relevant URLs by vBSEO 3.2.0