My first FTP bash script - sweet!

sitesbyjoe · #1 (**permalink**) 01-10-2009

Hey - thanks for reading this!

I just finished my first bash script that will handle daily ftp downloads for me, but I'm certain it could use some improvement.

Its job is to download IDX data from an ftp host (which is 24 hours behind) and I download a mix of *.txt.gz file and .tar files.

There are also "old" archives that I want to ignore.

Here's the code (its works fairly well though I get an occasional timeout)

Code:

#!/bin/bash

clear

USER="my_username"
PASS='my$password'
FTPSERVER="idx.fnismls.com"

YESTERDAY=$(TZ=EST26EDT date +%Y%m%d)
#echo $YESTERDAY

FILE1="pics-commercial-industrial-$YESTERDAY.tar"
FILE2="pics-condo-townhouse-$YESTERDAY.tar"
FILE3="pics-lots and land-$YESTERDAY.tar"
FILE4="pics-multi family-$YESTERDAY.tar"
FILE5="pics-residential-$YESTERDAY.tar"
#echo $FILE

ftp -i -n $FTPSERVER << EOF
user $USER $PASS

cd /IDX2

bin

mget *.txt.gz
get $FILE1
get $FILE2
get $FILE3
get $FILE4
get $FILE5

bye

I'd love to know what some things are I can do to improve this in the event of errors etc...

Thanks so much!!!

cfajohnson · #2 (**permalink**) 01-10-2009

Quote:

Originally Posted by sitesbyjoe

Here's the code (its works fairly well though I get an occasional timeout)

Code:

#!/bin/bash

clear

USER="my_username"
PASS='my$password'
FTPSERVER="idx.fnismls.com"

YESTERDAY=$(TZ=EST26EDT date +%Y%m%d)

Changing the TZ variable is an unreliable method of getting yesterday's date.

Quote:

Code:


#echo $YESTERDAY

FILE1="pics-commercial-industrial-$YESTERDAY.tar"
FILE2="pics-condo-townhouse-$YESTERDAY.tar"
FILE3="pics-lots and land-$YESTERDAY.tar"
FILE4="pics-multi family-$YESTERDAY.tar"
FILE5="pics-residential-$YESTERDAY.tar"
#echo $FILE

ftp -i -n $FTPSERVER << EOF
user $USER $PASS

You should put the username and password in your ~/.netrc file.

Quote:

Code:


cd /IDX2

bin

mget *.txt.gz
get $FILE1
get $FILE2
get $FILE3
get $FILE4
get $FILE5

bye

I'd love to know what some things are I can do to improve this in the event of errors etc...

The ftp command is not well-suited to scripting; error handling is one of it weaknesses. For scripting, if you can't use scp (recommended), use the ncftp suite of commands.

Ishikawa · #3 (**permalink**) 01-10-2009

You could have it read url's from a seperate file until it reaches the end of the file.

More UNIX and Linux Forum Topics You Might Find Helpful
Thread	Thread Starter	Forum	Replies	Last Post
DJ Sweet 0.9.7 (Default branch)	iBot	Software Releases - RSS News	0	12-10-2008 06:10 AM
how to make your bash script run on a machine with csh and bash	npatwardhan	Shell Programming and Scripting	3	11-19-2008 04:17 AM
Sweet Home 3D: version 1.4 released	iBot	Software Releases - RSS News	0	10-10-2008 01:10 AM
passing variable from bash to perl from bash script	arsidh	Shell Programming and Scripting	10	06-04-2008 12:25 PM
Abyss: a small, sweet Web server	iBot	UNIX and Linux RSS News	0	02-21-2008 12:10 PM

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Switch to Linear Mode Hybrid Mode Switch to Threaded Mode	Rate This Thread:


	Powered by