Read the comments I posted earlier.

Answer the questions I posed.

Why are you using:

Code:

for i in `ls -1 | grep $1 | grep  $2`

Quote:

Originally Posted by llsmr777 I put the done after I get my listing instead of the end of the script. Can I put my mv statement inside my Case Statement?

Of course.

Make sure the code you use is correct; in the script you posted, it was incomplete.

Just saying you made a change is not enough; I need to see the code you are trying to execute.

The case statment does not carry out the action; it makes a decision about which action is to be carried out. You then need the code to carry out the action.

You might find it helpful to put sections of your code into functions so that they can be tested idependently.

For example, you might want these functions: build_list, show_list, ask_user and move_files.

After you have written and tested the functions, the rest of your script could look like this:

Code:

build_list <file pattern>
show_list
if ask_user
then
   move_files
else
   echo "No changes made ..."
fi

function build_list
{
for i in *$1*$2*
do
x=`echo $i | sed 's/\.Sent/\.Done/g'`
done
}

function show_list
{
echo mv $i DONE/$x
}

echo "Is this Ok?"
read user_response
if [$user_response="y"|"Y"]
then
 mv $i DONE/$x;;
else
if [$user_response="n"|"N"]
then
echo "No changes made ...";;
fi
fi

Quote:

Originally Posted by llsmr777 Ok here is what I changed it to. I haven't tested it because I wanted input first.

If you had tested it first, you would have found most of the errors.

If you cannot tell us how it is not working, how do you expect us to help?

function build_list

That is not wrong in ksh and bash, but it is not the standard syntax for defining a function and will not work in other shells. Standard is:

Code:

build_list()