a script with prompts user and returns the value of there home directory and full name

#!/bin/bash


echo "please enter your login ID"

read login_id

while $login_id -ne `grep $login_id /etc/passwd | cut -f1 -d:`

is they anything wrong with it

I would do it with a grep of the login_id in /etc/password

grep $login_id | awk '{print $5, $6}'

sorry forgot

cat /etc/passwd (in the beginniing)

gnom: Useless Use of cat and grep

Apart from the useless use of grep and cut, I guess there is something wrong with your expression as you're comparing strings and test operator should be for strings is "!=" instead of "-ne". Correct me guys if I am wrong as I am still a newbie.