question about testing in shell programming

thungmail · #1 (**permalink**) 04-04-2008

Hi i would like to write a "script" which takes a directory as an argument and the script will output the content of a file in this directory.Here is my code

Code:

#!/bin/sh
#set an argument to be a specified path
$1=/home/tuan/Desktop/Shell_programming/directory

#check if an argument is a directory
if [ ! -d $1 ]
then
	for number in $1
		do 
		echo "$number"
	done<list
else
	echo "No such that directory "
fi

After that in terminal I did:

Code:

tuan@tuan:~/Desktop/Shell_programming$ ./A3 directory
./A3: 2: directory=/home/tuan/Desktop/Shell_programming/directory: not found
No such that directory 
tuan@tuan:~/Desktop/Shell_programming$

It seems there are mistakes. Can anyone point it out for me.
PS: In "directory" directory, I did created a file named "list" like below

Code:

1
2
3

Juha · #2 (**permalink**) 04-04-2008

Try to use something else than "$1" as the variable name... e.g.

Code:

#!/bin/sh
#set an argument to be a specified path
a=/home/tuan/Desktop/Shell_programming/directory

#check if an argument is a directory
if [ -d $a ]
then
	for number in $a
		do 
		echo "$number"
	done
else
	echo "No such that directory "
fi

thungmail · #3 (**permalink**) 04-04-2008

here is the new one (with modification)

Code:

#!/bin/sh
#set an argument to be a specified path
a=/home/tuan/Desktop/Shell_programming/directory/list
#check if an argument is a directory
if [ ! -d $a ]
then
	for number in $a
		do 
		echo "$number"
	done
else
	echo "No such that directory "
fi

However, the output is

Code:

tuan@tuan:~/Desktop/Shell_programming$ ./A3
/home/tuan/Desktop/Shell_programming/directory/list
tuan@tuan:~/Desktop/Shell_programming$

I have no idea.......

era · #4 (**permalink**) 04-05-2008

The way to loop over files in a directory is to list them.

Code:

for number in "$a"/*; do ...

If you want to constrain this to just files whose names are a number, use a different wildcard. This loops over all files in the selected directory.

More UNIX and Linux Forum Topics You Might Find Helpful
Thread	Thread Starter	Forum	Replies	Last Post
question about testing in shell programming	thungmail	Shell Programming and Scripting	6	04-09-2008 02:04 PM
question about testing in shell programming(modifications were made)	thungmail	Shell Programming and Scripting	2	04-08-2008 03:51 PM
question about testing in shell programming	thungmail	Shell Programming and Scripting	2	04-08-2008 02:29 AM
question about testing in shell programming	thungmail	Shell Programming and Scripting	3	04-02-2008 10:46 PM
question about about Shell programming	thungmail	Shell Programming and Scripting	1	04-01-2008 01:40 PM

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Switch to Linear Mode Hybrid Mode Switch to Threaded Mode	Rate This Thread:


	Powered by