Go Back   The UNIX and Linux Forums > Top Forums > Shell Programming and Scripting
.
google site



Shell Programming and Scripting Post questions about KSH, CSH, SH, BASH, PERL, PHP, SED, AWK and OTHER shell scripts and shell scripting languages here.

Closed Thread
English Japanese Spanish French German Portuguese Italian Powered by Powered by Google
 
Thread Tools Search this Thread Rate Thread Display Modes
  #1 (permalink)  
Old 03-24-2008
Registered User
 

Join Date: Mar 2008
Posts: 12
my shell script (file modifications)

hi guys

Need some help on my below script

#!/bin/sh
if [ -f /root/joy/inittab ]
then
echo "~~:S:wait:/sbin/sulogin" >> /root/joy/inittab
else
echo "/root/joy/inittab does not exist"
fi

now the problem is that when i run the above script it runs successfully
but when i run it repeatedly the word echo "~~:S:wait:/sbin/sulogin" gets added to the file irrespectively the no of times i run the script.
I jst want the line created jst once in the file irrespective of times i run the script.How do i do pls help and thanks in advance

reg:ash
Sponsored Links
  #2 (permalink)  
Old 03-24-2008
in2nix4life's Avatar
Registered User
 

Join Date: Oct 2007
Location: East Coast
Posts: 58
Hope this helps:

#!/bin/bash

if [ -f /root/joy/inittab ]
then
# check to see if inittab already contains this line
grep "~~:S:wait:/sbin/sulogin" /root/joy/inittab >/dev/null

# check return code from grep 0 line was found 1 or higher it wasn't
errorcode=`echo $?`
if [ $errorcode -ne 0 ]
then
echo "~~:S:wait:/sbin/sulogin" >> /root/joy/inittab
fi
else
echo "inittab does not exist"
fi
  #3 (permalink)  
Old 03-24-2008
era era is offline Forum Advisor  
Herder of Useless Cats (On Sabbatical)
 

Join Date: Mar 2008
Location: /there/is/only/bin/sh
Posts: 3,652
Just as a stylistic comment, "if" looks at the error code from whatever command you run it on; "if test $?" is a rather roundabout way of saying it.


Code:
#!/bin/bash

if [ -f /root/joy/inittab ]
then
  # check to see if inittab already contains this line
  if ! grep "~~:S:wait:/sbin/sulogin" /root/joy/inittab >/dev/null
  then
    echo "~~:S:wait:/sbin/sulogin" >> /root/joy/inittab
  fi
else
  echo "inittab does not exist"
fi

In theory, there is a race condition here; you should take care not to end up running many of these at the same time, or they will stumble over each other.
Sponsored Links
Closed Thread

Bookmarks

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are Off


More UNIX and Linux Forum Topics You Might Find Helpful
Thread Thread Starter Forum Replies Last Post
question about testing in shell programming(modifications were made) thungmail Shell Programming and Scripting 2 04-08-2008 04:51 PM
Shell Script to Load data into the database using a .csv file and .ctl file Csmani Shell Programming and Scripting 3 05-24-2006 09:09 AM
Reading file names from a file and executing the relative file from shell script anushilrai Shell Programming and Scripting 4 03-10-2006 05:25 AM
Tracing file modifications gupta_ca UNIX for Advanced & Expert Users 3 08-03-2005 09:50 AM
In Line File Modifications: Search and Replace Shakey21 Shell Programming and Scripting 2 11-20-2001 04:21 PM



All times are GMT -4. The time now is 02:26 AM.


Powered by: vBulletin, Copyright ©2000 - 2006, Jelsoft Enterprises Limited. Language Translations Powered by .
vBCredits v1.4 Copyright ©2007 - 2008, PixelFX Studios
The UNIX and Linux Forums Content Copyright ©1993-2010. All Rights Reserved.Ad Management by RedTyger

Content Relevant URLs by vBSEO 3.2.0