Quote:

Originally Posted by matrixmadhan Code: ls -1 | while read file do cp $file /some/directory/. mv $file /some/mv/directory/${file}.dat done

The -1 is unnecessary, as ls always prints one file to a line when the destination is not a terminal.

More serious is that ls itself is not only unnecessary, but will break the script if any files are badly named with leading or trailing whitespace. You can correct that with:

Code:

ls | while IFS= read -r file

The script will still fail, however, if any filenames contain spaces since you didn't quote the file variable. When dealing with filenames, always use filename expansion (globbing) rather than a command, and quote the variable, e.g.:

Code:

for file in *
do
  mv "$file" "/some/mv/directory/${file}.dat"
done

Quote:

Originally Posted by ranga27 i need to copy some files from a directory and move the copy files to some destination with the extension .dat

Code:

copy_destination=/path/to/a/directory
dat_destination=/path/to/some/destination
cp * "$copy_destination"
for file in *
do
  mv "$file" "$dat_destination/$file.dat"
done

Replace the directory paths with the correct paths, and if you do not want to copy and move all the files, change * to whatever files you do want to copy.