Use wildcards in a script

emferrari · #1 (**permalink**) 05-11-2007

Hello

I have this script:

#!/bin/ksh

INPUTFILE=$1
TEMPFILE=$INPUTFILE.$$
OUTPUTFILE=$INPUTFILE.new

# nr of arguments has to be 1
if [ $# -ne 1 ]
then
echo "\nUsage: $0 inputfile\n"
return 1
fi

# inputfile must exist and be readable
if [ ! -r $1 ]
then
echo "\nInputfile $1 does not exist. Please enter a valid filename\n"
return 1
fi

echo "\nConvert File $INPUTFILE to $OUTPUTFILE"
tr "ÖÓÒÕÔØöóòõôÄÁÀÃÂäáàãâåÜÚÙÛüúùûËÉÈÊëéèêÏÍÌÎïíìîÑñÇçªß¿"
"OOOOOOoooooAAAAAaaaaaaUUUUuuuuEEEEeeeeIIIIiiiiNnCcaS?" < $INPUTFILE >
$OUTPUTFILE

# Change ß to SS
# sed s/ß/SS/g $OUTPUTFILE > $TEMPFILE
# mv $TEMPFILE $OUTPUTFILE

echo "...ready\n"
Which does conversion in file names to the US standard. It works for
just one file at a time. I want to be able to do as the INPUTFILE a
wildcard, for example: File_*.txt.

Can someone help me on that?

Regards,

Eduardo Ferrari

Shell_Life · #2 (**permalink**) 05-11-2007

Eduardo,
See if this would work for you:
(Note: Since you are already looping thru files, there is no need to test them
for their existence nor for the number of parameters)

Code:

#!/bin/ksh
for INPUTFILE in File_*.txt
do
  TEMPFILE=$INPUTFILE.$$
  OUTPUTFILE=$INPUTFILE.new

  echo "\nConvert File $INPUTFILE to $OUTPUTFILE"
  tr "VSRUTXvsrutDA@CBda`cbe\ZY[|zy{KIHJkihjOMLNomlnQqGg*_?"
  "OOOOOOoooooAAAAAaaaaaaUUUUuuuuEEEEeeeeIIIIiiiiNnCcaS?" < $INPUTFILE > $OUTPUTFILE

  # Change _ to SS
  # sed s/_/SS/g $OUTPUTFILE > $TEMPFILE
  # mv $TEMPFILE $OUTPUTFILE

  echo "...ready\n"
done

cfajohnson · #3 (**permalink**) 05-11-2007

Quote:

Originally Posted by emferrari

Hello

I have this script:

Please put code inside code tags.

Quote:

#!/bin/ksh

INPUTFILE=$1
TEMPFILE=$INPUTFILE.$$
OUTPUTFILE=$INPUTFILE.new

# nr of arguments has to be 1
if [ $# -ne 1 ]
then
echo "\nUsage: $0 inputfile\n"
return 1
fi

# inputfile must exist and be readable
if [ ! -r $1 ]
then
echo "\nInputfile $1 does not exist. Please enter a valid filename\n"
return 1
fi

echo "\nConvert File $INPUTFILE to $OUTPUTFILE"
tr "ÖÓÒÕÔØöóòõôÄÁÀÃÂäáàãâåÜÚÙÛüúùûËÉÈÊëéèêÏÍÌÎïíìîÑñÇçªß¿"
"OOOOOOoooooAAAAAaaaaaaUUUUuuuuEEEEeeeeIIIIiiiiNnCcaS?" < $INPUTFILE >
$OUTPUTFILE

# Change ß to SS
# sed s/ß/SS/g $OUTPUTFILE > $TEMPFILE
# mv $TEMPFILE $OUTPUTFILE

echo "...ready\n"
Which does conversion in file names to the US standard. It works for
just one file at a time. I want to be able to do as the INPUTFILE a
wildcard, for example: File_*.txt.

Put your script in a loop:
Code:
for file in "$@"
do
   : put your code here; use "$file" for the filename
done
Call the script with:
Code:
name_of_script File_*.txt

emferrari · #4 (**permalink**) 05-12-2007

Thanks all, I will test Monday and let everybody knows!

Eduardo Ferrari

emferrari · #5 (**permalink**) 05-14-2007

Hi

So, now my script is like this:

for file in "$@"
do

INPUTFILE=$file
TEMPFILE=$INPUTFILE.$$
OUTPUTFILE=$INPUTFILE.new

# nr of arguments has to be 1
if [ $# -ne 1 ]
then
echo "\nUsage: $0 inputfile\n"
return 1
fi

# inputfile must exist and be readable
if [ ! -r $1 ]
then
echo "\nInputfile $file does not exist. Please enter a valid filename\n"
return 1
fi

echo "\nConvert File $INPUTFILE to $OUTPUTFILE"
tr "ÃÃÃÃ¶Ã´ÃÃ¤Ã£ÃÃÃ¼ÃÃ«ÃªÃÃ¯Ã®ÃÂªÂ¿"
"OOOOOOoooooAAAAAaaaaaaUUUUuuuuEEEEeeeeIIIIiiiiNnCcaS?" < $INPUTFILE >
$OUTPUTFILE

# Change Ã to SS
# sed s/Ã/SS/g $OUTPUTFILE > $TEMPFILE
# mv $TEMPFILE $OUTPUTFILE

echo "...ready\n"

done

[mantas@IDBBANKMANTASDEV test]$ ./convertspecch.sh File*.txt
./convertspecch.sh[33]: syntax error: `newline' unexpected

What's wrong?

aigles · #6 (**permalink**) 05-14-2007

Please put code inside code tags.

Your loop is misplaced.
When you split a command over several lines, don't forget to put the continuation character \ as the last character of lines to be continued.

Code:

# nr of arguments has to be at least 1
if [ $# -lt 1 ]
then
   echo "\nUsage: $0 inputfile(s)\n"
   return 1
fi

for inputfile in "$@"
do

   # inputfile must exist and be readable
   if [ ! -r $inputfile ]
   then
      echo "\nInputfile $inputfile does not exist. Please enter a valid filename\n"
      return 1
   fi

   outfile=$inputfile.new

   echo "\nConvert File $inputfile to $outputfile"
   tr "ÃÃÃÃ¶Ã´ÃÃ¤Ã£ÃÃÃ¼ÃÃ«ÃªÃÃ¯Ã®ÃÂªÂ¿" \
      "OOOOOOoooooAAAAAaaaaaaUUUUuuuuEEEEeeeeIIIIiiiiNnCcaS?" \
      < $inputfile >$outputfile

    echo "...ready\n"

done

Jean-Pierre.

cfajohnson · #7 (**permalink**) 05-14-2007

Quote:

Originally Posted by emferrari

Hi

So, now my script is like this:

I repeat: Please put code inside CODE tags.

The following code doesn't give me any syntax errors, but I fixed the line breaks. Could that be your problem?

There are other issues with the script.

Quote:

for file in "$@"
do

INPUTFILE=$file
TEMPFILE=$INPUTFILE.$$
OUTPUTFILE=$INPUTFILE.new

# nr of arguments has to be 1
if [ $# -ne 1 ]
then
echo "\nUsage: $0 inputfile\n"
return 1
fi

You don't need to check for number of arguments, and if you give more than one file on the command line, this will cause the script to exit.

To exit from a script, use exit, not return; return is used to exit from functions and sourced scripts.

Quote:

# inputfile must exist and be readable
if [ ! -r $1 ]
then
echo "\nInputfile $file does not exist. Please enter a valid filename\n"
return 1
fi

echo "\nConvert File $INPUTFILE to $OUTPUTFILE"
tr "ÃÃÃÃ¶Ã´ÃÃ¤Ã£ÃÃÃ¼ÃÃ«ÃªÃÃ¯Ã®ÃÂªÂ¿"
"OOOOOOoooooAAAAAaaaaaaUUUUuuuuEEEEeeeeIIIIiiiiNnCcaS?" < $INPUTFILE >
$OUTPUTFILE

There should be the same number of characters in both strings (or more in the first).

Quote your variables. That will fail if any filenames contain spaces.

Quote:

# Change Ã to SS
# sed s/Ã/SS/g $OUTPUTFILE > $TEMPFILE
# mv $TEMPFILE $OUTPUTFILE

echo "...ready\n"

done

[mantas@IDBBANKMANTASDEV test]$ ./convertspecch.sh File*.txt
./convertspecch.sh[33]: syntax error: `newline' unexpected

What's wrong?

More UNIX and Linux Forum Topics You Might Find Helpful
Thread	Thread Starter	Forum	Replies	Last Post
script for deletion using wildcards	aishu	UNIX for Dummies Questions & Answers	1	01-09-2008 05:37 PM
ls with wildcards	benu302000	UNIX for Dummies Questions & Answers	10	06-29-2005 01:53 PM
wildcards	benu302000	UNIX for Dummies Questions & Answers	3	06-29-2005 12:10 PM
Wildcards in VI	peter.herlihy	UNIX for Dummies Questions & Answers	8	01-08-2002 04:27 AM

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Switch to Linear Mode Hybrid Mode Switch to Threaded Mode	Rate This Thread: