Issue in my script

chiru_h · #1 (**permalink**) 09-26-2006

Hello !!

I have a config file with all the server values. I am looking to write a script which edits the file with command line parameters passed to the script. Here is the script:

Code:

function Usage {
  echo "Usage: $0 -thrdcnt <count> -initHeap <init> -maxHeap <max> "
  }
##########
if [[ $# -lt 1 ]];
  then
      Usage
      exit 1
fi
# Now process positional parameters"
while [ $# -gt 0 ]
do
        case "$1" in
            -thrdcnt)
                thrdcnt=$2;shift
                ;;
            -initHeap)
                initHeap=$2;shift
                ;;
            -maxHeap)
                maxHeap=$2;shift
                ;;
	    --)  shift; break;;
            -*)
                Usage
                exit 1;;
             *) break;; # terminate while loop
        esac
        shift
done
###################
ConfigFile=bw_config.xml
temp=
echo $thrdcnt
if [ $thrdcnt -ne $temp ]; then
   sed 's/<threadCount>[-[:alnum:]./]\{1,\}<\/threadCount>/<threadCount>'${thrdcnt}'<\/threadCount>/' "$ConfigFile" > ./tmpfile
   mv ./tmpfile "$ConfigFile"
fi
echo $initHeap
if [ $initHeap -ne $temp ]; then
   sed 's/<initHeapSize>[-[:alnum:]./]\{1,\}<\/initHeapSize>/<initHeapSize>'${initHeap}'<\/initHeapSize>/' "$ConfigFile" > ./tmpfile
   mv ./tmpfile "$ConfigFile"
else
  echo " "
fi
echo $maxHeap
if [ $maxHeap -ne $temp ]; then
   sed 's/<maxHeapSize>[-[:alnum:]./]\{1,\}<\/maxHeapSize>/<maxHeapSize>'${maxHeap}'<\/maxHeapSize>/' "$ConfigFile" > ./tmpfile
   mv ./tmpfile "$ConfigFile"
else
  echo " "
fi

I must be able to use only few parameters or all parameters depending on what is being changed.
I put temp as blank so as to ignore the argument if not specified. not sure if it is right.
With the above script, I am getting the following error:
./configchanges1.sh[65]: [: -ne: missing second argument

I tried several ways, it is working in bits, not working as a whole.
Need help in knowing if my argument passing is right and where am I going wrong with the if statement.

Thanks
Chiru

Andrek · #2 (**permalink**) 09-26-2006

Try trplacing your while loop and case statment with the following.

while getopts t:h:m: opt
do
case $opt in
t) thrdcnt=$OPTARG ;;
h) initHeap=$OPTARG ;;
m) maxHeap=$OPTARG ;;
*) Usage ;;
esac
done

your usage would be ....

"configchanges1.sh -t xx -h yy -m xx"

reborg · #3 (**permalink**) 09-26-2006

Code:

temp=
echo $thrdcnt
if [ $thrdcnt -ne $temp ]; then

Think you might have a problem here?

aigles · #4 (**permalink**) 09-27-2006

Modify your tests :

Code:

if [ -n "$thrdcnt" ] ; then

or

Code:

if [ "$thrdcnt" ] ; then

Jean-Pierre.

chiru_h · #5 (**permalink**) 09-27-2006

I had to give the parameters not just letters as there are several options and couldn't assign a meaningful letter for each argument.
I believe, by assigning 'temp=' , it is not taking it as argument, but even when I said "if [ $thrdcnt -ne "" ]; then" still it didn't work.

Thanks Jean-Pierre. Your statement works perfectly fine.

Chiru

More UNIX and Linux Forum Topics You Might Find Helpful
Thread	Thread Starter	Forum	Replies	Last Post
Performance issue with ftp script.	Shiv@jad	Shell Programming and Scripting	7	07-03-2009 12:01 PM
Issue with the shell script	viv1	Shell Programming and Scripting	2	02-19-2008 12:02 AM
SFTP script issue	sdhalepaska	UNIX for Dummies Questions & Answers	0	07-05-2007 01:24 PM
please help ftp script issue	mgirinath	Shell Programming and Scripting	4	04-28-2006 10:33 AM
Issue with sed in script	bthomas	Shell Programming and Scripting	3	04-14-2005 04:21 PM

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Switch to Linear Mode Hybrid Mode Switch to Threaded Mode	Rate This Thread:


	Powered by