For loop find statement file name manipulation

cbo0485 · #1 (**permalink**) 07-03-2009

Code:

for i in `find . -name "*.BEFORE_DISASTER_RECOVERY"`;do dir_name=`dirname $i`;file_name=`basename $i`;cd $dir_name;mv $file_name (STUCK HERE) ;pwd;cd $BASE_DIR;done

Okay, so I was able to get to this point. As you can see, I have a small for loop that searches for any files with the string BEFORE_DISASTER_RECOVERY in the file name, it then sets two variables dir_name and file_name, cd's to the dir_name directory, and then this is where I'm stuck. I need to mv $file_name to $filename minus ".BEFORE_DISASTER_RECOVERY.

I'm sure it's something simple, but this is where I'm currently stuck.

vidyadhar85 · #2 (**permalink**) 07-03-2009

what do you mean by $filename "minus"??
is it mv test.txt test-.txt??

cfajohnson · #3 (**permalink**) 07-03-2009

Quote:

Originally Posted by cbo0485

(Code reformatted for legibility)

Quote:

Code:

for i in `find . -name "*.BEFORE_DISASTER_RECOVERY"`

That will fail if any filenames contain spaces. Pipe the output of find into a loop:
Code:
find . -name "*.BEFORE_DISASTER_RECOVERY" |
while read file
do
  : do whatever
done
(And your script will be more legible if you use a meaningful variable name for the loop.)

Quote:

Code:

do
  dir_name=`dirname $i`
  file_name=`basename $i`

There is no need for either external command, dirname or basename. The Unix shell can do it internally:
Code:
dir_name=${file%/*}
file_name=${file##*/}

Quote:

Code:

  cd $dir_name
  mv $file_name # (STUCK HERE)

Both the cd and mv will fail if $dir_name contains spaces. Quote variable references:
Code:
  cd "$dir_name"
  mv "$file_name"

Quote:

Code:

  pwd
  cd $BASE_DIR
done

Okay, so I was able to get to this point. As you can see, I have a small for loop that searches for any files with the string BEFORE_DISASTER_RECOVERY in the file name, it then sets two variables dir_name and file_name, cd's to the dir_name directory, and then this is where I'm stuck. I need to mv $file_name to $filename minus ".BEFORE_DISASTER_RECOVERY.

I'm sure it's something simple, but this is where I'm currently stuck.

All you need is:

Code:

find . -name "*.BEFORE_DISASTER_RECOVERY" |
while read file
do
  mv "$file" "$file%.BEFORE_DISASTER_RECOVERY}"
done

cbo0485 · #4 (**permalink**) 07-03-2009

Quote:

Originally Posted by cfajohnson

(Code reformatted for legibility)

That will fail if any filenames contain spaces. Pipe the output of find into a loop:
Code:
find . -name "*.BEFORE_DISASTER_RECOVERY" |
while read file
do
  : do whatever
done
(And your script will be more legible if you use a meaningful variable name for the loop.)

There is no need for either external command, dirname or basename. The Unix shell can do it internally:
Code:
dir_name=${file%/*}
file_name=${file##*/}

Both the cd and mv will fail if $dir_name contains spaces. Quote variable references:
Code:
  cd "$dir_name"
  mv "$file_name"

All you need is:

Code:

find . -name "*.BEFORE_DISASTER_RECOVERY" |
while read file
do
  mv "$file" "$file%.BEFORE_DISASTER_RECOVERY}"
done

I definitely knew I was new to linux scripting, but never realized I was that bad, lol.

Anyways, I think you misunderstood or had a typo, I don't want to add that to my file, I want to remove it.

I have files named:

startServerABC.BEFORE_DISASTER_RECOVERY
or
startServer.sh.BEFORE_DISASTER_RECOVERY

I need to remove the .BEFORE_DISASTER_RECOVERY from the file name, to be left with

startServerABC or startServer.sh

vidyadhar85 · #5 (**permalink**) 07-03-2009

then use the basename only

Code:

basename "$filename" .BEFORE_DISASTER_RECOVERY
home> basename startServer.sh.BEFORE_DISASTER_RECOVERY .BEFORE_DISASTER_RECOVERY
startServer.sh
home>  basename startServerABC.BEFORE_DISASTER_RECOVERY .BEFORE_DISASTER_RECOVERY
startServerABC

I think you got my point...

cbo0485 · #6 (**permalink**) 07-06-2009

Quote:

Originally Posted by vidyadhar85

then use the basename only

Code:

basename "$filename" .BEFORE_DISASTER_RECOVERY
home> basename startServer.sh.BEFORE_DISASTER_RECOVERY .BEFORE_DISASTER_RECOVERY
startServer.sh
home>  basename startServerABC.BEFORE_DISASTER_RECOVERY .BEFORE_DISASTER_RECOVERY
startServerABC

I think you got my point...

This works perfectly inside my loop.

Thanks

Code:

for i in `find . -name "*.BEFORE_DISASTER_RECOVERY"`;do dir_name=`dirname $i`;file_name=`basename $i`;cd $dir_name;cp $file_name `basename $file_name .BEFORE_DISASTER_RECOVERY`;pwd;cd $BASE_DIR;done

More UNIX and Linux Forum Topics You Might Find Helpful
Thread	Thread Starter	Forum	Replies	Last Post
For loop using find with file name spaces	mronsman	UNIX for Dummies Questions & Answers	3	09-12-2008 08:23 AM
Variable problem in for loop with if statement	ejdv	Shell Programming and Scripting	6	06-17-2008 08:52 AM
For loop statement - catch error	lumdev	Shell Programming and Scripting	4	09-20-2007 07:50 AM
if statement in a while loop	bobo	UNIX for Dummies Questions & Answers	2	11-07-2006 12:38 PM
if statement in for loop of a string	Sniper Pixie	UNIX for Dummies Questions & Answers	7	03-02-2006 07:28 AM

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode	Rate This Thread: