Perl Script issue. What am I doing wrong?

SkySmart · #1 (**permalink**) 03-18-2009

#!/usr/local/bin/perl

open (MYFILE, 'logs_report');

while (<MYFILE>) {

$rec=$_;
chomp ($rec);
@arr=split(/ /,$rec);
print $rec,"\n" if ($arr[12]!~/OK/);

open (MYF, '>data.txt');

print $rec,"\n" if ($arr[12]!~/OK/);
close (MYF);

}
close (MYFILE);

ok, here's what i'm trying to u. I'm opening the file logs_report and i'm grepping only for lines that DOES NOT have OK in it.

Now, the result i get from that grep is what I"m trying to write to a file.

How can I do that?

so pretty much, i'm trying to open up a file, read the contents of the file, pull out certain lines from that file, and the certain lines i print out, i want to write it to a file. how can i do that? also, if i want to mail the file that is written out to, is there a way to do that in perl?

matrixmadhan · #2 (**permalink**) 03-18-2009

Quote:

print $rec,"\n" if ($arr[12]!~/OK/);

write it to the file and not to the stream

Code:

print MYF $rec,"\n" if ($arr[12]!~/OK/);

pludi · #3 (**permalink**) 03-18-2009

Code:

#!/usr/local/bin/perl

open (MYFILE, 'logs_report');
open (MYF, '>data.txt');

while ($rec = <MYFILE>) {
    chomp($rec);
    @arr = split(/ /,$rec);
    if ($arr[12] !~ /OK/) {
        print $rec, "\n";
        print MYF $red, "\n";
    }
}
close (MYF);
close (MYFILE);

This is probably what you want. The way you wrote it, you'd overwrite your data.txt every time you find something, plus opening and closing repeatedly in a loop can be quite I/O cost intensive.

And the next time you post listings or source, enclose it in [ code][/code ] tags (sans the spaces), to preserve formatting for readability.

KevinADC · #4 (**permalink**) 03-18-2009

Similar to my reply in your other thread that I think you didn't read. Assumes same example data from that thread.

This should be more efficient and maybe more accurate:

Code:

#!/usr/local/bin/perl
use strict;

open (MYFILE, 'logs_report') or die "$!";
open (MYF, '>data.txt') or die "$!";

while (my $rec = <MYFILE>) {
    next if ($rec =~ /STATE: OK/) {
    print MYF $rec;
}
close (MYF);
close (MYFILE);

Pludis code has a small typo, it has $red where it should be $rec.

SkySmart · #5 (**permalink**) 03-18-2009

Quote:

Originally Posted by pludi

Code:

#!/usr/local/bin/perl

open (MYFILE, 'logs_report');
open (MYF, '>data.txt');

while ($rec = <MYFILE>) {
    chomp($rec);
    @arr = split(/ /,$rec);
    if ($arr[12] !~ /OK/) {
        print $rec, "\n";
        print MYF $red, "\n";
    }
}
close (MYF);
close (MYFILE);

This is probably what you want. The way you wrote it, you'd overwrite your data.txt every time you find something, plus opening and closing repeatedly in a loop can be quite I/O cost intensive.

And the next time you post listings or source, enclose it in [ code][/code ] tags (sans the spaces), to preserve formatting for readability.

thank you. sorry for not including the codes. would you happen to know how to include a code in ur code that will email the file to a set of email addresses? i mean the file that is written to? your help or input is greatly appreciated. thanks

SkySmart · #6 (**permalink**) 03-18-2009

Quote:

Originally Posted by KevinADC

Similar to my reply in your other thread that I think you didn't read. Assumes same example data from that thread.

This should be more efficient and maybe more accurate:

Code:

#!/usr/local/bin/perl
use strict;

open (MYFILE, 'logs_report') or die "$!";
open (MYF, '>data.txt') or die "$!";

while (my $rec = <MYFILE>) {
    next if ($rec =~ /STATE: OK/) {
    print MYF $rec;
}
close (MYF);
close (MYFILE);

Pludis code has a small typo, it has $red where it should be $rec.

yes i did read your post in the other thread. when i went to use it i wasn't getting any response back. i think the problem was in the line that i bolded.

i'll try this script of yours and see if it outputs something. thanks a million.

SkySmart · #7 (**permalink**) 03-18-2009

below is the code I came up with to get the file data.txt as an attachment and send it out:

Code:

sub test_mail {
my $msg = MIME::Lite->new(
   From    =>  'noreply@faroko.com',
   To      =>  'jamie.henson@faroko.com',
   Subject =>  'TESTING',
   Type    =>  'multipart/mixed',
);

$msg->attach(
    Type   =>  'TEST',
    Data   =>  "TESTING ATTACHMENT FEATURE",
);

$msg->attach(
    Type   =>   'TEST',
    Path   =>   'data.txt',
    Filename => 'data.txt',
);

$msg->send;
}

How can I incorporate this script into the existing script to have it send out the data.txt file to the email addresses.

More UNIX and Linux Forum Topics You Might Find Helpful
Thread	Thread Starter	Forum	Replies	Last Post
Perl Issue	raj001	Shell Programming and Scripting	23	01-30-2009 06:12 AM
Perl Script Issue - Please Help * Thanks!!!	jroberson	Shell Programming and Scripting	8	11-03-2008 03:47 AM
perl issue ..	zedex	Shell Programming and Scripting	3	09-13-2008 11:22 PM
What is wrong with this script?	heprox	Shell Programming and Scripting	8	11-16-2006 05:43 AM
perl regexp error , I cant understand what is wrong	umen	Shell Programming and Scripting	4	10-19-2006 10:35 AM

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode	Rate This Thread: