Short code driving me nuts.

daddygrant · #1 (**permalink**) 02-09-2009

Hello guys I am trying to learn perl and have a simple calculator I am trying to run but I get error runaway multi-line. Can someone point this rookie in the right direction.

###

print 'Welcome to the Calculator';
print 'Would you like to enter the calculator? Please Type y or n';
$run = <stdin>;
chomp $run;
while ($run == y)
{
{
print 'Add = a | Subtract = s | Multiply = m | Divide = d |Exponent = e | Mod = O ';
print 'Enter the corresponding number to the caluclation to be performed:';
$calc = <stdin>;
chomp $calc;
print 'Please enter the first value: ';
$A = <stdin>;
chomp $A;
print 'Please enter the second value: ';
$B = <stdin>;
chomp $B;

if($calc == a)
{
$answer = $A + $B;
}
elsif($calc == s)
{
$answer = $A - $B;
}
elsif($calc == m)
{
$answer = $A * $B;
}
elsif($calc == d)
{
$answer = $A / $B;
}
elsif($calc == e)
{
$answer = $A ** $B;
}
elsif($calc == o)
{
$answer = $A % $B;
}
print "The answer is $answer .";
}
print 'Would you like to perform another calculation? Please Type y or n';
$run = <stdin>;
chomp = $run;
}

print 'The application is now terminated.';

###

jim mcnamara · #2 (**permalink**) 02-09-2009

Code:

if ($answer eq "a" )

strings use eq or ne, etc for comparison

daddygrant · #3 (**permalink**) 02-09-2009

Same error on when i replace == with eq.

Quote:

if($calc == a)

avronius · #4 (**permalink**) 02-09-2009

The string comparison would be for the y/n - not the mathematics

daddygrant · #5 (**permalink**) 02-09-2009

I change the values for comparison from string to integers but I still receive the same error. "Syntax error.. might be a runaway multi-line"

Code:

print 'Welcome to the Calculator';
print 'Would you like to enter the calculator? Please Type y or n';
$run = <stdin>;
chomp $run;
while ($run == y)
    {
        {    
        print 'Add = 1 | Subtract = 2 | Multiply = 3 | Divide = 4 |Exponent = 5 | Mod = 6 ';
        print 'Enter the corresponding number to the caluclation to be performed:';
        $calc = <stdin>;
        chomp $calc;
        print 'Please enter the first value: ';
        $A = <stdin>;
        chomp $A;
        print 'Please enter the second value: ';
        $B = <stdin>;
        chomp $B;
        
        if($calc == 1)
            {
            $answer = $A + $B;
            }
        elsif($calc == 2)
            {
            $answer = $A - $B;    
            }
        elsif($calc == 3)
            {
            $answer = $A * $B;
            }    
        elsif($calc == 4)
            {
            $answer = $A / $B;
            }    
        elsif($calc == 5)
            {
            $answer = $A ** $B;
            }
        elsif$4calc == 6)
            {
            $answer = $A % $B;
            }
        print "The answer is $answer .";
        }
    print 'Would you like to perform another calculation? Please Type y or n';
    $run = <stdin>;
    chomp = $run;
    }


print 'The application is now terminated.';

pludi · #6 (**permalink**) 02-09-2009

This should work

Code:

print 'Welcome to the Calculator';
print 'Would you like to enter the calculator? Please Type y or n';
$run = <stdin>;
chomp $run;
while ($run eq "y")
    {
# Not needed        {    
        print 'Add = 1 | Subtract = 2 | Multiply = 3 | Divide = 4 |Exponent = 5 | Mod = 6 ';
        print 'Enter the corresponding number to the caluclation to be performed:';
        $calc = <stdin>;
        chomp $calc;
        print 'Please enter the first value: ';
        $A = <stdin>;
        chomp $A;
        print 'Please enter the second value: ';
        $B = <stdin>;
        chomp $B;
        
        if($calc == 1)
            {
            $answer = $A + $B;
            }
        elsif($calc == 2)
            {
            $answer = $A - $B;    
            }
        elsif($calc == 3)
            {
            $answer = $A * $B;
            }    
        elsif($calc == 4)
            {
            $answer = $A / $B;
            }    
        elsif($calc == 5)
            {
            $answer = $A ** $B;
            }
        elsif$4calc == 6)
            {
            $answer = $A % $B;
            }
        print "The answer is $answer .";
# Not needed        }
    print 'Would you like to perform another calculation? Please Type y or n';
    $run = <stdin>;
    chomp $run;
    }


print 'The application is now terminated.';

Notes for the future

Always start your Perl code with use warnings; use strict; This can help you catch a lot of bugs before they become bugs.
Please post more of the error output next time (eg "(Might be a runaway multi-line )) string starting on line 22)" instead of "Might be a runaway multi-line"
If you want a String in Perl, use " or ' to enclose, and eq to test them
[+] print does not append a newline to it's output, you'll have to add that yourself

avronius · #7 (**permalink**) 02-09-2009

I'd recommend that you create a subroutine with your calculator functions inside.
Have your script ask if the user wants to enter the calculator - call the subroutine.
Have your script ask if the user wants to continue - if yes, call the subroutine. if no, exit.

Edit: I was looking at format not syntax... bad Avron!

More UNIX and Linux Forum Topics You Might Find Helpful
Thread	Thread Starter	Forum	Replies	Last Post
Pleas help..this is driving me crazy	hckygoli31	Shell Programming and Scripting	0	05-13-2008 05:59 AM
Test-driving OpenOffice.org 3.0	iBot	UNIX and Linux RSS News	0	04-04-2008 12:10 PM
Dumb question but its driving me nuts	jepombar	UNIX for Dummies Questions & Answers	3	07-03-2007 03:32 PM
Simple test driving me mad!	alarmcall	Shell Programming and Scripting	6	10-27-2003 10:29 AM
unix driving me crazy	Tendernisin	UNIX for Dummies Questions & Answers	1	11-29-2001 10:38 PM

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Switch to Linear Mode Hybrid Mode Switch to Threaded Mode	Rate This Thread: