Shell Programming and Scripting

I need a script to open a text file with ip's in it, ping them, split the results into the ip and time from the results and e-mail them ?

here what i've done.
its porbly wrong and not workin.its for win nt4


use Net::SMTP;

# get list of ip's to ping
open (PINGFILE, "< c:\\Documents and Settings\\pinghosts.txt") or die "Can't open PingHost lsit: $!";

my @pinglist;
my $machinenumber = 0;

while ($line = <PINGFILE>) {
chomp $line;
$pinglist[$machinenumber] = $line;
$machinenumber++;
}

# now ping all machines
foreach $host (@pinglist)
{

system ("ping $host > @result");

}

#split result into name and time
foreach $reply (@results){
($reply)=split(//, $_)
};


#get list of e-mail addresses to send e-mails to
open (EMAILS, "< c:\\Documents and Settings\\emaillist.txt") or die "Can't open e-mail list: $!";

@TO = readdir EMAILS;

foreach $to (@TO){}

$from = "colinctdprep@oceanfree.net";
@body = $reply;
$subject = "PERL pinghost program report";
{

$smtp = Net::SMTP->new("icmp");
die "Could not make connection: $!" if (defined $smtp);

$smtp->mail($from);
$smtp->to($to);

$smtp->data();
$smtp->datasend("To: $to\n");
$smtp->datasend("From: $from\n");
$smtp->datasend("Subject: $subject\n");
$smtp->datasend("\n");
foreach(@body) {
$smtp->datasend("$_\n");
}
$smtp->dataend();
$smtp->quit;
}

close EMAILS;

Here are some suggestions:

use Net::SMTP;

my (@pinglist, $host, @results, @TO);

# get list of ip's to ping
# using a single instead of double quote around the filename eliminates the need for \\
# the second line stores the entire file in an array automagically
# it's good to always close a file when you're done with it

open (PINGFILE, '<c:\Documents and Settings\pinghosts.txt') or die "Can't open PingHost list: $!";
@pinglist = <PINGFILE>;
close(PINGFILE);

# now ping all machines
# this scrolls through the array, but each IP address is stored in $_ intead of $host
# you can't use > to push new values into an array, so you may want to create a new text file

foreach (@pinglist) {
system("ping $_ > results.txt");
}

open (IPFILE, '<results.txt') or die "Can't open IP list: $!";
@results = <IPFILE>;
close(IPFILE);

I hope some of these are helpful suggestions.. this pretty much cuts off in the middle of your script, but I'm out of time for now

it just print the result on screen not into results.txt

Sorry, I may be telling you wrong on that part. I don't have a computer set up to test Perl right now.. you could try pushing the result directly into the @results array:

# now ping all machines
foreach (@pinglist) {
push(@result, system("ping $_"));
}

still wont work

keeps printing the results onto screen.

can you put thr results into an array lik this

foreach (@pinglist) {

system ("ping $_ \@results")
}

???

perleo,

without giving you the WHOLE answer, the following code will ping each IP address in the requested file and store the results in the array @results

Code:

#!/perl/bin/perl -w

use strict;
use Net::SMTP; 

# get list of ip's to ping 
open (PINGFILE, "< c:\\pinghosts.txt") or die "Can't open PingHost list: $!"; 

my @pinglist;
my @results;
my $holder;

while (my $line = <PINGFILE>) { 
	chomp $line;
	# place the host ipaddress in the array @pinglist
	push @pinglist, $line; 
} 

# now ping all machines
foreach my $host (@pinglist) {
	# place results of ping in $holder 
	$holder = `ping $host`;
	# place contents of $holder into the array @results
	push @results, $holder; 
}

NOTE: check the location of the file to open - I changed it for testing purposes.

Let me know how it goes

works

so, how do i split the result just to print the IP and the time
e.g: 192.001.0.002 time>1ms

something like

@result=split(// , $_);

and then to print the results from the split into an array.
can you PLEASE! help me with that !