Perl program to run a Shell script issues...


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Perl program to run a Shell script issues...
# 1  
Old 08-14-2013
Perl program to run a Shell script issues...

Hi all,

I have the following Perl script which is intended to run a Shell script and generate some logging for the purposes of tracking weather or not the script ran.

I get an error, of course, since I don't know what I'm doing really.

Here is the code:

Code:
#!/opt/perl/bin/perl -w  

# Using recommended pragmas 
use strict; 
use warnings;  

use File::Basename;  

my $Directory = "/directory/script"; 
my $LogFile   = $Directory . "/logs/" . basename($0, ".pl") . ".log"; my $RunFile   = $Directory . "/logs/" . basename($0, ".pl") . ".run"; my $RunScript = $Directory . "/directory/script/script.sh";  


my $OutfileH; #Output File Handle 
print $OutfileH;  

# Make sure another instance isn't already running my $pp = Proc::Pidfile->new (pidfile => $RunFile) or die "Unable to create pidfile: $RunFile\n";  

open( $OutfileH, '>>', $LogFile); 
print $OutfileH &nicetime . ":Running script - " . $RunScript . "\n"; close($OutFileH);  

#Run the shell script through perl program system( $RunScript, ">>/directory/script/logs/script.log  2>&1" ) == 0 or print $OutFileH &nicetime "Script FAILED\n"  or exit(1);  exit(0);  

#Functions 
########################################################################## 

sub nicetime {    
my ( $sec, $min, $hour, $mday, $mon, $year, $yday, $isdst ) = localtime(time);    
my $timestr = sprintf "%4d-%02d-%02d %02d:%02d:%02d", $year + 1900, $mon + 1, $mday, $hour, $min, $sec;    
return $timestr; };

The errors I get are:

Code:
String found where operator expected at script.pl line 25, near "&nicetime "Script FAILED\n""         (Missing operator before  "Script FAILED\n"?) 
Global symbol "$OutFileH" requires explicit package name at scrit.pl line 22. 
Global symbol "$OutFileH" requires explicit package name at talend.pl line 25. 
syntax error at script.pl line 25, near "&nicetime "Script FAILED\n"" 
Execution of script.pl aborted due to compilation errors.

# 2  
Old 08-14-2013
after quick look,
seems you have not declared
Code:
$OutFileH

Code:
my $OutfileH; #Output File Handle


Last edited by Scott; 08-14-2013 at 04:25 PM.. Reason: Code tags
This User Gave Thanks to greet_sed For This Post:
# 3  
Old 08-14-2013
Oh right I noticed that. Is it just the misspelling, or that it's not declared?

---------- Post updated at 03:29 PM ---------- Previous update was at 03:24 PM ----------

Ok fixed that, but now I still have this issue:

Code:
root@comp:/directory/script# perl script.pl 
String found where operator expected at script.pl line 25, near "&nicetime "Script FAILED\n""         
          (Missing operator before  "Script FAILED\n"?) syntax error at script.pl line 25, near "&nicetime "Script FAILED\n"" 
Execution of script.pl aborted due to compilation errors.

# 4  
Old 08-14-2013
Yes, just a typo.
This User Gave Thanks to greet_sed For This Post:
# 5  
Old 08-14-2013
Yeah I'm still getting the following error:

Code:
root@comp:/directory/script# perl script.pl  
String found where operator expected at script.pl line 25, near "&nicetime "Script FAILED\n""                    
          (Missing operator before  "Script FAILED\n"?) syntax error at script.pl line 25, near "&nicetime "Script FAILED\n""  
Execution of script.pl aborted due to compilation errors.

# 6  
Old 08-14-2013
I apologize.

remove the last ; which is not needed for subroutine.
};
try running
Code:
perl -c <your_file_name>

# for compilation errors.
This User Gave Thanks to greet_sed For This Post:
# 7  
Old 08-15-2013
Thank you for clarifying about the ; after the operand.

Almost the same output still though.

Code:
root@comp:/directory/script# perl -c script.pl
String found where operator expected at script.pl line 25, near "&nicetime "Script FAILED\n""         
           (Missing operator before  "Script FAILED\n"?) syntax error at script.pl line 25, near "&nicetime "Script FAILED\n"" 
script.pl had compilation errors.

Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Shell script run in a case statement call to run a php file, also Perl

Linux System having all Perl, Python, PHP (and Ruby) installed From a Shell script, can call a Perl, Python, PHP (or Ruby ?) file eg eg a Shell script run in a case statement call to run a php file, also Perl or/and Python file??? Like #!/usr/bin/bash .... .... case $INPUT_STRING... (1 Reply)
Discussion started by: hoyanet
1 Replies

2. Shell Programming and Scripting

Issues while trying to run a shell script using the command sh <filename.prog>

Hi, I'm facing issues while trying to run a sample program on Linux. If I try to run the script using the command "sh <filename.prog>", it doesn't work. But, if I try to execute it using the command "ksh <filename.prog>", it works fine. Even ". ./filename.prog" works fine. Can you... (6 Replies)
Discussion started by: venkatesh17
6 Replies

3. Shell Programming and Scripting

Shell script to run a python program on multiple entries in a file

Hello I am trying to run a python program using shell script, which takes a single argument from a file. This file has one entry per line : 1aaa 2bbb 3ccc 4ddd 5eee ... ... ... My shell script runs the program, only for the last entry : #!/bin/sh IFS=$'\n' for line in $(cat... (2 Replies)
Discussion started by: ad23
2 Replies

4. Shell Programming and Scripting

Calling perl script in shell program

How to call a perl script in shell program / shell scripting. PLS HELP ME (2 Replies)
Discussion started by: hravisankar
2 Replies

5. Shell Programming and Scripting

Run shell script from C program by calling fork and execl

I need to write a c program that uses the fork and excel system calls to run the shell script mode invoked like this: "./mode 644 ls -l" (that is the argumetns will always be 644 ls -l) here's the mode script: #!/bin/sh octal="$1" shift find . -maxdepth 1 -perm $octal -exec $@ {} \; ... (3 Replies)
Discussion started by: computethis
3 Replies

6. Shell Programming and Scripting

Can you run a unix script from a perl program

Hi all i have a unix script reformatter.sh i have a process whereby this script reformats a file before a perl program is used to update it i am having a little problem automating the entire process . is there a way whereby i can call the unix script from the perl program ? (12 Replies)
Discussion started by: dwightja24
12 Replies

7. Shell Programming and Scripting

How to run perl code within a shell script...?

Hi, I have a sheel script that invokes a perl script...Now, instead havin the perl script as a separate file I'd like put the contents in the sheel script itself...But I am not sure how ro run that perl script contents.please help me Thanks (1 Reply)
Discussion started by: vijay_0209
1 Replies

8. Shell Programming and Scripting

Run shell program in perl

Hello , I want to run some shell scripts in my perl script. I need to read the script's name from a file ( this file includes the name of all the scripts) and run the script one by one.. Please let me know how to go .. Thanks in advance, Radha (5 Replies)
Discussion started by: s123.radha
5 Replies

9. Shell Programming and Scripting

want to run different files under the same program using shell script

suppose have different files 1.1 2.2 3.3 4.4 5.5 All the files have to run under the same command say tr -d '\n' so how to run all the files under the same command by using shell script (3 Replies)
Discussion started by: cdfd123
3 Replies

10. Shell Programming and Scripting

How to Run a shell script from Perl script in Parent shell?

Hi Perl/UNIX experts, I have a problem in running a shell script from my perl script (auto.pl). I run the perl script using perl auto.pl from the shell prompt The shell script picks the files in "input" folder and procesess it. The shell script blue.sh has this code. export... (16 Replies)
Discussion started by: hifake
16 Replies
Login or Register to Ask a Question