Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

Function into a condition ?

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Function into a condition ?
# 8  
Old 03-18-2013
Which one are hours?

Which one are days?

Which one are minutes?

What does your paramater file look like?

Etc.

Also, that date does look invalid since there's no 13th month.
# 9  
Old 03-18-2013
Quote:
Originally Posted by Corona688
Which one are hours?

Which one are days?

Which one are minutes?

What does your paramater file look like?

Etc.

Also, that date does look invalid since there's no 13th month.
A date is invalid if month is greater than 12 or day is greater than 31 or written in one digit or if the separator is different from dash -
An hour is invalid if it is greater than 23 or written in one digit.
A minute is invalid if it is greater than 59 or written in one digit.

Do I have answered all your questions ?


Code:
./my_script inputfile

My parameters file look like this
Code:
cat inputfile
# YEAR HOUR MN
2013-03-31 09 23 
2013-03-31 09 32

# 10  
Old 03-18-2013
Dumping it all into one huge case just makes it hard to fix, and your program can be a lot simpler. And your functions should have names that have something to do with what they're for, not things like 'g1'.
Code:
valid() {
        case "$3" in
        [0-5][0-9]) ;;
        60) ;;
        *) return 1;
        ;;

        case "$2" in
        [0-1][0-9]) ;;
        2[0-3]) ;;
        *) return 1 ;;
        esac

        OLDIFS="$IFS"
        IFS="-"
                set -- $1 # $1=YYYY, $2=MM, $3=DD
        IFS="$OLDIFS"

        case "$1" in
        [0-9][0-9][0-9][0-9]) ;;
        *) return 1;
        esac

        case "$2" in
        0[1-9]) ;;
        1[0-2]) ;;
        *) return 1;;
        esac

        case "$3" in
        0[1-9]) ;;
        [1-2][0-9]) ;;
        3[0-1]) ;;
        *) return 1 ;;
        esac

        return 0
}

while read DATE HH MM
do
        [ "${DATE:0:1}" = "#" ] && continue # Ignore comments
        [ -z "$DATE" ] && continue # Ignore blank lines

        valid $DATE $HH $MM || echo "$DATE $HH $MM is invalid"
done < inputfile

# 11  
Old 03-19-2013
Smilie Thanks a lot, it's clearer and easier to read. You take a weight off my mind.
Which partly solves my problems as the badly formatted lines are reported once.
But I am facing a problem, I can not create an another function that processes only lines well formatted. I continue to look, but all suggestions are welcome.

Another thing
Can you explain the red tag in script ?


Code:
valid() {
        case "$3" in
        [0-5][0-9]) ;;
        #60) ;;
        *) return 1;
        ;;
        esac

        case "$2" in
        [0-1][0-9]) ;;
        2[0-3]) ;;
        *) return 1 ;;
        esac

        OLDIFS="$IFS"
        IFS="-"
                set -- $1 # $1=YYYY, $2=MM, $3=DD
        IFS="$OLDIFS"

        case "$1" in
        [0-9][0-9][0-9][0-9]) ;;
        *) return 1;
        esac

        case "$2" in
        0[1-9]) ;;
        1[0-2]) ;;
        *) return 1;;
        esac

        case "$3" in
        0[1-9]) ;;
        [1-2][0-9]) ;;
        3[0-1]) ;;
        *) return 1 ;;
        esac

        return 0
}

while read DATE HH MM
do
        [ "${DATE:0:1}" = "#" ] && continue # Ignore comments
        [ -z "$DATE" ] && continue # Ignore blank lines
        valid $DATE $HH $MM || echo "$DATE $HH $MM is invalid"
done < inputfile

I am facing a problem, I can not create a function that processes only lines well formatted. I continue to look, but all suggestions are welcome.
Last edited by amazigh42; 03-19-2013 at 11:50 AM..
# 12  
Old 03-19-2013
${DATE:0:1} that's a substring operator -- the variable, the offset, and the length. An offset of 0 and length of 1 gets the first character.

To only process valid lines:
Code:
valid () { 
...
}

process() {
...
}

while read DATE HH MM
do
        [ "${DATE:0:1}" = "#" ] && continue # Ignore comments
        [ -z "$DATE" ] && continue # Ignore blank lines
        if ! valid $DATE $HH $MM # Ignore invalid lines
        then
                echo "$DATE $HH $MM is invalid"
                continue
        fi

        process $DATE $HH $MM
done < inputfile

This User Gave Thanks to Corona688 For This Post:
amazigh42
# 13  
Old 03-20-2013
Hello,
I try to understand your method.
This is why I added other cases.
But the script returns an error on a line that has good parameters.
Please, can you explain why ?
Another question :
The pattern in red means that from there, we must consider the variables starting from $ 1

Have a nice day

Code:
cat inputfile
QCVD UPG8 22 16 server 2013-01-24

Code:
./my_script
QCVD UPG8 22 16 server 2013-01-24 is invalid

Code:
#!/bin/bash
#########################################################################
valid() {
        case "$1" in
        [E,F,Q,P][A,C,S][A,I,V,P][D,R,T,V]) ;;
        *) return 1 ;;
        esac

        case "$2" in
        [PU][IPS][AGS][1-8]) ;;
        ORA[1-8]) ;;
        *) return 1 ;;
        esac

        case "$3" in
        [0-1][0-9]) ;;
        2[0-3]) ;;
        *) return 1 ;;
        esac

        case "$4" in
        [0-5][0-9]) ;;
        *) return 1 ;;
        esac

        case "$5" in
        server) ;;
        exploitation) ;;
        *) return 1 ;;
        esac

        OLDIFS="$IFS"
        IFS="-"
               set -- $1 # $1=YYYY, $2=MM, $3=DD
        IFS="$OLDIFS"

        case "$1" in
        [2-9][0-9][0-9][0-9]) ;;
        *) return 1 ;;
        esac

        case "$2" in
        0[1-9]) ;;
        1[0-2]) ;;
        *) return 1 ;;
        esac

        case "$3" in
        0[1-9]) ;;
        [1-2][0-9]) ;;
        3[0-1]) ;;
        *) return 1 ;;
        esac

        return 0
}


process() {
echo "$CONTEXTE $INSTANCE $HH $MM $type_log $DATE"
}

while read CONTEXTE INSTANCE HH MM type_log DATE
do
        [ "${DATE:0:1}" = "#" ] && continue # Ignore comments
        [ -z "$DATE" ] && continue # Ignore blank lines
        if ! valid $CONTEXTE $INSTANCE $HH $MM $type_log $DATE # Ignore invalid lines
        then
                echo "$CONTEXTE $INSTANCE $HH $MM $type_log $DATE is invalid"
                continue
        fi

        process $CONTEXTE $INSTANCE $HH $MM $type_log $DATE
done < inputfile

---------- Post updated at 07:49 AM ---------- Previous update was at 04:34 AM ----------

The red pattern was the source of my problem.
I have changed $1 in $6
Thanks a lot Mister Corona688
Marvelous forum where i learn a lot. Smilie

Code:
OLDIFS="$IFS" 
        IFS="-"                set -- $6 # $1=YYYY, $2=MM, $3=DD 
        IFS="$OLDIFS"

# 14  
Old 03-20-2013
Your config file is very different from what you said it was:

Code:
QCVD UPG8 ...

Since you didn't tell me those were there, I was using the wrong tokens.

As for what it does, the comment says it all:

Code:
set -- $1 # $1=YYYY, $2=MM, $3=DD

It alters the values of $1, $2, ... based on what you input into it. It splits upon IFS, so altering IFS lets me split on "-" instead of space. Put the wrong thing into it, get the wrong thing out.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Function - Make your function return an exit status

Hi All, Good Day, seeking for your assistance on how to not perform my 2nd, 3rd,4th etc.. function if my 1st function is in else condition. #Body function1() { if then echo "exist" else echo "not exist" } #if not exist in function1 my all other function will not proceed.... (4 Replies)
Discussion started by: meister29
4 Replies

2. Shell Programming and Scripting

Will files, creaetd in one function of the same script will be recognized in another function?

Dear All. I have a script, which process files one by one. In the script I have two functions. one sftp files to different server the other from existing file create file with different name. My question is: Will sftp function recognize files names , which are created in another... (1 Reply)
Discussion started by: digioleg54
1 Replies

3. Shell Programming and Scripting

Help to Modify File Name in each function before calling another function.

I have a script which does gunzip, zip and untar. Input to the script is file name and file directory (where file is located) I am reading the input parameters as follows: FILENAME=$1 FILEDIR=$2 I have created 3 functions that are as follows: 1) gunzip file 2) unzip file... (2 Replies)
Discussion started by: pinnacle
2 Replies

4. Shell Programming and Scripting

If condition return 0 even when it fails to satisfy te condition

HI My doubt may be basic one but I need to get it clarified.. When i use "if" condition that checks for many AND, OR logical conditions like if ]; then return 0 fi Even the if condition fails it returns as zero.. Any clue.. But if i add else condition like if ]; ... (2 Replies)
Discussion started by: Priya Amaresh
2 Replies

5. Shell Programming and Scripting

redirect stdout echo command in condition A run in condition B

hi, I have some problems in my simple script about the redirect echo stdout command inside a condition. Why is the echo command inside the elif still execute in the else command Here are my simple script After check on the two diff output the echo stdout redirect is present in two diff... (3 Replies)
Discussion started by: jao_madn
3 Replies

6. HP-UX

Difference between [condition] and [[condition]] and ((condition)) when used with if condition

Executed the following if conditions .. and got different results . only (( )) gave correct o/p with all scenarios . Can anybody please let me know what is the difference between and ] and ((condition)) when used with if condition. And why each condition gave different result. 1.... (2 Replies)
Discussion started by: soumyabubun
2 Replies

7. Programming

performance issues of calling a function in if condition

Hi, I have written a program in C and have to test the return value of the functions. So the normal way of doin this wud b int rc rc=myfunction(input); if(rc=TRUE){ } else{ } But instead of doing this I have called the function in the if() condition. Does this have any... (2 Replies)
Discussion started by: sidmania
2 Replies

8. Shell Programming and Scripting

race condition with wait() function

Hi, I'm currently writing a bash script, that starts multiple threads: ____________________ #!/bin/bash loop=0 while((loop!=10)) do thread & ((loop++)) done #wait for all sub-processes (thread) to finish wait ___________________ Now I want to know, what happens, if a... (2 Replies)
Discussion started by: tho99
2 Replies

9. Shell Programming and Scripting

Passing global variable to a function which is called by another function

Hi , I have three funcions f1, f2 and f3 . f1 calls f2 and f2 calls f3 . I have a global variable "period" which i want to pass to f3 . Can i pass the variable directly in the definition of f3 ? Pls help . sars (4 Replies)
Discussion started by: sars
4 Replies

10. Shell Programming and Scripting

problem, with if condition in function

Hi All, I have a function which reads parameter and gets the value from config file. The entry in the file can be either of two Name=value or Name=value so if the variant is not present it should return me the generic value ie Name without variant. I am first searching for variant in... (4 Replies)
Discussion started by: gurukottur
4 Replies
Login or Register to Ask a Question