Shell Programming and Scripting

Hi,

Following from other thread posted in this forum.

I'm trying to make a simple bash script to check for "php" process. If the spesific PHP script process (eg: cleanlog.php) does not run, it will then be executed from bash.

Code:

#!/bin/bash
var1=`ps -ef | grep -v grep | grep cleanlog| awk '{print $2}'`
echo $var1
if [ -n "$var1" ]
then
echo "Process running"
else
/usr/bin/php -q cleanlog.php
fi

When I tried to execute the bash script, it throws error:

Code:

line 9: syntax error near unexpected token `fi' line 9: `fi'

What is wrong with the above code, please help.

Thank you.

Hey,

I think, There is nothing wrong with the script,

May I know you system/OS..?

If you are created the shell script file in windows and transfer the file into *nix server for execution will hurt.

Any ways try,

Code:

dos2unix filename

Cheers,
Ranga

That could play a role if the script is not executed by using ./script , but for example sh script, otherwise the attempted use of the shell specified by the shebang would immediately throw an error on line 1... The script looks syntactically correct.

@rangarasan.
Sorry to not mention.

Yes, when I run that script above on Centos shell, it works fine.

But, when I tried to edit that script using notepad on Win32 and then upload it to Ubuntu server via webshell, it could not run.

I have using that command suggested "dos2unix [filename]", but it seems there's no dos2unix command. FYI, I'm not root user.

Code:

dos2unix: not found

So, I guess it might be an issue related with script editing on the webshell.

Could you post the output of cat -A bashscript.sh
Looks like the classic CR-LF problem. Try sed 's/<ctrl+v+m>$/\n/' bashscript.sh

Code:

tr -d '\r' < script > script.new

Hey,

The issue is, When you are editing the script in windows environment, It will put '\r' at the end with '\n' but *nix will not recognize these things.

Try this below,

Code:

tr -d '\r' script_name.sh >new_script_name.sh
./new_script_name.sh

That will do the trick for you.

Cheers,
Ranga