Login or Register to Ask a Question and Join Our Community


Shell Programming and Scripting

two while nested loops

Login to Discuss or Reply to this Discussion in Our Community

 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting two while nested loops
# 1  
Old 08-23-2012
two while nested loops
Code:
                        for server in $(echo `cat /tmp/ScanHosts_${USERSNAME}.TXT`)
                        do
                                for portnumber in $(echo `cat /tmp/ScanPorts_${USERSNAME}.TXT`)
                                do
                                        #echo ${server} ${portnumber}

                                        #nc -v ${server} ${portnumber} -w 2 | tr -d '\015\032' 2>/dev/null

                                        DATE=$(date | awk '{print $2" "$3" "$4" "$6}')
                                        ANSWER=$(nc -v ${server} ${portnumber} -w 2 | tr -d '\015\032' 2>/dev/null)

                                        if [ ! -z "${ANSWER}" ] ; then
                                               echo "${DATE} ${server}:${portnumber}:${ANSWER}" | tee -a /tmp/ScanResults_${USERSNAME}.txt
                                        elif [ -z "${ANSWER}" ] || [ "${ANSWER}" = "" ] ; then
                                               echo "${DATE} ${server}:${portnumber}:COULD NOT CONNECT" | tee -a /tmp/ScanResults_${USERSNAME}.txt
                                        else
                                               echo "${DATE} ${server}:${portnumber}:COULD NOT CONNECT" | tee -a /tmp/ScanResults.txt
                                        fi
                                done
                        done

is there a better way to run the above?

the first file being looped through contains a list of hosts. the second file contains a list of ports.

for each host found in the list of hosts, i want every port found in the port file scanned against it.

shell: bash
os: linux/sunos
# 2  
Old 08-23-2012
Why not just use nmap? It's the right tool for this sort of task.

Anyway, after having a quick look at your script, I came up with:

Logic: Try and change things around so you have multiple nc commands running at once (in the background). After all, the majority of the runtime for a task like this is spent wating for the reply packets.

Instead of date | awk '{print $2" "$3" "$4" "$6}', you can use date "+%d %b, %Y %T"

On this command:
Code:
ANSWER=$(nc -v ${server} ${portnumber} -w 2 | tr -d '\015\032' 2>/dev/null)

tr is pretty unlikley to produce any output on stderr, you probably want:
Code:
ANSWER=$(nc -v ${server} ${portnumber} -w 2 2> /dev/null | tr -d '\015\032')

# 3  
Old 08-23-2012
Quote:
Originally Posted by Chubler_XL
Why not just use nmap? It's the right tool for this sort of task.

Anyway, after having a quick look at your script, I came up with:

Logic: Try and change things around so you have multiple nc commands running at once (in the background). After all, the majority of the runtime for a task like this is spent wating for the reply packets.

Instead of date | awk '{print $2" "$3" "$4" "$6}', you can use date "+%d %b, %Y %T"

On this command:
Code:
ANSWER=$(nc -v ${server} ${portnumber} -w 2 | tr -d '\015\032' 2>/dev/null)

tr is pretty unlikley to produce any output on stderr, you probably want:
Code:
ANSWER=$(nc -v ${server} ${portnumber} -w 2 2> /dev/null | tr -d '\015\032')

thank you for the suggestions. i'm curious as to if all that "while looping" that im doing makes sense? is this how a more advanced user like you would do it?

i will incorporate your suggestions, however, i'm interested in making the while loop look more elegant. can awk be used for this?
Last edited by SkySmart; 08-23-2012 at 09:38 PM..
# 4  
Old 08-23-2012
The nested for loops are fine and are quite efficient as they are implemented within the shell. The trick here is to avoid calling the external command (nc) more times than is necessary.

As an example if you are just looking for open ports, you would gain a heap of performance by using the nc -z option and call nc once for the whole set of ports eg:

Code:
# nc -z host.example.com 25,80,5900-5910
Connection to host.example.com 25 port [tcp/smtp] succeeded!
Connection to host.example.com 5900 port [tcp/vnc] succeeded!

But, of course, this is different functionality and comes under requirements optimization, not code tweaking.
This User Gave Thanks to Chubler_XL For This Post:
SkySmart
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Dummies Questions & Answers

Executing nested loops+foreach

It's been a while since I used csh formatting and I am having a little bit of trouble with a few things. Things seem so much easier to execute in Matlab, however I need to do this on the terminal because of the programs I am trying to interact with. So here's what I want to do: I have a file... (0 Replies)
Discussion started by: katia
0 Replies

2. Shell Programming and Scripting

Nested for loops

Greetings All, The following script attempts to enumerate all users in all groups in the group file(GROUP) and echo the following information: GROUP ---> USER The script is as follows: IFS="," for GROUP in `ypcat -k group | cut -d" " -f1` do for USER in `ypcat -k group... (13 Replies)
Discussion started by: jacksolm
13 Replies

3. UNIX for Dummies Questions & Answers

Faster than nested while read loops?

Hi experts, I just want to know if there is a better solution to my nested while read loops below: while read line; do while read line2; do while read line3; do echo "$line $line2 $line3" done < file3.txt done < file2.txt done < file1.txt >... (4 Replies)
Discussion started by: chstr_14
4 Replies

4. Shell Programming and Scripting

KSH nested loops?

KSH isn't my strong suit but it's what my company has to offer. I've got a script with two nested loops, a FOR and UNTIL, and that works fine. When I add a CASE into the mix I end up getting "Unexpected 'done' at line xx" errors. Any suggestions on this? for divi in at ce ci cm co de di fl... (9 Replies)
Discussion started by: mrice
9 Replies

5. Shell Programming and Scripting

Need help with Regular Expressions and nested loops

Ok... am going slightly loopy trying to get this working (no pun intended) What I need is to modify this code which takes a string input then echo's each character on a seperate line, to do the same thing but to put DIGIT: in front of numbers and LETTER: in front of letters. I know a regular... (5 Replies)
Discussion started by: U_C_Dispatj
5 Replies

6. Shell Programming and Scripting

Nested while loops (ksh scripting)

You can use one while inside another? I made the following script (without really knowing if I can use two while) to get 3 numbers different from each other at random: num1=$(( $RANDOM % 10 )) num2=$num1 while do num2=$(( $RANDOM % 10 )) done num3=$num1 while do while do... (1 Reply)
Discussion started by: ale.dle
1 Replies

7. Shell Programming and Scripting

nested for loops

I need help getting over this bump on how nested for loops work in shell. Say i was comparing files in a directory in any other language my for loop would look like so for(int i=0;to then end; i++) for(int y = i+1; to the end; y++) I can't seem to understand how i can translate that... (5 Replies)
Discussion started by: taiL
5 Replies

8. Shell Programming and Scripting

file reading in nested loops

I have to to read files simultaneously in two nested loops,but am getting error can anyone do the needful. useridFile=userIds.txt fname=kiran.txt exec<$useridFile while read line do echo "User IDs are..$line" USER_ID=$line REMOTE_DIR_LOCATION="/home/test/$USER_ID" SOURCE_DIR=$USER_ID... (1 Reply)
Discussion started by: KiranKumarKarre
1 Replies

9. Shell Programming and Scripting

Grepping within nested for loops

Good morning - I have publication lists from 34 different faculty members. I need to end up with the numbers of publications in common across all 34 faculty. I need to grep person1 (last name) in list2, person1 in list3, person1 in list 4, etc., then person2 in list3, person 2 in list4, etc.,... (2 Replies)
Discussion started by: Peggy White
2 Replies

10. Shell Programming and Scripting

Complex problem about nested for loops

Hey, I'm writing this bash script that will test print me many copies of the same program but with different combos of 4 variables being between 1 and 100. Here's the code: #! /bin/bash x=0 for ((a=1; a < 101; a++)) do for ((b=1; b < 101; b++)) do for ((c=1; c < 101; c++)) do for... (4 Replies)
Discussion started by: Silverlining
4 Replies
Login or Register to Ask a Question